aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/valgrind.supp
Commit message (Collapse)AuthorAge
* Add valgrind suppression for leak in libGLX_nvidia when caching program binariesGravatar Brian Salomon2018-07-18
| | | | | | | Change-Id: Id6d32811c59b5d37579a1c1bf0f42e85d951d45f Reviewed-on: https://skia-review.googlesource.com/141821 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* update valgrind suppressions for revised keepalive threadGravatar Mike Klein2017-10-31
| | | | | | Change-Id: I28cc5923866be789d33f4a5f6c0a3be67bf096c3 Reviewed-on: https://skia-review.googlesource.com/65500 Reviewed-by: Mike Klein <mtklein@chromium.org>
* Valgrind suppressions for new Debian 9 GPU botGravatar Eric Boren2017-06-30
| | | | | | | | Bug: skia: Change-Id: I813fe71812ec65778b48b8b13f238b8df7b8f8cd Reviewed-on: https://skia-review.googlesource.com/21360 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Update Valgrind match-leak-kinds for keep-alive thread.Gravatar Mike Klein2017-02-21
| | | | | | | | | | | | | | | | Valgrind has tipped over from seeing the keep-alive thread as possibly leaked to seeing it as definitely leaked. We can suppress both. An alternative here is "all" or to just remove the line. For the moment I think this is best, as we're still excluding indirect leaks this way. I'd want to think a bit whether it made sense for the keep-alive thread to indirectly leak anything, so I'd like it to fail if it comes up. Change-Id: Ib28790a1d84a0a9061fdb6de48569ca8ea51b52a Reviewed-on: https://skia-review.googlesource.com/8764 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Update valgrind suppressionsGravatar Robert Phillips2017-02-08
| | | | | | | | | | It appears that the top-level function named has switched to just "main" Change-Id: I33a18a8d433867e759312d09e5b258f934f495a4 Reviewed-on: https://skia-review.googlesource.com/8194 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Tweak valgrind suppressions for intentional leaks.Gravatar mtklein2016-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to building the Valgrind bots with GN. It's not clear why these need to leak, but we might as well update the suppressions. The stacks now look like this: Memcheck:Leak match-leak-kinds: possible fun:calloc fun:_dl_allocate_tls fun:pthread_create@@GLIBC_2.2.5 fun:_ZN8SkThreadC1EPFvPvES0_ fun:_Z14nanobench_mainv fun:(below main) We suppress fun:main in that last slot, so just make it ... TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347153002 Review-Url: https://codereview.chromium.org/2347153002
* Suppress jpeg valgrind errorsGravatar msarett2016-01-27
| | | | | | | | | | Do a better job suppressing these errors until I can prioritize fixing them. BUG=skia:4550 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641763002 Review URL: https://codereview.chromium.org/1641763002
* update nanobench Valgrind suppressionGravatar mtklein2016-01-05
| | | | | | | | | | | | | | start_keepalive is static, so it's likely inlined. We'll put a ... where it goes to allow that. C.f. https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/529/steps/nanobench%20--abandonGpuContext/logs/stdio BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1562433002 TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/1562433002
* On Valgrind bots, print a message every 20 minutesGravatar msarett2016-01-04
| | | | | | | | | | | | | I believe that the timeout failure on the Valgrind bot occurs because we skip many tests consecutively without printing any output. Skipping these tests requires non-trivial work. Printing a message every 20 minutes will avoid timeouts. BUG=skia:4740 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1554193002 Review URL: https://codereview.chromium.org/1554193002
* Fix valgrind suppressions for libjpeg-turbo warningGravatar msarett2015-12-14
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1518393003
* Change quality settings on SkImageDecoder_libjpegGravatar msarett2015-11-11
| | | | | | | | | | | | | | | | | | | | | | It has been demonstrated that higher quality settings really do make a difference in the visual quality of the output image. https://code.google.com/p/chromium/issues/detail?id=385515 https://code.google.com/p/skia/issues/detail?id=3770 We are planning to replace SkImageDecoder with SkCodec, and SkCodec will use the higher quality settings. As a first step, we are using SkCodec as the underlying implementation for BitmapRegionDecoder. CTS tests require that BitmapRegionDecoder be a close match to BitmapFactory (which uses SkImageDecoder), so we must also update the quality of SkImageDecoder to maintain CTS compatibility. BUG=skia: Committed: https://skia.googlesource.com/skia/+/69ad6a9d03dd6f14b7c730465319313725a7c903 Review URL: https://codereview.chromium.org/1412803009
* Revert of Suppression for valgrind bug (patchset #1 id:1 of ↵Gravatar scroggo2015-10-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1410953002/ ) Reason for revert: We believe this was suppressing an out of date error that was being triggered because the valgrind bot was not rebuilding nanobench. The valgrind bot has been fixed (is there a bug tracking that?), so this suppression is probably not necessary. Original issue's description: > Suppression for valgrind bug > > TBR=msarett@google.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > BUG=skia:4478 > > Committed: https://skia.googlesource.com/skia/+/82e341ff8764ef6168a0c9322089c391d657ae7f TBR=msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4478 Review URL: https://codereview.chromium.org/1406333006
* Suppression for valgrind bugGravatar scroggo2015-10-16
| | | | | | | | | | | TBR=msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4478 Review URL: https://codereview.chromium.org/1410953002
* Fixed valgrind issues with libjpeg-turboGravatar msarett2015-07-14
| | | | | | | | | | | The fixes are in the updated libjpeg-turbo repository pulled in by DEPS. The fixes are detailed in the linked skia bug. To summarize briefly, we now use calloc() instead of malloc(). BUG=skia:4030 Review URL: https://codereview.chromium.org/1237213004
* Temporarily suppress valgrind errors in tip of tree libjpeg-turboGravatar msarett2015-07-09
| | | | | | BUG=skia:4030 Review URL: https://codereview.chromium.org/1231613004
* widen leak supression. looks like start_keepalive is sometimes inlined.Gravatar mtklein2015-03-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1008873003
* Suppress keepalive thread leak in DM.Gravatar mtklein2015-03-16
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1006143002
* Suppress another FontConfig 'leak'.Gravatar bungeman2015-02-05
| | | | | | | | | | | | FontConfig uses offsets for elements instead of pointers, so any value held by an element goes missing from memory checkers. Previous suppressions took care of rule copies and adds to elements, but value lists may be copied as well. When they are, values are copied, including the content of strings and matricies. Since value lists are effectively like Fc*Add functions (even calling the same underlying helpers), treat them as such and suppress any 'leaks' they may cause. Review URL: https://codereview.chromium.org/894863003
* Generalize valgrind suppressions for NV driver.Gravatar bsalomon2014-11-12
| | | | Review URL: https://codereview.chromium.org/723603003
* Add suppression to valgrind.supp for fun:FcConfigEvaluate.Gravatar bungeman2014-11-05
| | | | | | | Any allocation under FcConfigValues will be 'lost'. Update the valgrind suppression to reflect this. Review URL: https://codereview.chromium.org/703893003
* Revert of SkThreadPool ~~> SkTaskGroup (patchset #4 id:60001 of ↵Gravatar mtklein2014-09-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/531653002/) Reason for revert: Leaks, leaks, leaks. Original issue's description: > SkThreadPool ~~> SkTaskGroup > > SkTaskGroup is like SkThreadPool except the threads stay in > one global pool. Each SkTaskGroup itself is tiny (4 bytes) > and its wait() method applies only to tasks add()ed to that > instance, not the whole thread pool. > > This means we don't need to bring up new thread pools when > tests themselves want to use multithreading (e.g. pathops, > quilt). We just create a new SkTaskGroup and wait for that > to complete. This should be more efficient, and allow us > to expand where we use threads to really latency sensitive > places. E.g. we can probably now use these in nanobench > for CPU .skp rendering. > > Now that all threads are sharing the same pool, I think we > can remove most of the custom mechanism pathops tests use > to control threading. They'll just ride on the global pool > with all other tests now. > > This (temporarily?) removes the GPU multithreading feature > from DM, which we don't use. > > On my desktop, DM runs a little faster (57s -> 55s) in > Debug, and a lot faster in Release (36s -> 24s). The bots > show speedups of similar proportions, cutting more than a > minute off the N4/Release and Win7/Debug runtimes. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/9c7207b5dc71dc5a96a2eb107d401133333d5b6f R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, reed@google.com, mtklein@chromium.org TBR=bsalomon@google.com, bungeman@google.com, caryclark@google.com, mtklein@chromium.org, reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/533393002
* SkThreadPool ~~> SkTaskGroupGravatar mtklein2014-09-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SkTaskGroup is like SkThreadPool except the threads stay in one global pool. Each SkTaskGroup itself is tiny (4 bytes) and its wait() method applies only to tasks add()ed to that instance, not the whole thread pool. This means we don't need to bring up new thread pools when tests themselves want to use multithreading (e.g. pathops, quilt). We just create a new SkTaskGroup and wait for that to complete. This should be more efficient, and allow us to expand where we use threads to really latency sensitive places. E.g. we can probably now use these in nanobench for CPU .skp rendering. Now that all threads are sharing the same pool, I think we can remove most of the custom mechanism pathops tests use to control threading. They'll just ride on the global pool with all other tests now. This (temporarily?) removes the GPU multithreading feature from DM, which we don't use. On my desktop, DM runs a little faster (57s -> 55s) in Debug, and a lot faster in Release (36s -> 24s). The bots show speedups of similar proportions, cutting more than a minute off the N4/Release and Win7/Debug runtimes. BUG=skia: R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/531653002
* Update FontConfig valgrind suppressions.Gravatar bungeman2014-08-29
| | | | | | | | | | | | | FcPattern uses 'intptr_t elts_offsets' instead of 'FcPatternEltPtr elts' to reference its elements. Therefore, valgrind suspects possible leaks on all values, elements, and element lists in FontConfig. BUG=skia:2879 R=djsollen@google.com, mtklein@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/518903002
* Update valgrind suppression file for new FontConfig code.Gravatar bungeman2014-08-26
| | | | | | | | | BUG=skia:2879 R=djsollen@google.com, mtklein@google.com Author: bungeman@google.com Review URL: https://codereview.chromium.org/488343003
* valgrind suppression for zlib Flate TestGravatar halcanary2014-08-14
| | | | | | | | | | NOTREECHECKS=true NOTRY=true R=bsalomon@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/477733002
* Add valgrind supp for NV driver.Gravatar bsalomon2014-06-25
| | | | | | | | R=mtklein@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/351053002
* Update valgrind suppression fileGravatar commit-bot@chromium.org2014-05-19
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/292453010 git-svn-id: http://skia.googlecode.com/svn/trunk@14791 2bbb7eff-a529-9590-31e7-b0007b416f81
* one valgrind.supp to rule them all.Gravatar commit-bot@chromium.org2014-04-30
| | | | | | | | | | R=mtklein@google.com, robertphillips@google.com, borenet@google.com Author: bsalomon@google.com Review URL: https://codereview.chromium.org/268473004 git-svn-id: http://skia.googlecode.com/svn/trunk@14487 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix valgrind suppressions (again)Gravatar robertphillips@google.com2014-02-14
| | | | | | | | https://codereview.chromium.org/166193003/ git-svn-id: http://skia.googlecode.com/svn/trunk@13449 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix valgrind suppressionsGravatar robertphillips@google.com2014-02-11
| | | | | | | | https://codereview.chromium.org/158493004/ git-svn-id: http://skia.googlecode.com/svn/trunk@13403 2bbb7eff-a529-9590-31e7-b0007b416f81
* Suppress new valgrind complaintGravatar robertphillips@google.com2014-01-30
| | | | | | | | https://codereview.chromium.org/144853006/ git-svn-id: http://skia.googlecode.com/svn/trunk@13244 2bbb7eff-a529-9590-31e7-b0007b416f81
* Yet another round of valgrind suppressionsGravatar robertphillips@google.com2013-12-19
| | | | | | | | https://codereview.chromium.org/116053004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12766 2bbb7eff-a529-9590-31e7-b0007b416f81
* Suppress questionable gpu errorsGravatar robertphillips@google.com2013-12-18
| | | | | | | | https://codereview.chromium.org/118283002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12743 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add more valgrind suppressionsGravatar robertphillips@google.com2013-12-09
| | | | | | | | https://codereview.chromium.org/102443003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12561 2bbb7eff-a529-9590-31e7-b0007b416f81
* Generalize valgrind suppressions & a 2 moreGravatar robertphillips@google.com2013-12-06
| | | | | | | | https://codereview.chromium.org/107443004/ git-svn-id: http://skia.googlecode.com/svn/trunk@12531 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update valgrind suppressions for new driverGravatar robertphillips@google.com2013-12-05
| | | | | | | | https://codereview.chromium.org/102473003/ git-svn-id: http://skia.googlecode.com/svn/trunk@12510 2bbb7eff-a529-9590-31e7-b0007b416f81
* Address some more valgrind issuesGravatar robertphillips@google.com2013-11-14
| | | | | | | | R=borenet@google.com Review URL: https://codereview.chromium.org/59713010 git-svn-id: http://skia.googlecode.com/svn/trunk@12286 2bbb7eff-a529-9590-31e7-b0007b416f81
* Silence another valgrind leakGravatar robertphillips@google.com2013-11-12
| | | | | | | | https://codereview.chromium.org/68523006/ git-svn-id: http://skia.googlecode.com/svn/trunk@12236 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add another FontConfig suppression to valgrind suppressionsGravatar robertphillips@google.com2013-11-11
| | | | | | | | https://codereview.chromium.org/69403002/ git-svn-id: http://skia.googlecode.com/svn/trunk@12226 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add valgrind suppressions for driver bugsGravatar robertphillips@google.com2013-10-11
| | | | | | | | https://codereview.chromium.org/27019005/ git-svn-id: http://skia.googlecode.com/svn/trunk@11736 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add leak to valgrind.suppGravatar robertphillips@google.com2013-10-10
| | | | | | | | https://codereview.chromium.org/26869002/ git-svn-id: http://skia.googlecode.com/svn/trunk@11700 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update valgrind suppressionsGravatar robertphillips@google.com2013-10-08
https://codereview.chromium.org/26465007/ git-svn-id: http://skia.googlecode.com/svn/trunk@11650 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-18 15:59:37 +0000