aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/valgrind.supp
diff options
context:
space:
mode:
authorGravatar msarett <msarett@google.com>2015-07-14 14:39:59 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-07-14 14:39:59 -0700
commit02b5aa3cacf9a288043029300b988d7b4b26ba5a (patch)
treebe1bb82d56b44032d66429959703f421ff6ab13f /tools/valgrind.supp
parentbe4229b58f00180164c12ddd73bd6fc072147650 (diff)
Fixed valgrind issues with libjpeg-turbo
The fixes are in the updated libjpeg-turbo repository pulled in by DEPS. The fixes are detailed in the linked skia bug. To summarize briefly, we now use calloc() instead of malloc(). BUG=skia:4030 Review URL: https://codereview.chromium.org/1237213004
Diffstat (limited to 'tools/valgrind.supp')
-rw-r--r--tools/valgrind.supp62
1 files changed, 0 insertions, 62 deletions
diff --git a/tools/valgrind.supp b/tools/valgrind.supp
index 2bbf873038..ffb71089f9 100644
--- a/tools/valgrind.supp
+++ b/tools/valgrind.supp
@@ -236,65 +236,3 @@
Memcheck:Addr2
fun:_ZN22GrAAConvexPathRenderer10onDrawPathERK6SkPathRK11SkStrokeRecP12GrDrawTargetb
}
-
-# Valgrind issues caused by tip of tree libjpeg-turbo
-# https://code.google.com/p/skia/issues/detail?id=4030
-# TODO (msarett): Determine if any of these errors relate to jpeg_skip_scanlines() and fix those.
-# Issue 4 looks like it may.
-# Some of these errors may be fixed when we switch to Chromium's version of turbo.
-# If they are not fixed in Chromium's version, they need to be fixed after we switch.
-{
- turbo_issue_1
- Memcheck:Value8
- fun:_itoa_word
- fun:vfprintf
- fun:__vsnprintf_chk
- fun:_ZN8SkString7appendfEPKcz
- fun:_ZN4Task3RunEPS_
- fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
- fun:_ZL12thread_startPv
- fun:start_thread
- fun:clone
-}
-{
- turbo_issue_2
- Memcheck:Cond
- fun:vfprintf
- fun:__vsnprintf_chk
- fun:_ZN8SkString7appendfEPKcz
- fun:_ZN4Task3RunEPS_
- fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
- fun:_ZL12thread_startPv
- fun:start_thread
- fun:clone
-}
-{
- turbo_issue_3
- Memcheck:Cond
- fun:_itoa_word
- fun:vfprintf
- fun:__vsnprintf_chk
- fun:_ZN8SkString7appendfEPKcz
- fun:_ZN4Task3RunEPS_
- fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
- fun:_ZL12thread_startPv
- fun:start_thread
- fun:clone
-}
-{
- turbo_issue_4
- Memcheck:Value8
- fun:ycc_rgb565D_convert
- fun:sep_upsample
- fun:process_data_context_main
- fun:turbo_jpeg_read_scanlines
- fun:turbo_jpeg_skip_scanlines
- fun:_ZN21SkJpegScanlineDecoder15onSkipScanlinesEi
- fun:_ZNK2DM8CodecSrc4drawEP8SkCanvas
- fun:_ZNK2DM10RasterSink4drawERKNS_3SrcEP8SkBitmapP9SkWStreamP8SkString
- fun:_ZN4Task3RunEPS_
- fun:_ZN12_GLOBAL__N_110ThreadPool4LoopEPv
- fun:_ZL12thread_startPv
- fun:start_thread
- fun:clone
-}