diff options
| author |  Mike Klein <mtklein@chromium.org> | 2017-02-21 08:12:09 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-02-21 14:01:19 +0000 |
| commit | 4a2ab86d7618c4b5b31c161322ddfb4f18ab4f81 (patch) | |
| tree | ed5fa7ca5d7d982a2e4cd0c7f67c20287526afd6 /tools/valgrind.supp | |
| parent | 0548a21dd52d093b14d584137ffe526087ba0b45 (diff) | |
Update Valgrind match-leak-kinds for keep-alive thread.
Valgrind has tipped over from seeing the keep-alive thread as possibly
leaked to seeing it as definitely leaked. We can suppress both.
An alternative here is "all" or to just remove the line. For the moment
I think this is best, as we're still excluding indirect leaks this way.
I'd want to think a bit whether it made sense for the keep-alive thread
to indirectly leak anything, so I'd like it to fail if it comes up.
Change-Id: Ib28790a1d84a0a9061fdb6de48569ca8ea51b52a
Reviewed-on: https://skia-review.googlesource.com/8764
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
Diffstat (limited to 'tools/valgrind.supp')
| -rw-r--r-- | tools/valgrind.supp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/valgrind.supp b/tools/valgrind.supp index 601b3a7d0f..d0640fea4a 100644 --- a/tools/valgrind.supp +++ b/tools/valgrind.supp @@ -4,7 +4,7 @@ { nanobench_and_dm_keepalive_thread_leak Memcheck:Leak - match-leak-kinds: possible + match-leak-kinds: possible,definite ... fun:_ZN8SkThreadC1EPFvPvES0_ ... |