From 4a2ab86d7618c4b5b31c161322ddfb4f18ab4f81 Mon Sep 17 00:00:00 2001 From: Mike Klein Date: Tue, 21 Feb 2017 08:12:09 -0500 Subject: Update Valgrind match-leak-kinds for keep-alive thread. Valgrind has tipped over from seeing the keep-alive thread as possibly leaked to seeing it as definitely leaked. We can suppress both. An alternative here is "all" or to just remove the line. For the moment I think this is best, as we're still excluding indirect leaks this way. I'd want to think a bit whether it made sense for the keep-alive thread to indirectly leak anything, so I'd like it to fail if it comes up. Change-Id: Ib28790a1d84a0a9061fdb6de48569ca8ea51b52a Reviewed-on: https://skia-review.googlesource.com/8764 Reviewed-by: Brian Salomon Reviewed-by: Robert Phillips Commit-Queue: Mike Klein --- tools/valgrind.supp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tools/valgrind.supp') diff --git a/tools/valgrind.supp b/tools/valgrind.supp index 601b3a7d0f..d0640fea4a 100644 --- a/tools/valgrind.supp +++ b/tools/valgrind.supp @@ -4,7 +4,7 @@ { nanobench_and_dm_keepalive_thread_leak Memcheck:Leak - match-leak-kinds: possible + match-leak-kinds: possible,definite ... fun:_ZN8SkThreadC1EPFvPvES0_ ... -- cgit v1.2.3