diff options
| author |  mtklein <mtklein@google.com> | 2014-09-03 14:17:48 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-09-03 14:17:48 -0700 |
| commit | 2460bbdfbb1d55ef307c3189c661e65de1a7affb (patch) | |
| tree | 62342a335023875d1482447bea9e29e8a0ba22fb /tools/valgrind.supp | |
| parent | 9c7207b5dc71dc5a96a2eb107d401133333d5b6f (diff) | |
Revert of SkThreadPool ~~> SkTaskGroup (patchset #4 id:60001 of https://codereview.chromium.org/531653002/)
Reason for revert:
Leaks, leaks, leaks.
Original issue's description:
> SkThreadPool ~~> SkTaskGroup
>
> SkTaskGroup is like SkThreadPool except the threads stay in
> one global pool. Each SkTaskGroup itself is tiny (4 bytes)
> and its wait() method applies only to tasks add()ed to that
> instance, not the whole thread pool.
>
> This means we don't need to bring up new thread pools when
> tests themselves want to use multithreading (e.g. pathops,
> quilt). We just create a new SkTaskGroup and wait for that
> to complete. This should be more efficient, and allow us
> to expand where we use threads to really latency sensitive
> places. E.g. we can probably now use these in nanobench
> for CPU .skp rendering.
>
> Now that all threads are sharing the same pool, I think we
> can remove most of the custom mechanism pathops tests use
> to control threading. They'll just ride on the global pool
> with all other tests now.
>
> This (temporarily?) removes the GPU multithreading feature
> from DM, which we don't use.
>
> On my desktop, DM runs a little faster (57s -> 55s) in
> Debug, and a lot faster in Release (36s -> 24s). The bots
> show speedups of similar proportions, cutting more than a
> minute off the N4/Release and Win7/Debug runtimes.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/9c7207b5dc71dc5a96a2eb107d401133333d5b6f
R=caryclark@google.com, bsalomon@google.com, bungeman@google.com, reed@google.com, mtklein@chromium.org
TBR=bsalomon@google.com, bungeman@google.com, caryclark@google.com, mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/533393002
Diffstat (limited to 'tools/valgrind.supp')
| -rw-r--r-- | tools/valgrind.supp | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/tools/valgrind.supp b/tools/valgrind.supp index f0331ed4cb..d96ada04e7 100644 --- a/tools/valgrind.supp +++ b/tools/valgrind.supp @@ -213,12 +213,3 @@ Memcheck:Addr2 fun:_ZN22GrAAConvexPathRenderer10onDrawPathERK6SkPathRK11SkStrokeRecP12GrDrawTargetb } - -{ - sk_task_group_thread_pool_intentionally_leaks_in_Release_mode - Memcheck:Leak - ... - fun:_ZN8SkThreadC1EPFvPvES0_ - ... - fun:_ZN11SkTaskGroup3addEP10SkRunnable -} |