aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/gpu/gl
Commit message (Collapse)AuthorAge
* When wrapping external textures, clamp the MSAA sample count to max.Gravatar senorblanco2015-04-06
| | | | | | | | | | | This is the same clamp we do in onCreateTexture() for Skia-native textures. Without this fix, setting to a count higher than the max in Chrome results in a black screen. BUG=skia: Review URL: https://codereview.chromium.org/1056253003
* GrGLInterface: Add support for NV_framebuffer_mixed_samplesGravatar vbuzinov2015-04-01
| | | | | | | | | Import glCoverageModulation if NV_framebuffer_mixed samples is available BUG=skia:3177 Review URL: https://codereview.chromium.org/993363002
* Housekeeping to rename GrGL compressed texture formats to match GL specsGravatar egdaniel2015-03-27
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1035243002
* Remove unused HWAA flag and uniqueID field from GrDrawTargetCaps.Gravatar egdaniel2015-03-26
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1019303005
* C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}Gravatar mtklein2015-03-25
| | | | | | | | | NOPRESUBMIT=true BUG=skia: DOCS_PREVIEW= https://skia.org/?cl=1037793002 Review URL: https://codereview.chromium.org/1037793002
* Some usability ideas around SkTHash.Gravatar mtklein2015-03-20
| | | | | | | | | | | | | | - By default, use new SkGoodHash to hash keys, which is: * for 4 byte values, use SkChecksum::Mix, * for SkStrings, use SkChecksum::Murmur3 on the data, * for other structs, shallow hash the struct with Murmur3. - Expand SkChecksum::Murmur3 to support non-4-byte-aligned data. - Add const foreach() methods. - Have foreach() take a functor, which allows lambdas. BUG=skia: Review URL: https://codereview.chromium.org/1021033002
* Remove recent changes to use temp fbo to do stencil clears.Gravatar egdaniel2015-03-18
| | | | | | | | | | | | | In order to implement these stencil clears we had to use a work around where we would bind a color buffer renderbuffer to the fbo before clearing the stencil buffer. However this workaround seems to cause the win 7 hd2000 machines to all crash on some memory access issue. For now we will comment on the change and go back to the old world BUG=skia: Review URL: https://codereview.chromium.org/1015223002
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #17 id:320001 ↵Gravatar egdaniel2015-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: Perf regression on win8 hd7700 gpu skps Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef > > Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac > > Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88 > > Committed: https://skia.googlesource.com/skia/+/160f24ce0e8d6dd7ca80b78871e063d4f4609cfb TBR=bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1009563003
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-03-17
| | | | | | | | | | | | | | Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88 Review URL: https://codereview.chromium.org/949263002
* Use sample count for temp renderbuffer when clearing stenciGravatar Brian Salomon2015-03-17
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1016903002
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #16 id:300001 ↵Gravatar bsalomon2015-03-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: locally hit assert. Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef > > Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac > > Committed: https://skia.googlesource.com/skia/+/dc963b9264908f53650c40a97cff414101dd3e88 TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1017803002
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-03-17
| | | | | | | | | | | | Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac Review URL: https://codereview.chromium.org/949263002
* Add stencil-only clear bug workaround back but for all devices.Gravatar bsalomon2015-03-17
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/1010253002
* Disable GL_MULTISAMPLE when it's not being usedGravatar cdalton2015-03-16
| | | | | | | | | | | | Updates Gr to disable GL_MULTISAMPLE when drawing to an aliased render target. This is an important step for NV_framebuffer_mixed_samples, where just because the color buffer isn't multisampled doesn't mean other stages in the graphics pipeline aren't. It also removes the need for the "isLineDraw" workaround that was in GrGLGpu::flushHWAAState. BUG=skia: Review URL: https://codereview.chromium.org/1002013006
* Move GrAutoLocaleSetter to new file and fix issue with null localeGravatar bsalomon2015-03-16
| | | | | | | TBR=egdaniel@google.com NOTREECHECKS=true Review URL: https://codereview.chromium.org/1002623004
* Use C locale for numerics when emitting shaders.Gravatar bsalomon2015-03-16
| | | | | | BUG=skia:3330 Review URL: https://codereview.chromium.org/1012723002
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #12 id:220001 ↵Gravatar bsalomon2015-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: That one needs to be reverted to fix black boxes with GPU raster, and GPU bot failures. BUG=466690 Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef > > Committed: https://skia.googlesource.com/skia/+/6ba6fa15261be591f33cf0e5df7134e4fc6432ac TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1011493002
* Revert of Add terrible workaround to fix stencil clear crash on S3. ↵Gravatar ccameron2015-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1001693003/) Reason for revert: Needs to be reverted in order to cleanly revert https://codereview.chromium.org/949263002 That one needs to be reverted to fix black boxes with GPU raster, and GPU bot failures. BUG=466690 Original issue's description: > Add terrible workaround to fix stencil clear crash on S3. > > BUG=skia:3525 > > Committed: https://skia.googlesource.com/skia/+/084340bb9bbb538baf02a11ac36e29f0d9cdc493 TBR=joshualitt@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3525 Review URL: https://codereview.chromium.org/1005263002
* Creation of GrBatchAtlas and Distancefieldpathrenderer batchGravatar joshualitt2015-03-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/975303005
* Add terrible workaround to fix stencil clear crash on S3.Gravatar bsalomon2015-03-11
| | | | | | BUG=skia:3525 Review URL: https://codereview.chromium.org/1001693003
* Add flag to force gpu trace markers to be used and printed out for debugging.Gravatar egdaniel2015-03-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/976413002
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-03-04
| | | | | | | | | | Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef Review URL: https://codereview.chromium.org/949263002
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #10 id:180001 ↵Gravatar robertphillips2015-03-01
| | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: Experimentally reverting to see if this is the cause of the mac_chromium_rel_ng roll-blocking failures. Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 > > Committed: https://skia.googlesource.com/skia/+/0b70b86a7e9fda52ee7ebc1b9897eeaa09b9abef TBR=egdaniel@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/970613003
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-02-27
| | | | | | | | Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 Review URL: https://codereview.chromium.org/949263002
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #8 id:140001 ↵Gravatar bsalomon2015-02-27
| | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: breaking things Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 > > Committed: https://skia.googlesource.com/skia/+/b2af2d8b83ca4774c3b3bb1e49bc72605faa9589 TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/963973002
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-02-27
| | | | | | Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 Review URL: https://codereview.chromium.org/949263002
* Cleanup in GrPipelineBuilderGravatar bsalomon2015-02-26
| | | | Review URL: https://codereview.chromium.org/956363003
* Revert of Improve tracking of bound FBOs in GrGLGpu. (patchset #6 id:100001 ↵Gravatar bsalomon2015-02-26
| | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/949263002/) Reason for revert: breaking hd2000 windows bots Original issue's description: > Improve tracking of bound FBOs in GrGLGpu. > > Committed: https://skia.googlesource.com/skia/+/d2ad8eb5801e2c8c0fa544a6a776bb46eedde2a0 TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/964543002
* Improve tracking of bound FBOs in GrGLGpu.Gravatar bsalomon2015-02-26
| | | | Review URL: https://codereview.chromium.org/949263002
* Remove EGL header from SkANGLELContext.hGravatar bsalomon2015-02-23
| | | | | | TBR=egdaniel@google.com Review URL: https://codereview.chromium.org/947263002
* Add stencil buffer create tracking to GPU stats.Gravatar bsalomon2015-02-23
| | | | Review URL: https://codereview.chromium.org/949953002
* clear stencil buffer using special purpose FBOGravatar bsalomon2015-02-23
| | | | Review URL: https://codereview.chromium.org/941383003
* Dynamically create stencil buffer when needed.Gravatar bsalomon2015-02-23
| | | | Review URL: https://codereview.chromium.org/938383004
* Use D3D11 backend for ANGLE when available.Gravatar bsalomon2015-02-23
| | | | Review URL: https://codereview.chromium.org/954453002
* Port GrGLCaps over to use SkTHash.Gravatar mtklein2015-02-20
| | | | | | | | | | | | | I've written some new hashtable interfaces that should be easier to use, and I've been trying to roll them out bit by bit, hopefully replacing SkTDynamicHash, SkTMultiMap, SkTHashCache, etc. This turns the cache in GrGLCaps::readPixelsSupported() into an SkTHashMap, mapping the format key to a bool. Functionally, it's the same. BUG=skia: Review URL: https://codereview.chromium.org/948473002
* Round stencil buffers dims up to next pow2 when allowedGravatar bsalomon2015-02-20
| | | | Review URL: https://codereview.chromium.org/937303002
* Recycle stencil buffers across render targets.Gravatar bsalomon2015-02-19
| | | | Review URL: https://codereview.chromium.org/939093002
* Avoid wrong memory access due to double substitution and %%Gravatar kkinnunen2015-02-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the form SkDebugf("%s", arbitraryString) instead of SkDebugf(arbitraryString). Fixes the case where SkString::appendf-ing a string with "%%" and then printing the string with SkDebugf would cause uninitialized read and corrupted debug print. ninja -C out/Debug tools && valgrind --leak-check=full ./out/Debug/render_pictures --config gpu -w q -r ... ... ==7307== Conditional jump or move depends on uninitialised value(s) ==7307== at 0x6908475: __printf_fp (printf_fp.c:1180) ==7307== by 0x6904267: vfprintf (vfprintf.c:1629) ==7307== by 0x6906E53: buffered_vfprintf (vfprintf.c:2313) ==7307== by 0x690188D: vfprintf (vfprintf.c:1316) ==7307== by 0x67E8F5: SkDebugf(char const*, ...) (SkDebug_stdio.cpp:18) ==7307== by 0x7983F1: GrContext::printCacheStats() const (GrTest.cpp:54) ==7307== by 0x408ECF: tool_main(int, char**) (render_pictures_main.cpp:480) ==7307== by 0x40913E: main (render_pictures_main.cpp:511) ==7307== Budget: 2048 items 100663296 bytes Entry Count: current 652 (651 budgeted, 0 wrapped, 297 locked, 638 scratch 32 0.000000ull), high 652 Entry Bytes: current 51087658 (budgeted 49826658, 49 0.000000ull, 1261000 unbudgeted) high 51087658 (observe "ull" instead of "% full") (from mtklein) This CL is not editing public API. TBR=reed@google.com Review URL: https://codereview.chromium.org/943453002
* Use uint16s for texture coordinates when rendering text.Gravatar jvanverth2015-02-18
| | | | | | | | | Allows us to push more vertices into a given vertex buffer, with a slight performance improvement. Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b Review URL: https://codereview.chromium.org/917373002
* Revert of Use uint16s for texture coordinates when rendering text. (patchset ↵Gravatar reed2015-02-17
| | | | | | | | | | | | | | | | | | | | | | | | #5 id:80001 of https://codereview.chromium.org/917373002/) Reason for revert: speculative revert for DEPS failures https://codereview.chromium.org/932973002/ Original issue's description: > Use uint16s for texture coordinates when rendering text. > > Allows us to push more vertices into a given vertex buffer, with > a slight performance improvement. > > Committed: https://skia.googlesource.com/skia/+/059034d252007d0dd86fff5ffdbb53cbcb10d34b TBR=joshualitt@google.com,robertphillips@google.com,bsalomon@google.com,reed@google.com,djsollen@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/920333003
* Use uint16s for texture coordinates when rendering text.Gravatar jvanverth2015-02-17
| | | | | | | Allows us to push more vertices into a given vertex buffer, with a slight performance improvement. Review URL: https://codereview.chromium.org/917373002
* Multi-string shadersGravatar joshualitt2015-02-13
| | | | | | | | BUG=skia: Committed: https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e Review URL: https://codereview.chromium.org/929503002
* Revert of Multi-string shaders (patchset #4 id:60001 of ↵Gravatar joshualitt2015-02-13
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/929503002/) Reason for revert: windows warnings Original issue's description: > Multi-string shaders > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/1c3c2d83364ee228e0751df0e1b9c161c0ba8c1e TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/924973002
* Multi-string shadersGravatar joshualitt2015-02-13
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/929503002
* Split out methods in GrGpuResource::CacheAccess that can be called outside ↵Gravatar bsalomon2015-02-13
| | | | | | of the cache. Review URL: https://codereview.chromium.org/923143002
* Limit clear as draw workaround to Adreno 3xx.Gravatar bsalomon2015-02-13
| | | | | | This causes more problems than it fixes on the Nexus 6. Review URL: https://codereview.chromium.org/917313005
* fix for uniform view matrix being uploaded but not usedGravatar joshualitt2015-02-12
| | | | | | | | As discussed, I'll follow this up by removing localmatrix/uniform view matrix from the base classe BUG=skia: Review URL: https://codereview.chromium.org/920933002
* A simple change to move a bunch of stuff out of Gr*Geometry.hGravatar joshualitt2015-02-12
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/920863002
* Make null GL context use callback to make currentGravatar bsalomon2015-02-11
| | | | Review URL: https://codereview.chromium.org/919783002
* Add GrGLCreateNullInterface.cpp back to gyp, and put contents in namespace.Gravatar bsalomon2015-02-11
| | | | | | TBR=robertphillips@google.com Review URL: https://codereview.chromium.org/899803004