aboutsummaryrefslogtreecommitdiffhomepage
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAge
* Only run recipe simulation tests if infra/ changes.Gravatar mtklein2016-07-27
| | | | | | | | | | This should lessen the need for mortals to have coverage.py, and saves 1.8s (of 3.6s) on my desktop for this non-infra change. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187713002 Review-Url: https://codereview.chromium.org/2187713002
* Move Skia recipes from build repoGravatar borenet2016-07-26
| | | | | | | BUG=skia:5563 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002 Review-Url: https://codereview.chromium.org/2175373002
* Specifying master names with "master." prefix is deprecatedGravatar rmistry2016-07-13
| | | | | | | | NOTRY=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151623002 Review-Url: https://codereview.chromium.org/2151623002
* Do not use the deprecated CQ_EXTRA_TRYBOTSGravatar rmistry2016-07-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2135063003 Review-Url: https://codereview.chromium.org/2135063003
* Fix Gold trybot results URLGravatar rmistry2016-05-20
| | | | | | | BUG=skia:5324 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=1996103002 Review-Url: https://codereview.chromium.org/1996103002
* 10.9 is no moreGravatar mtklein2016-02-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1732353002 Review URL: https://codereview.chromium.org/1732353002
* Port Skia recipe to normal Python scripts, move to Skia repoGravatar borenet2016-02-18
| | | | | | | BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703663002 Review URL: https://codereview.chromium.org/1703663002
* Add link to Gold trybot runs in every uploaded Skia CLGravatar rmistry2015-12-15
| | | | | | | BUG=skia:4433 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1521913005 Review URL: https://codereview.chromium.org/1521913005
* Comments Style: s/skbug.com/bug.skia.org/Gravatar halcanary2015-11-07
| | | | | | DOCS_PREVIEW= https://skia.org/?cl=1432503003 Review URL: https://codereview.chromium.org/1432503003
* Automatically add TSAN bots to the CQ for changes affecting SkAtomics.hGravatar mtklein2015-10-07
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1396523002
* Automatically add extra CQ trybots for predetermined pathsGravatar rmistry2015-10-01
| | | | | | | | | | | | | | If the CL does not contain a "CQ_EXTRA_TRYBOTS=" section then it constructs one from the paths modified in your CL. If you already have an existing "CQ_EXTRA_TRYBOTS=" section in your CL then it parses it, preserves your options, and only adds the builders and masters that were missing. Also ensures no trybots are repeated (i.e. each master trybot combination only shows up once). And I killed the hashtags feature in this CL, nobody was using it. BUG=skia:4364 Review URL: https://codereview.chromium.org/1383743002
* Resolve TODOs in PRESUBMIT.pyGravatar rmistry2015-10-01
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1384453004
* update presubmit to know about include/privateGravatar mtklein2015-07-28
| | | | | | BUG=skia:4126 Review URL: https://codereview.chromium.org/1259953004
* Revert "Move headers used by headers in include/ to include/private."Gravatar Mike Klein2015-07-01
| | | | | | | | This reverts commit 928e16565f3e69cd6661e9ad300ac17e3f33c0c8. BUG=skia: Review URL: https://codereview.chromium.org/1213093004.
* Move headers used by headers in include/ to include/private.Gravatar mtklein2015-07-01
| | | | | | | | | | | Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h used by (public) SkPictureRecorder.h. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a89f55198bdc58f0b6f6196907ab25a6afc1a661 Review URL: https://codereview.chromium.org/1217293004
* Revert "Move headers used by headers in include/ to include/private."Gravatar jvanverth2015-07-01
| | | | | | | | | | | | | This reverts commit a89f55198bdc58f0b6f6196907ab25a6afc1a661. Reason: breaking the roll. TBR=mtklein@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1216033008
* Move headers used by headers in include/ to include/private.Gravatar mtklein2015-07-01
| | | | | | | | | Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h used by (public) SkPictureRecorder.h. BUG=skia: Review URL: https://codereview.chromium.org/1217293004
* Presubmit: add PRESUBMIT=false to non-master branch changesGravatar borenet2015-06-04
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1161973005
* Add presubmit to run `{dm,nanobench}_flags.py test` when changed.Gravatar mtklein2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1129443005
* Bypass owners check for dry run CLs.Gravatar rmistry2015-04-07
| | | | | | | BUG=skia: NOTRY=true Review URL: https://codereview.chromium.org/1068853002
* Find the HASHTAGS file even if you are not at the checkout root.Gravatar rmistry2015-04-01
| | | | | | | | The post upload hook was failing if you were not at the root, this fixes it. NOTRY=true Review URL: https://codereview.chromium.org/1058483002
* Add post upload hook to substitute hashtags for their mapped textGravatar rmistry2015-03-25
| | | | | | | BUG=skia:3586 NOTRY=true Review URL: https://codereview.chromium.org/1004733009
* More file types to check for (C).Gravatar mtklein2015-03-25
| | | | | | | | | | | | - objective C++ (31) - objective C (4) - C (2) - alternate C++ extension (1) - Go (1) BUG=skia: Review URL: https://codereview.chromium.org/1032143002
* Add copyright check to PRESUBMITGravatar borenet2015-03-25
| | | | | | BUG=skia:1724 Review URL: https://codereview.chromium.org/1003363005
* Ignore public API checks if COMMIT=false is in the descriptionGravatar rmistry2015-03-12
| | | | | | | | | BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 Review URL: https://codereview.chromium.org/1006473002
* Revert of Ignore public API checks if COMMIT=false is in the description ↵Gravatar mtklein2015-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #4 id:80001 of https://codereview.chromium.org/1006473002/) Reason for revert: I cannot upload patches: ~/skia (skskp) $ git clu --bypass-hooks ++ git log -1 --pretty=%B + git cl upload -t update Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies Running presubmit upload checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com') Original issue's description: > Ignore public API checks if COMMIT=false is in the description > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 TBR=borenet@google.com,rmistry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1005583002
* Ignore public API checks if COMMIT=false is in the descriptionGravatar rmistry2015-03-12
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1006473002
* Make presubmit check that #if or #ifdef does not come before includes.Gravatar rmistry2015-03-12
| | | | | | BUG=skia:3362 Review URL: https://codereview.chromium.org/998273002
* Automatically add NOTREECHECKS when uploading CLs from non master branchesGravatar rmistry2015-02-26
| | | | | | | | | These changes are possible due to the recently submitted depot_tools change https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks'). BUG=skia: Review URL: https://codereview.chromium.org/963553002
* Automatically add a docs preview link and NOTRY=true when there are only ↵Gravatar rmistry2015-02-26
| | | | | | | | | | | docs changes. These changes are possible due to the recently submitted depot_tools change https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks'). BUG=skia:3474 Review URL: https://codereview.chromium.org/960203002
* PRESUBMIT should only check owners for the top level include directoryGravatar rmistry2014-08-26
| | | | | | | | | BUG=skia:1846 R=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/511503002
* Public API changes are allowed if an owner is TBR'ed.Gravatar rmistry2014-08-26
| | | | | | | | | | | | | | | The following TBR formats are supported: * TBR=reed * TBR=reed@google.com * TBR=xyz,reed * TBR=xyz,reed@google.com BUG=skia:2870 R=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/504843003
* Adding djsollen to list of ownersGravatar rmistry2014-07-18
| | | | | | | | | | | (SkipBuildbotRuns) BUG=skia: R=djsollen@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/397813007
* Use new common tools in Python scriptsGravatar Eric Boren2014-06-25
| | | | | | | BUG=skia:2682 R=rmistry@google.com Review URL: https://codereview.chromium.org/330423004
* Check if the issue owner is in the AUTHORS file in PRESUBMIT.pyGravatar commit-bot@chromium.org2014-02-03
| | | | | | | | | | | | | | BUG=skia:2072 NOTRY=true (SkipBuildbotRuns) R=borenet@google.com, hcm@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/131293005 git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81
* Do not enforce the public API presubmit check for Revert CLs.Gravatar commit-bot@chromium.org2014-01-31
| | | | | | | | | | | | | NOTRY=true BUG=skia:2068 R=borenet@google.com Author: rmistry@google.com Review URL: https://codereview.chromium.org/151573002 git-svn-id: http://skia.googlecode.com/svn/trunk@13270 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding rmistry for emergency reverts.Gravatar commit-bot@chromium.org2014-01-28
| | | | | | | | | | | | | | | (SkipBuildbotRuns) TBR= NOTRY=true NOTREECHECKS=true BUG=skia: Author: rmistry@google.com Review URL: https://codereview.chromium.org/148583005 git-svn-id: http://skia.googlecode.com/svn/trunk@13212 2bbb7eff-a529-9590-31e7-b0007b416f81
* If any change is made to the public API then make sure there is an LGTM from ↵Gravatar rmistry@google.com2013-08-12
| | | | | | | | | | | | | | | | | | | an owner. This feature has been requested by reed@. If no LGTM is found from an owner then the following msg is displayed: ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com') (SkipBuildbotRuns) R=borenet@google.com Review URL: https://codereview.chromium.org/22453004 git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81
* If the tree is closed then print information about contacting the sheriff.Gravatar rmistry@google.com2013-04-12
| | | | | | | | | | | The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git. Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff (SkipBuildbotRuns) Review URL: https://codereview.chromium.org/13932026 git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81
* Display prompt for caution only if it is an interactive shell.Gravatar rmistry@google.com2013-03-29
| | | | | | | | | Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution. (SkipBuildbotRuns) Review URL: https://codereview.chromium.org/13325002 git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81
* Presubmit should check that source files end in atleast one newlineGravatar rmistry@google.com2013-01-25
| | | | | | Review URL: https://codereview.appspot.com/7193063 git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81
* Display a warning prompt in presubmit if the tree status is in 'Caution'.Gravatar rmistry@google.com2013-01-23
| | | | | | | | | | | | | | | | | | | | Example presubmit output: Running presubmit upload checks ... ** Presubmit Warnings ** Tree state is: caution *************** Please use caution in checkins http://skia-tree-status-staging.appspot.com/banner-status?format=json *************** There were presubmit warnings. Are you sure you wish to continue? (y/N): Review URL: https://codereview.appspot.com/7200043 git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81
* Adding CheckChangeHasOnlyOneEol to upload and commit presubmit checksGravatar rmistry@google.com2013-01-17
| | | | | | Review URL: https://codereview.appspot.com/7151043 git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81
* Top-level presubmit script for Skia trunk that checks ↵Gravatar rmistry@google.com2013-01-17
https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed. gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes. Review URL: https://codereview.appspot.com/7138046 git-svn-id: http://skia.googlecode.com/svn/trunk@7242 2bbb7eff-a529-9590-31e7-b0007b416f81
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-24 08:04:32 +0000