aboutsummaryrefslogtreecommitdiffhomepage
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@chromium.org>2015-05-05 10:28:44 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-05-05 10:28:44 -0700
commite4b19c4593da5179b346b66b291e8f4f45af617f (patch)
tree5b979921321b9286ac0b236a6a72efcad2de19f7 /PRESUBMIT.py
parentbf51cfdbd9e41a2e9e2d16dc8d97ac74d9dd84da (diff)
Add presubmit to run `{dm,nanobench}_flags.py test` when changed.
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py12
1 files changed, 12 insertions, 0 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 60439d6eb0..6d429dfa1c 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -140,6 +140,17 @@ def _CopyrightChecks(input_api, output_api, source_file_filter=None):
return results
+def _ToolFlags(input_api, output_api):
+ """Make sure `{dm,nanobench}_flags.py test` passes if modified."""
+ results = []
+ sources = lambda x: ('dm_flags.py' in x.LocalPath() or
+ 'nanobench_flags.py' in x.LocalPath())
+ for f in input_api.AffectedSourceFiles(sources):
+ if 0 != subprocess.call(['python', f.LocalPath(), 'test']):
+ results.append(output_api.PresubmitError('`python %s test` failed' % f))
+ return results
+
+
def _CommonChecks(input_api, output_api):
"""Presubmit checks common to upload and commit."""
results = []
@@ -161,6 +172,7 @@ def _CommonChecks(input_api, output_api):
results.extend(_IfDefChecks(input_api, output_api))
results.extend(_CopyrightChecks(input_api, output_api,
source_file_filter=sources))
+ results.extend(_ToolFlags(input_api, output_api))
return results