From e4b19c4593da5179b346b66b291e8f4f45af617f Mon Sep 17 00:00:00 2001 From: mtklein Date: Tue, 5 May 2015 10:28:44 -0700 Subject: Add presubmit to run `{dm,nanobench}_flags.py test` when changed. BUG=skia: Review URL: https://codereview.chromium.org/1129443005 --- PRESUBMIT.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'PRESUBMIT.py') diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 60439d6eb0..6d429dfa1c 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -140,6 +140,17 @@ def _CopyrightChecks(input_api, output_api, source_file_filter=None): return results +def _ToolFlags(input_api, output_api): + """Make sure `{dm,nanobench}_flags.py test` passes if modified.""" + results = [] + sources = lambda x: ('dm_flags.py' in x.LocalPath() or + 'nanobench_flags.py' in x.LocalPath()) + for f in input_api.AffectedSourceFiles(sources): + if 0 != subprocess.call(['python', f.LocalPath(), 'test']): + results.append(output_api.PresubmitError('`python %s test` failed' % f)) + return results + + def _CommonChecks(input_api, output_api): """Presubmit checks common to upload and commit.""" results = [] @@ -161,6 +172,7 @@ def _CommonChecks(input_api, output_api): results.extend(_IfDefChecks(input_api, output_api)) results.extend(_CopyrightChecks(input_api, output_api, source_file_filter=sources)) + results.extend(_ToolFlags(input_api, output_api)) return results -- cgit v1.2.3