diff options
| author |  jvanverth <jvanverth@google.com> | 2015-07-01 09:45:46 -0700 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2015-07-01 09:45:46 -0700 |
| commit | 4417c7f8bb85aa1eae536cc50c70c0cc87f31171 (patch) | |
| tree | fba28ed61b62ff520d00983e5f8b3d1e0f1ef6d7 /PRESUBMIT.py | |
| parent | a89f55198bdc58f0b6f6196907ab25a6afc1a661 (diff) | |
Revert "Move headers used by headers in include/ to include/private."
This reverts commit a89f55198bdc58f0b6f6196907ab25a6afc1a661.
Reason: breaking the roll.
TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1216033008
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 04ed2e0607..5599c316c3 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -279,10 +279,8 @@ def _CheckLGTMsForPublicAPI(input_api, output_api): affected_file_path = affected_file.LocalPath() file_path, file_ext = os.path.splitext(affected_file_path) # We only care about files that end in .h and are under the top-level - # include dir, but not include/private. - if (file_ext == '.h' and - 'include' == file_path.split(os.path.sep)[0] and - 'private' not in file_path): + # include dir. + if file_ext == '.h' and 'include' == file_path.split(os.path.sep)[0]: requires_owner_check = True if not requires_owner_check: @@ -330,12 +328,8 @@ def _CheckLGTMsForPublicAPI(input_api, output_api): if not lgtm_from_owner: results.append( output_api.PresubmitError( - "If this CL adds to or changes Skia's public API, you need an LGTM " - "from any of %s. If this CL only removes from or doesn't change " - "Skia's public API, please add a short note to your CL saying so " - "and add one of those reviewers on a TBR= line. If you don't know " - "this CL affects Skia's public API, please treat it like it does." - % str(PUBLIC_API_OWNERS))) + 'Since the CL is editing public API, you must have an LGTM from ' + 'one of: %s' % str(PUBLIC_API_OWNERS))) return results |