aboutsummaryrefslogtreecommitdiffhomepage
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAge
* Make CR and trailing whitespace errors.Gravatar Ben Wagner2018-07-11
| | | | | | | | | | | | | The canned CR and trailing whitespace presubmit checks only emit warnings, so no one pays any attention to them and they don't fail the build. All trailing whitespace was removed recently, and it has already returned. This makes these checks actual errors so they will fail the presubmit check on the bots, so that they will actually be seen. Change-Id: I5d774ae45a68b8eb881548d0158c37a8f5fe052e Reviewed-on: https://skia-review.googlesource.com/59164 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Presubmit: blacklist .recipe_depsGravatar Eric Boren2018-06-22
| | | | | | | | Bug: skia: Change-Id: Ibadcc3bf18510e767609374641859f505e56a21c Reviewed-on: https://skia-review.googlesource.com/137195 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Fix pylint check in presubmitGravatar Eric Boren2018-06-22
| | | | | | | | | | | | | | | | | | | This fixes the unexpected behavior where we only run pylint over the affected Python files *unless* there are affected Python files which we have explicitly blacklisted, in which case we run pylint over ALL Python files in every subdirectory of the Skia checkout, including repos in DEPS. - Added buildtools and common to the blacklist. - Changed to run pylint over all Python files in Skia, like presubmit_support expects. - Fix existing pylint problems. Bug: skia: Change-Id: Ife1321f5ae5eaff2a28cc14c99a82a0716c12677 Reviewed-on: https://skia-review.googlesource.com/137126 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "Update docs preview URL in presubmit"Gravatar Joe Gregorio2018-05-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5c646cf10fd9f4db788d3993ea73093649306e80. Reason for revert: I figured out how to make a preview in seconds, as opposed to the minute that it used to be, so a special server for previews isn't needed. Original change's description: > Update docs preview URL in presubmit > > NoTry: true > Bug: skia: > Change-Id: Id5b374f707ac44770a5142f104202d6509410767 > Reviewed-on: https://skia-review.googlesource.com/129505 > Reviewed-by: Joe Gregorio <jcgregorio@google.com> > Commit-Queue: Ravi Mistry <rmistry@google.com> TBR=rmistry@google.com,jcgregorio@google.com Change-Id: I1bbf557729ad4124e93c15f529c7369f68397892 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/129447 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Joe Gregorio <jcgregorio@google.com>
* Update docs preview URL in presubmitGravatar Ravi Mistry2018-05-22
| | | | | | | | | NoTry: true Bug: skia: Change-Id: Id5b374f707ac44770a5142f104202d6509410767 Reviewed-on: https://skia-review.googlesource.com/129505 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Skip post upload hooks for new service accountsGravatar Ravi Mistry2018-05-03
| | | | | | | | | NoTry: true Bug: skia:7899 Change-Id: Id56fe8e0a52c76fed8a45ff4d12c0ee27a7215c8 Reviewed-on: https://skia-review.googlesource.com/125680 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix AUTHORS check (take two)Gravatar Ben Wagner2018-04-26
| | | | | | | | | | | | Fixes a bug in https://skia.googlesource.com/skia/+/47ed6f10ef1d6c29512f95e88a7e51456c4d8f87%5E%21/#F0 Bug: skia:7833, skia:7050 Change-Id: I6441a08b926c84b918d1285b33c3784d4732f904 Reviewed-on: https://skia-review.googlesource.com/124161 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* [infra] Fix AUTHORS checkGravatar Eric Boren2018-04-26
| | | | | | | | | | | It's looking for "google.com" but skia-swarming-bots doesn't have that prefix. Bug: skia:7833, skia:7050 Change-Id: I851453a20f46cd62772b9301226a315a6076ff89 Reviewed-on: https://skia-review.googlesource.com/123980 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* AUTHORS check: Allow service accounts from skia-swarming-botsGravatar Eric Boren2018-04-26
| | | | | | | | Bug: skia:7833, skia:7050 Change-Id: Id5b3fdd1b0a4ae50fce7a5d1212c744a85274012 Reviewed-on: https://skia-review.googlesource.com/123936 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Presubmit that modified json files are valid json.Gravatar Ben Wagner2018-02-12
| | | | | | | | | | | This prevents adding invalid site METADATA files which skia.org will silently ignore. Change-Id: I8dfc3a74ddb52b0e0ca5146717e6132d7ee867b0 Reviewed-on: https://skia-review.googlesource.com/106204 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Skip AUTHORS check for Skia service accountsGravatar Eric Boren2018-01-02
| | | | | | | | Bug: skia: Change-Id: Id9f3b6d0bc22993f5cfc9019354c9299441db05f Reviewed-on: https://skia-review.googlesource.com/90261 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* PostUploadHook needs to return somethingGravatar Ravi Mistry2017-12-07
| | | | | | | | | NoTry: true Bug: skia: Change-Id: I46bf81f2221e5d8e50fdde7fb9a20bf53c760ac2 Reviewed-on: https://skia-review.googlesource.com/82121 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Skip PostUploadHooks for all auto commit botsGravatar Ravi Mistry2017-12-07
| | | | | | | | | | NoTry: true Bug: skia:7310 Change-Id: Ib78fadf20ac0c0c78775ba15dc7a7e20d4ef1b0b Reviewed-on: https://skia-review.googlesource.com/81803 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Do not skip trybots for uploads by update-docsGravatar Ravi Mistry2017-12-07
| | | | | | | | | | | This is a safety check to make sure the bot does not automatically upload and commit anything that breaks things NoTry: true Bug: skia:7310 Change-Id: I2fd72a38fa510409465be0b07af65d57a4217ec9 Reviewed-on: https://skia-review.googlesource.com/81801 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Add in test_filter to build configurationGravatar Kevin Lubick2017-10-16
| | | | | | | | | | | | | The first "sharding" technique we will try is just by test config (e.g. 8888, gles, etc). Thus, for backwards compatibility, the default "shard" is All, as in all configs Bug: skia: NOTRY=true Change-Id: Ia02362477a5d97f8f74d688b5f0c4f45fc129375 Reviewed-on: https://skia-review.googlesource.com/59563 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Remove trailing whitespace.Gravatar Ben Wagner2017-10-09
| | | | | | | | | | | Also adds a presubmit to prevent adding trailing whitespace to source code in the future. Change-Id: I41a4df81487f6f00aa19b188f0cac6a3377efde6 Reviewed-on: https://skia-review.googlesource.com/57380 Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Remove references to Rietveld from skia's presubmitGravatar Aaron Gable2017-10-09
| | | | | | | | | R=rmistry@chromium.org Change-Id: I75c171b9fc9843b5289c759e85b32e51a126fe9b Reviewed-on: https://skia-review.googlesource.com/57302 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Remove carriage returns.Gravatar Ben Wagner2017-10-09
| | | | | | | | | Also add a presubmit so they don't get added to source code. Change-Id: I6a85c6a934b1068a63646a0dcc0d3a08baa96ced Reviewed-on: https://skia-review.googlesource.com/57110 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Switch many jobs to Clang.Gravatar Ben Wagner2017-10-03
| | | | | | | | No-Try: true Change-Id: Ie255d46ff50d13d25d045791c1c3066f06ab9243 Reviewed-on: https://skia-review.googlesource.com/53601 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Fix job name in PRESUBMIT.py.Gravatar Ben Wagner2017-09-28
| | | | | | | | | | Job was removed in https://skia-review.googlesource.com/c/skia/+/46306 No-Try: true Change-Id: I1c6e1a25c7395c27401811cdca653ee49d5e64e6 Reviewed-on: https://skia-review.googlesource.com/52762 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Manually roll recipe DEPSGravatar Eric Boren2017-09-27
| | | | | | | | Bug: skia: Change-Id: I55641aa4bef5a7ac863e3aae3d2902ef408f0384 Reviewed-on: https://skia-review.googlesource.com/52121 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Fix behavior of automatically adding 'Cq-Include-Trybots' in presubmitGravatar Ravi Mistry2017-09-12
| | | | | | | | | NoTry: true Bug: skia:7041 Change-Id: I4660db5e9526b29e2135bf4d5f0d134f1f9a5dce Reviewed-on: https://skia-review.googlesource.com/45880 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Add checks for 'DO NOT''SUBMIT' in description and file contentGravatar Ravi Mistry2017-09-12
| | | | | | | | | NoTry: true Bug: skia: Change-Id: I5ce8c40a7deae690b04e7fbe4ac22fa63888ffc7 Reviewed-on: https://skia-review.googlesource.com/45882 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Update CQ extra trybots after switch to DebianGravatar Eric Boren2017-06-29
| | | | | | | | Bug: skia: Change-Id: I6611638097b473d719106c239012b5382d962941 Reviewed-on: https://skia-review.googlesource.com/21266 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Use Gerrit style format for footers in PresubmitGravatar Ravi Mistry2017-05-23
| | | | | | | | | | | This also fixes a bug where CQ keywords were added multiple times because it was looking for them in the wrong place (new_description_lines instead of the footers). Bug: skia:6667 Change-Id: I91232297343145884b3fe7c2e923373679cf029e Reviewed-on: https://skia-review.googlesource.com/17704 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Separate lines added via post upload from original descriptionGravatar Ravi Mistry2017-05-08
| | | | | | | | | | BUG=skia:6598 NOTRY=true Change-Id: I23fa415788e91da01d33ab3ab912aa420636574c Reviewed-on: https://skia-review.googlesource.com/15869 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Revert "Presubmit: ensure empty line between CL title and description"Gravatar Ravi Mistry2017-05-08
| | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 9518830650a45446756d7b621fc87e7a8ff52476. Reason for revert: <INSERT REASONING HERE> Original change's description: > Presubmit: ensure empty line between CL title and description > > Bug: skia: > Change-Id: If1b2d655e9be4b960f76d2d17ce1cf1126f7b2d4 > Reviewed-on: https://skia-review.googlesource.com/15624 > Reviewed-by: Eric Boren <borenet@google.com> > Commit-Queue: Eric Boren <borenet@google.com> > TBR=borenet@google.com,rmistry@google.com NOTRY=true # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I311ee790f152dbb8325214650838839f6821c995 Reviewed-on: https://skia-review.googlesource.com/15862 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Presubmit: ensure empty line between CL title and descriptionGravatar Eric Boren2017-05-05
| | | | | | | | Bug: skia: Change-Id: If1b2d655e9be4b960f76d2d17ce1cf1126f7b2d4 Reviewed-on: https://skia-review.googlesource.com/15624 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Change PRESUBMIT.py to use [Get|Update]DescriptionLinesGravatar Eric Boren2017-04-05
| | | | | | | | | This should fix the "git cl upload" failures on the recipe roller. Change-Id: I1c433a5a6dc7f52034bef8b2178b3041b8f4661e Reviewed-on: https://skia-review.googlesource.com/11020 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Clean up more references to GYP.Gravatar Mike Klein2017-02-06
| | | | | | | | | | Delete files only used by GYP, and files that used GYP. Neither can possibly be actively used. Beyond that, just a couple doc tweaks. Change-Id: I0220d7226e7bb9ed7c54a7d8f2906a718313c521 Reviewed-on: https://skia-review.googlesource.com/8062 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Hal Canary <halcanary@google.com>
* Add hcm@ to public API ownersGravatar Ravi Mistry2017-01-19
| | | | | | | | | | BUG=skia: NOTRY=true Change-Id: I4d54591db0d50ceca02a87868fd125309bd4531e Reviewed-on: https://skia-review.googlesource.com/7275 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Mike Reed <reed@google.com>
* Do not use post upload hooks for 'GOLD_TRYBOT_URL'Gravatar Ravi Mistry2016-11-23
| | | | | | | | | | | | | That information will be provided via a plugin soon. # This code is not exercised by trybots. NOTRY=true BUG=skia:6000 Change-Id: I6ea60783c0581e32317a781e4349e95b38b71da0 Reviewed-on: https://skia-review.googlesource.com/5207 Commit-Queue: Ravi Mistry <rmistry@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [nobuildbot] Migrate all Linux GCE botsGravatar Eric Boren2016-11-23
| | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4994 Change-Id: Ib63f36b3803117d5357c8e70c572653afd151abe Reviewed-on: https://skia-review.googlesource.com/4994 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Split SkSL and utils apart again into .gni files.Gravatar Mike Klein2016-10-26
| | | | | | | | | | | | | Also extend GN format presubmit check to .gni files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3976 Change-Id: I292f3136437101e3e2c3271e260536ab7a24b192 Reviewed-on: https://skia-review.googlesource.com/3976 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add infra_tests.py, recipe, buildbotless botGravatar borenet2016-10-14
| | | | | | | | | Have the presubmit (upload) run infra_tests.py if anything in infra/ changed. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2415193002 Review-Url: https://codereview.chromium.org/2415193002
* Fix GN formatting presubmit on Windows.Gravatar Mike Klein2016-10-11
| | | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3182 Change-Id: I6e19b18d6851516357f71930e406b9fb324ea81f Reviewed-on: https://skia-review.googlesource.com/3182 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com>
* Fix public API msg in PRESUBMIT.pyGravatar Ravi Mistry2016-10-05
| | | | | | | | | | | BUG=skia:5825 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2989 Change-Id: Ia074ab00ccd1500bee10a5b313636581e8265461 Reviewed-on: https://skia-review.googlesource.com/2989 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* PRESUBMIT.py improvementsGravatar Ravi Mistry2016-10-05
| | | | | | | | | | | | | | * Updated code to check for owners in reviewers for Gerrit issues instead for in the TBR= line. * The previous TBR parsing code was not accounting for adding comments. Eg: "TBR=rmistry (Testing only)". BUG=skia:5825 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2981 Change-Id: I910a3ae71a9f57c14f80c0b0404041cbe451a77c Reviewed-on: https://skia-review.googlesource.com/2981 Reviewed-by: Joe Gregorio <jcgregorio@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Add --test to gen_tasks.go, add presubmit checkGravatar borenet2016-10-04
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2392083002 Review-Url: https://codereview.chromium.org/2392083002
* To prep for removing CMake bots, take them off the CQ and presubmit.Gravatar mtklein2016-09-19
| | | | | | | | | | | | | | | | | | GN is now far more capable than our CMake builds. Time to officially end that experiment. Reminder how this lands: 1) this CL 2) remove the bots from the masters 3) remove the CMake recipe files 4) remove the CMake files I'm willing to wait on 4) until we can do GN -> CMake generation, but I don't want the bots to hold us back. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350073002 Review-Url: https://codereview.chromium.org/2350073002
* Fix PostUploadHook for Gerrit issuesGravatar rmistry2016-09-01
| | | | | | | | | | | A gerrit change must contain the "Change-Id" at the end. This CL strips out the changeId from the description and adds it back in at the end. BUG=skia:5676 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2299303002 NOTRY=true Review-Url: https://codereview.chromium.org/2299303002
* Enable Gerrit support in Skia's PostUploadHookGravatar rmistry2016-09-01
| | | | | | | | BUG=skia:5676 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2299203002 NOTRY=true Review-Url: https://codereview.chromium.org/2299203002
* Use methods from depot_tool's Changelist object instead of Rietveld RPCGravatar rmistry2016-09-01
| | | | | | | | | | This will make support for both Gerrit and Rietveld easier. BUG=skia:5676 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307593002 NOTRY=true Review-Url: https://codereview.chromium.org/2307593002
* Fix up presubmit for SAN GCC->Clang fix.Gravatar mtklein2016-08-31
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302553002 Review-Url: https://codereview.chromium.org/2302553002
* Add Gerrit API support to Skia's PRESUBMIT.pyGravatar rmistry2016-08-29
| | | | | | | | | Also skip post upload hooks for Gerrit. BUG=skia:5674 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2281123002 Review-Url: https://codereview.chromium.org/2281123002
* Roll GN: gn format is --in-place by defaultGravatar mtklein2016-08-10
| | | | | | | | | As usual, might as well roll, and this new behavior is a small convenience. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231833002 Review-Url: https://codereview.chromium.org/2231833002
* Require gn format in presubmitGravatar mtklein2016-08-03
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203283003 Review-Url: https://codereview.chromium.org/2203283003
* Only run recipe simulation tests if infra/ changes.Gravatar mtklein2016-07-27
| | | | | | | | | | This should lessen the need for mortals to have coverage.py, and saves 1.8s (of 3.6s) on my desktop for this non-infra change. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2187713002 Review-Url: https://codereview.chromium.org/2187713002
* Move Skia recipes from build repoGravatar borenet2016-07-26
| | | | | | | BUG=skia:5563 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2175373002 Review-Url: https://codereview.chromium.org/2175373002
* Specifying master names with "master." prefix is deprecatedGravatar rmistry2016-07-13
| | | | | | | | NOTRY=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2151623002 Review-Url: https://codereview.chromium.org/2151623002
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-03 11:36:07 +0000