diff options
| author |  Ravi Mistry <rmistry@google.com> | 2017-12-07 09:23:56 -0500 |
|---|---|---|
| committer |  Skia Commit-Bot <skia-commit-bot@chromium.org> | 2017-12-07 14:29:20 +0000 |
| commit | 37cc2253ffe71ca4c22cd738113b94c871f016f5 (patch) | |
| tree | 96a3e5c8911bfc181efd8daf099ee4c085c1faa6 /PRESUBMIT.py | |
| parent | ee3123c1cc35a656a8c66657e6d124d6f669d3bc (diff) | |
Do not skip trybots for uploads by update-docs
This is a safety check to make sure the bot does not automatically upload and commit anything that breaks things
NoTry: true
Bug: skia:7310
Change-Id: I2fd72a38fa510409465be0b07af65d57a4217ec9
Reviewed-on: https://skia-review.googlesource.com/81801
Reviewed-by: Ravi Mistry <rmistry@google.com>
Commit-Queue: Ravi Mistry <rmistry@google.com>
Diffstat (limited to 'PRESUBMIT.py')
| -rw-r--r-- | PRESUBMIT.py | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 2449c94d96..277a956e42 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -470,8 +470,11 @@ def PostUploadHook(cl, change, output_api): new_description_lines = list(original_description_lines) # If the change includes only doc changes then add No-Try: true in the - # CL's description if it does not exist yet. - if all_docs_changes and not _FooterExists(footers, 'No-Try', 'true'): + # CL's description if it does not exist yet. Do this for all users except + # update-docs@skia.org (see skbug.com/7310). + if (cl.GetIssueOwner() != "update-docs@skia.org" and + all_docs_changes and + not _FooterExists(footers, 'No-Try', 'true')): new_description_lines.append('No-Try: true') results.append( output_api.PresubmitNotifyResult( |