From 37cc2253ffe71ca4c22cd738113b94c871f016f5 Mon Sep 17 00:00:00 2001 From: Ravi Mistry Date: Thu, 7 Dec 2017 09:23:56 -0500 Subject: Do not skip trybots for uploads by update-docs This is a safety check to make sure the bot does not automatically upload and commit anything that breaks things NoTry: true Bug: skia:7310 Change-Id: I2fd72a38fa510409465be0b07af65d57a4217ec9 Reviewed-on: https://skia-review.googlesource.com/81801 Reviewed-by: Ravi Mistry Commit-Queue: Ravi Mistry --- PRESUBMIT.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'PRESUBMIT.py') diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 2449c94d96..277a956e42 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -470,8 +470,11 @@ def PostUploadHook(cl, change, output_api): new_description_lines = list(original_description_lines) # If the change includes only doc changes then add No-Try: true in the - # CL's description if it does not exist yet. - if all_docs_changes and not _FooterExists(footers, 'No-Try', 'true'): + # CL's description if it does not exist yet. Do this for all users except + # update-docs@skia.org (see skbug.com/7310). + if (cl.GetIssueOwner() != "update-docs@skia.org" and + all_docs_changes and + not _FooterExists(footers, 'No-Try', 'true')): new_description_lines.append('No-Try: true') results.append( output_api.PresubmitNotifyResult( -- cgit v1.2.3