diff options
author | Ravi Mistry <rmistry@google.com> | 2018-05-03 08:02:03 -0400 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-05-03 12:10:11 +0000 |
commit | 4722a4135911c86abd3960014de8e476be90c97d (patch) | |
tree | 092ba93bfd5b226da18e6ca817354d2b088e118a /PRESUBMIT.py | |
parent | 525f9a94eef14b73d8cc131bfdddceac5de65d16 (diff) |
Skip post upload hooks for new service accounts
NoTry: true
Bug: skia:7899
Change-Id: Id56fe8e0a52c76fed8a45ff4d12c0ee27a7215c8
Reviewed-on: https://skia-review.googlesource.com/125680
Commit-Queue: Ravi Mistry <rmistry@google.com>
Reviewed-by: Eric Boren <borenet@google.com>
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r-- | PRESUBMIT.py | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 4149f86e09..f9747fa1f6 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -35,11 +35,6 @@ PUBLIC_API_OWNERS = ( 'hcm@google.com', ) -AUTO_COMMIT_BOTS = ( - 'update-docs@skia.org', - 'update-skps@skia.org' -) - AUTHORS_FILE_NAME = 'AUTHORS' DOCS_PREVIEW_URL = 'https://skia.org/?cl=' @@ -505,11 +500,12 @@ def PostUploadHook(cl, change, output_api): issue = cl.issue if issue: - # Skip PostUploadHooks for all auto-commit bots. New patchsets (caused - # due to PostUploadHooks) invalidates the CQ+2 vote from the - # "--use-commit-queue" flag to "git cl upload". - if cl.GetIssueOwner() in AUTO_COMMIT_BOTS: - return results + # Skip PostUploadHooks for all auto-commit service account bots. New + # patchsets (caused due to PostUploadHooks) invalidates the CQ+2 vote from + # the "--use-commit-queue" flag to "git cl upload". + for suffix in SERVICE_ACCOUNT_SUFFIX: + if cl.GetIssueOwner().endswith(suffix): + return results original_description_lines, footers = cl.GetDescriptionFooters() new_description_lines = list(original_description_lines) |