aboutsummaryrefslogtreecommitdiffhomepage
path: root/PRESUBMIT.py
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@google.com>2015-03-12 09:33:46 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-03-12 09:33:46 -0700
commita10ea431cf9e283696bab1cac1457d4fa92f9c06 (patch)
tree4eb0fb4979869525deb73a7fa37f79e54a661461 /PRESUBMIT.py
parentd1783aefcc0da86c5ff1d124c54704252d817621 (diff)
Revert of Ignore public API checks if COMMIT=false is in the description (patchset #4 id:80001 of https://codereview.chromium.org/1006473002/)
Reason for revert: I cannot upload patches: ~/skia (skskp) $ git clu --bypass-hooks ++ git log -1 --pretty=%B + git cl upload -t update Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies Running presubmit upload checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com') Original issue's description: > Ignore public API checks if COMMIT=false is in the description > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 TBR=borenet@google.com,rmistry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1005583002
Diffstat (limited to 'PRESUBMIT.py')
-rw-r--r--PRESUBMIT.py7
1 files changed, 0 insertions, 7 deletions
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index b5397042b2..d62249a605 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -143,8 +143,6 @@ def CheckChangeOnUpload(input_api, output_api):
"""
results = []
results.extend(_CommonChecks(input_api, output_api))
- # TODO(rmistry): Remove the below it is only for testing!!!
- results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
return results
@@ -256,11 +254,6 @@ def _CheckLGTMsForPublicAPI(input_api, output_api):
# It is a revert CL, ignore the public api owners check.
return results
- if re.search(r'^COMMIT=false$', issue_properties['description'], re.M):
- # Ignore public api owners check for COMMIT=false CLs since they are not
- # going to be committed.
- return results
-
match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M)
if match:
tbr_entries = match.group(1).strip().split(',')