From a10ea431cf9e283696bab1cac1457d4fa92f9c06 Mon Sep 17 00:00:00 2001 From: mtklein Date: Thu, 12 Mar 2015 09:33:46 -0700 Subject: Revert of Ignore public API checks if COMMIT=false is in the description (patchset #4 id:80001 of https://codereview.chromium.org/1006473002/) Reason for revert: I cannot upload patches: ~/skia (skskp) $ git clu --bypass-hooks ++ git log -1 --pretty=%B + git cl upload -t update Using 50% similarity for rename/copy detection. Override with --similarity. Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies Running presubmit upload checks ... ** Presubmit ERRORS ** Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com') Original issue's description: > Ignore public API checks if COMMIT=false is in the description > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 TBR=borenet@google.com,rmistry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1005583002 --- PRESUBMIT.py | 7 ------- 1 file changed, 7 deletions(-) (limited to 'PRESUBMIT.py') diff --git a/PRESUBMIT.py b/PRESUBMIT.py index b5397042b2..d62249a605 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -143,8 +143,6 @@ def CheckChangeOnUpload(input_api, output_api): """ results = [] results.extend(_CommonChecks(input_api, output_api)) - # TODO(rmistry): Remove the below it is only for testing!!! - results.extend(_CheckLGTMsForPublicAPI(input_api, output_api)) return results @@ -256,11 +254,6 @@ def _CheckLGTMsForPublicAPI(input_api, output_api): # It is a revert CL, ignore the public api owners check. return results - if re.search(r'^COMMIT=false$', issue_properties['description'], re.M): - # Ignore public api owners check for COMMIT=false CLs since they are not - # going to be committed. - return results - match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M) if match: tbr_entries = match.group(1).strip().split(',') -- cgit v1.2.3