| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1129443005
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/1068853002
|
|
|
|
|
|
|
|
| |
The post upload hook was failing if you were not at the root, this fixes it.
NOTRY=true
Review URL: https://codereview.chromium.org/1058483002
|
|
|
|
|
|
|
| |
BUG=skia:3586
NOTRY=true
Review URL: https://codereview.chromium.org/1004733009
|
|
|
|
|
|
|
|
|
|
|
|
| |
- objective C++ (31)
- objective C (4)
- C (2)
- alternate C++ extension (1)
- Go (1)
BUG=skia:
Review URL: https://codereview.chromium.org/1032143002
|
|
|
|
|
|
| |
BUG=skia:1724
Review URL: https://codereview.chromium.org/1003363005
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=true
Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621
Review URL: https://codereview.chromium.org/1006473002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #4 id:80001 of https://codereview.chromium.org/1006473002/)
Reason for revert:
I cannot upload patches:
~/skia (skskp) $ git clu --bypass-hooks
++ git log -1 --pretty=%B
+ git cl upload -t update
Using 50% similarity for rename/copy detection. Override with --similarity.
Loaded authentication cookies from /Users/mtklein/.codereview_upload_cookies
Running presubmit upload checks ...
** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')
Original issue's description:
> Ignore public API checks if COMMIT=false is in the description
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621
TBR=borenet@google.com,rmistry@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1005583002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1006473002
|
|
|
|
|
|
| |
BUG=skia:3362
Review URL: https://codereview.chromium.org/998273002
|
|
|
|
|
|
|
|
|
| |
These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').
BUG=skia:
Review URL: https://codereview.chromium.org/963553002
|
|
|
|
|
|
|
|
|
|
|
| |
docs changes.
These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').
BUG=skia:3474
Review URL: https://codereview.chromium.org/960203002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:1846
R=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/511503002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following TBR formats are supported:
* TBR=reed
* TBR=reed@google.com
* TBR=xyz,reed
* TBR=xyz,reed@google.com
BUG=skia:2870
R=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/504843003
|
|
|
|
|
|
|
|
|
|
|
| |
(SkipBuildbotRuns)
BUG=skia:
R=djsollen@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/397813007
|
|
|
|
|
|
|
| |
BUG=skia:2682
R=rmistry@google.com
Review URL: https://codereview.chromium.org/330423004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:2072
NOTRY=true
(SkipBuildbotRuns)
R=borenet@google.com, hcm@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/131293005
git-svn-id: http://skia.googlecode.com/svn/trunk@13277 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=skia:2068
R=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/151573002
git-svn-id: http://skia.googlecode.com/svn/trunk@13270 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(SkipBuildbotRuns)
TBR=
NOTRY=true
NOTREECHECKS=true
BUG=skia:
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/148583005
git-svn-id: http://skia.googlecode.com/svn/trunk@13212 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
an owner.
This feature has been requested by reed@.
If no LGTM is found from an owner then the following msg is displayed:
** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/22453004
git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation for this CL is because it is not very obvious on how to submit when tree is closed in git.
Also added a section 'How to submit when tree is closed' in https://sites.google.com/site/skiadocs/developer-documentation/tree-sheriff
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13932026
git-svn-id: http://skia.googlecode.com/svn/trunk@8666 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
|
|
|
| |
Created to fix https://code.google.com/p/skia/issues/detail?id=1197 : Skia Commit Queue quits if the tree is in Caution.
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/13325002
git-svn-id: http://skia.googlecode.com/svn/trunk@8446 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
| |
Review URL: https://codereview.appspot.com/7193063
git-svn-id: http://skia.googlecode.com/svn/trunk@7399 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Example presubmit output:
Running presubmit upload checks ...
** Presubmit Warnings **
Tree state is: caution
***************
Please use caution in checkins
http://skia-tree-status-staging.appspot.com/banner-status?format=json
***************
There were presubmit warnings. Are you sure you wish to continue? (y/N):
Review URL: https://codereview.appspot.com/7200043
git-svn-id: http://skia.googlecode.com/svn/trunk@7337 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
|
|
|
|
| |
Review URL: https://codereview.appspot.com/7151043
git-svn-id: http://skia.googlecode.com/svn/trunk@7247 2bbb7eff-a529-9590-31e7-b0007b416f81
|
|
https://skia-tree-status.appspot.com/banner-status?format=json before a CL is committed.
gcl and git-cl will check for and run the presubmit script before you upload and/or commit your changes.
Review URL: https://codereview.appspot.com/7138046
git-svn-id: http://skia.googlecode.com/svn/trunk@7242 2bbb7eff-a529-9590-31e7-b0007b416f81
|