diff options
author | Herb Derby <herb@google.com> | 2018-06-06 17:45:53 +0000 |
---|---|---|
committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | 2018-06-06 17:46:05 +0000 |
commit | 41f4f31cd7dadd1123600c38faa8fef6bd7fb29c (patch) | |
tree | 1e2d604cd95be419d363e9b56aa5beaf3eb8818e /src/core/SkDraw.cpp | |
parent | 2d7678d61fb68a2c9060a9fad8ebabf4e0053576 (diff) |
Reland "Have draw(Text|PosText|PosTextH) use a single entry on the device"
This reverts commit 74b390d6b136a60f1df15ac5ecd19bd8ad5a394b.
Reason for revert: reverting to add patch for valgrind
Original change's description:
> Revert "Have draw(Text|PosText|PosTextH) use a single entry on the device"
>
> This reverts commit 4225b3220ef4bf50f0d9403f812ea94d50c4ee59.
>
> Reason for revert: made valgrind unhappy.
>
> Original change's description:
> > Have draw(Text|PosText|PosTextH) use a single entry on the device
> >
> > Handle the positioning of drawText at the canvas layer. Simplify
> > the code by removing similar implementations.
> >
> > Change-Id: I8b711783435072f560e29fca1dd934fa2e345ed2
> > Reviewed-on: https://skia-review.googlesource.com/127131
> > Reviewed-by: Ben Wagner <bungeman@google.com>
> > Commit-Queue: Herb Derby <herb@google.com>
>
> TBR=jvanverth@google.com,bungeman@google.com,herb@google.com
>
> Change-Id: I65c9d30ae6ecb1f87e8660e56d8f8ce5daab7551
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/132403
> Reviewed-by: Hal Canary <halcanary@google.com>
> Commit-Queue: Hal Canary <halcanary@google.com>
TBR=jvanverth@google.com,halcanary@google.com,bungeman@google.com,herb@google.com
Change-Id: I9bbb73aac447b51eb8215ac42331759fa4c9fa45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/132580
Reviewed-by: Herb Derby <herb@google.com>
Commit-Queue: Herb Derby <herb@google.com>
Diffstat (limited to 'src/core/SkDraw.cpp')
-rw-r--r-- | src/core/SkDraw.cpp | 31 |
1 files changed, 0 insertions, 31 deletions
diff --git a/src/core/SkDraw.cpp b/src/core/SkDraw.cpp index b7150f85f8..e975ea2a4b 100644 --- a/src/core/SkDraw.cpp +++ b/src/core/SkDraw.cpp @@ -1537,37 +1537,6 @@ SkScalerContextFlags SkDraw::scalerContextFlags() const { return flags; } -void SkDraw::drawText(const char text[], size_t byteLength, SkScalar x, SkScalar y, - const SkPaint& paint, const SkSurfaceProps* props) const { - SkASSERT(byteLength == 0 || text != nullptr); - - SkDEBUGCODE(this->validate();) - - // nothing to draw - if (text == nullptr || byteLength == 0 || fRC->isEmpty()) { - return; - } - - // SkScalarRec doesn't currently have a way of representing hairline stroke and - // will fill if its frame-width is 0. - if (ShouldDrawTextAsPaths(paint, *fMatrix)) { - this->drawText_asPaths(text, byteLength, x, y, paint); - return; - } - - auto cache = SkStrikeCache::FindOrCreateStrikeExclusive( - paint, props, this->scalerContextFlags(), fMatrix); - - // The Blitter Choose needs to be live while using the blitter below. - SkAutoBlitterChoose blitterChooser(*this, nullptr, paint); - SkAAClipBlitterWrapper wrapper(*fRC, blitterChooser.get()); - DrawOneGlyph drawOneGlyph(*this, paint, cache.get(), wrapper.getBlitter()); - - SkFindAndPlaceGlyph::ProcessText( - paint.getTextEncoding(), text, byteLength, - {x, y}, *fMatrix, paint.getTextAlign(), cache.get(), drawOneGlyph); -} - ////////////////////////////////////////////////////////////////////////////// void SkDraw::drawPosText_asPaths(const char text[], size_t byteLength, const SkScalar pos[], |