aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Merge pull request #18 from bbarenblat/masterHEADmasterGravatar Alex Bennee2011-07-27
|\ | | | | FLAC: Fix segfault when setting picture description to ""
| * flac_tag: fix segfault when setting picture description to ""Gravatar Benjamin Barenblat2011-07-26
|/ | | | | | | | | | Flac_Tag_Write_File_Tag now checks to make sure the picture description string is non-null before attempting to set it. (Passing a null pointer to FLAC__metadata_object_picture_set_description violates that function's contract; see http://flac.sourceforge.net/api/group__flac__metadata__object.html#ga43). This brings Flac_Tag_Write_File_Tag's behavior in line with that of the analogous functions for Ogg and ID3 tags.
* Add option to make genre tags as "Text Only"Gravatar Daniel2011-04-23
| | | | | | | | | | | | | Quoth Daniel: "I also have a patch which sets the genre tag as a string instead of the genre number. This number is not probably handled by iTunes (it shows the number, not the actual genre name). I've added it as a attachment." This is controlled by an option in the ID3 preferences tab Written-By: Daniel <random.mister@gmail.com>
* Add a basic HACKING document to mention the prefered form for requestsGravatar Alex Bennee2011-04-23
| | | | and what the coding style seems to be.
* Add "Album Artist" field to the list of potential fields to editGravatar Daniel2011-04-23
| | | | | | | | | | | | Quoth Daniel (Random Mister): "I just found an extended patch which also includes support for the album-artist tag in the fill tags dialog. It is an update of the other, so if you only add this one to the git tree it should work. I've been using it for over half a year without bugs, so I think it can be merged into the Git tree." Written-By: Daniel <random.mister@gmail.com>
* misc.c: fix potential memory corruptionGravatar Alex Bennee2011-03-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As reported by valgrind: Invalid read of size 1 at 0x4C28064: strlen (mc_replace_strmem.c:282) by 0x9690261: g_strdup (in /usr/lib64/libglib-2.0.so.0.2600.1) by 0x89E700C: value_collect_string (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D7738: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D7CF1: g_signal_emit_by_name (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x4EEF092: gtk_entry_insert_text (in /usr/lib64/libgtk-x11-2.0.so.0.2200.1) by 0x449F1A: Insert_Only_Digit (misc.c:437) by 0x89BD19D: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D6278: signal_emit_unlocked_R (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D79F5: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D7CF1: g_signal_emit_by_name (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x4EEF092: gtk_entry_insert_text (in /usr/lib64/libgtk-x11-2.0.so.0.2200.1) Address 0x1604d642 is 0 bytes after a block of size 2 alloc'd at 0x4C25218: calloc (vg_replace_malloc.c:467) by 0x9678639: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.2600.1) by 0x449E8E: Insert_Only_Digit (misc.c:418) by 0x89BD19D: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D6278: signal_emit_unlocked_R (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D79F5: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x89D7CF1: g_signal_emit_by_name (in /usr/lib64/libgobject-2.0.so.0.2600.1) by 0x4EEF092: gtk_entry_insert_text (in /usr/lib64/libgtk-x11-2.0.so.0.2200.1) by 0x4EF4DB0: gtk_entry_set_text (in /usr/lib64/libgtk-x11-2.0.so.0.2200.1) by 0x43BFF9: ET_Display_File_Tag_To_UI (et_core.c:2802) by 0x43CC53: ET_Display_File_Data_To_UI (et_core.c:2545) by 0x4328A7: Action_Select_Nth_File_By_Etfile (easytag.c:1774) If we revisit this function it may be worth considering the guidance from the GTK manual about intercepting gtk_editible signals: http://library.gnome.org/devel/gtk/2.21/GtkEditable.html#GtkEditable-insert-text
* Merge branch 'master' of git://github.com/cmcginty/easytagGravatar Alex Bennee2011-03-28
|\
* \ Merge branch 'master' of github.com:stsquad/easytagGravatar Alex Bennee2011-03-28
|\ \
* \ \ Merge remote branch 'rbrito/fixes'Gravatar Alex Bennee2011-03-28
|\ \ \
| | | * Fix 'Preserve Modification Time' option for FLAC files.Gravatar Patrick C. McGinty2011-03-20
| | |/ | | | | | | | | | | | | | | | | | | | | | Resolve condition when 'preserve modification time' feature is disabled, FLAC files would not have their modification times changed. Secondly, it disables easytag from incorrectly warning the user that the file was changed by an external program, when easytag writes the file.
| * | cddb: avoid calling strlen many times in just a few statements.Gravatar Rogério Brito2011-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As strlen is a potentially costly function, it is better if we make a frugal use of it. To really make things cleaner here, we should replace all the `\n` or `\r` with null chars (i.e., `\0`) in just one go. This would reduce the complexity of the code from something quadratic to something linear in the length of the string. While we are at it, `fgets` does not return `EOF` (`fgetc` does, but `fgets` doesn't) when the end of file is reached and nothing can be read: it returns `NULL` instead.
| | * Remove executable bits from files that are not scripts/executables.Gravatar Rogério Brito2011-03-09
| |/ |/|
| * cddb: Plug some memory leaks.Gravatar Rogério Brito2011-03-08
| | | | | | | | | | | | | | | | | | | | Some of these functions are way, way too big and should be split. One obvious low hanging fruit is to use some intelligent goto's to clean up and avoid a bunch of if's in the code, in the very same fashion that is used in the code of the kernel. And, to be honest, using some of the coding style conventions of the kernel here would not hurt at all.
| * cddb: Eliminate unused variable.Gravatar Rogério Brito2011-03-08
| | | | | | | | | | Like this one, the code is full of variables that are defined, but not used and the code can be simplified.
| * Remove executable bits from files that are not scripts/executables.Gravatar Rogério Brito2011-03-08
| |
* | Stop accidental free of referenced FLAC vendor stringGravatar Patrick C. McGinty2011-03-08
|/ | | | | | | | | | The libFLAC API is unclear about how it handles empty strings. The original code assumed that empty string would be copied, when 'copy' param of set_vendor_string was true, as indicated in the API docs. Checking into the libFLAC source, when a string of length 0 is provided, it will NOT be copied. Therfore, free'ing empty string will cause a SIGSEGV or worse when the FLAC API tries to read the vendor string.
* Exclude nonexistent debian/ path from EXTRA_DISTGravatar FeRD (Frank Dana)2011-01-02
| | | | Fixes make targets for distdir/distfile building
* .gitignore for generated filesGravatar Alex Bennee2010-11-10
|
* Merge remote branch 'oldmanuk/ubuntu-patches' into new_masterGravatar Alex Bennee2010-11-10
|\
* | [patch] Base64 Decoding Major Performance Fix - ID: 2805834Gravatar Kip Warner2010-11-04
| | | | | | | | | | | | | | | | | | I've patched src/base64.c. There was a major problem when it was being called to decode very large buffers in orders of magnitude of a megabyte or more (e.g. cover art in a FLAC / Vorbis / etc. tag is frequently this size for some people). The base64_decode() routine had a cubic running time, since every time the decode pointer shifted forward in the stream, token_decode() would recompute the buffer length every time.
| * Fix configure.in to properly detect libmp4v2 library and update autogen ↵Gravatar Dominic Evans2010-11-03
| | | | | | | | input files to remove warnings when running autogen.sh
| * Remove checked-in build scripts that are auto-generated from autogen.Gravatar Dominic Evans2010-11-03
| |
| * [patch] debian/patches/manpage-has-bad-whatis-entry.patchGravatar Dominic Evans2010-11-03
| | | | | | | | Fix lintian warning.
| * [patch] debian/patches/02-autoreconf.patchGravatar Dominic Evans2010-11-03
| | | | | | | | Get rid of binary-or-shlib-defines-rpath lintian warning.
| * [patch] debian/patches/01-autoload.patchGravatar Dominic Evans2010-11-03
| | | | | | | | | | | | | | Fix the bug that easytag doesn't load the chosen directory when opening easytag from the "open with ..." nautilus right click menu. Ubuntu: https://bugs.launchpad.net/bugs/230873
| * Remove debian/ dir (accidentally included in easytag 2.1.5 and some earlier ↵Gravatar Dominic Evans2010-11-03
|/ | | | releases, correctly removed in 2.1.6)
* Applied Gentoo cddb patchGravatar Alex Bennee2010-07-14
|
* Applied Gentoo new_libmp4v2 patchGravatar Alex Bennee2010-07-14
|
* Applied Gentoo desktop_entry patchGravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.6Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.5Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.4Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.3Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.2Gravatar Alex Bennee2010-07-14
|
* EasyTag 2.1.1Gravatar Alex Bennee2010-07-14
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 19:19:30 +0000