aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
...
* Use default shell env for Python sha256 toolGravatar Clint Harrison2018-07-11
| | | | | | | | Until we have more complete support for Python runtime/toolchain configurations, it's useful for the hash tool to support `--action_env`, so the user's PATH can optionally be searched by the `py_binary` wrapper. Closes #5451. PiperOrigin-RevId: 204108228
* Improve MSVC CrosstoolGravatar Loo Rong Jie2018-07-10
| | | | | | | | | | | | | | | | | | | | - Remove `/D_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS`: it disables warnings for deprecated C++ headers (`<stdext/*>`, `<hash_map>` etc.). Only useful for legacy codebase. - Remove `/J`: `char` is signed according to ISO C++. There is no reason to make `char` unsigned by default. - Remove default `/Gy`: moved to feature (`smaller_binary`). - Remove default `/GF`: string pooling, enabled by default with `/O2`. - Remove `/DDEBUG` in `dbg` mode: conflict with macros defined in some OSS projects such as LLVM. User should use standard `NDEBUG` to detect debug mode. Implements a few general `feature` to abstract away details about the compiler: - `treat_warnings_as_errors`: aka `-Werror`. - `frame_pointer`: aka `-fno-omit-frame-pointer'. - `determinism`: redact `__TIME__` macros etc. - `disable_assertions`: allow user to have `assert/DCHECK` back even in `opt` mode. - `smaller_binary`: common optimization enabled in `opt` mode. Still allow user to disable it in `opt` (such as when using ASAN). - `ignore_noisy_warnings`: suppress a bunch of warnings most people don't care. If users want to be pedantic, they can still get those warnings back with `--features=-ignore_noisy_warnings`. Closes #5519. PiperOrigin-RevId: 203959555
* Prepare CROSSTOOL for dSYM simplificationGravatar Googler2018-07-10
| | | | | | | | Currently dSYM information is propagated using a zip file emitted by the linking action which contains a dwarf file and plist. A second action then unzips said file, discards the plist and propagates the dwarf file. This CL is part of a change which makes the link action emit the dwarf file directly. This change adds logic to the CROSSTOOL and wrapped_clang to temporarily support both the old and new approaches using the presence of DSYM_HINT_DSYM_BUNDLE_ZIP as a signal as to which to use. After this change the new (and temporary) CROSSTOOL feature no_dsym_create_zip will allow suppressing DSYM_HINT_DSYM_BUNDLE_ZIP from being passed. Once the migration is complete we will remove both the signal variable and feature. PiperOrigin-RevId: 203954795
* When using find_cpp_toolchain, make sure the relevant attribute, ↵Gravatar juliexxia2018-07-10
| | | | | | | '_cc_toolchain' exists on the ctx being passed to this function. (I broke TAP once because I forgot to add the attribute. Perhaps not that helpful this late in the migration but doesn't hurt.) RELNOTES: None. PiperOrigin-RevId: 203947282
* Document differences between version and version_fileGravatar katre2018-07-10
| | | | | | | | | Add to the documentation that version_file and release_file cannot be used to generate an output with the N-V-R.A naming scheme. Fixes #5522. Closes #5555. PiperOrigin-RevId: 203946762
* pkg: fix documentation (docker -> archive)Gravatar Klaus Aehlig2018-07-10
| | | | | | | pkg_tar creates an archive, not a docker image. Change-Id: I402bd8fdb67c38cd67a3990b983aa3b6d912da37 PiperOrigin-RevId: 203932291
* Set INCLUDE and LIB env var for actions that actually need themGravatar Loo Rong Jie2018-07-10
| | | | | | | | | | This makes console output of `bazel build -s` shorter when debugging `CROSSTOOL`. /cc @meteorcloudy Closes #5539. PiperOrigin-RevId: 203899866
* Automatic code cleanup.Gravatar gregce2018-07-09
| | | | PiperOrigin-RevId: 203841642
* Windows, CROSSTOOL: Fix feature for linking interface library and dynamic ↵Gravatar pcloudy2018-07-09
| | | | | | | | | | library 1. Do not apply /WHOLEARCHIVE to interface library 2. On Windows, we cannot link dll directly, so remove related flag_groups RELNOTES: None PiperOrigin-RevId: 203752406
* Windows, CROSSTOOL: Remove MSVC wrapper scripts from Bazel completelyGravatar Yun Peng2018-07-06
| | | | | | | | | | | The only reason that those python wrapper scripts still exists is for TensorFlow's Windows GPU build. As we will create a custom GPU CROSSTOOL in TF repo, we can finally remove wrapper scripts from Bazel. Closes #5526. RELNOTES: Python wrapper scripts for MSVC are removed. PiperOrigin-RevId: 203472223
* Automatic code cleanup.Gravatar cushon2018-07-06
| | | | PiperOrigin-RevId: 203454459
* Create Bazel coverage report action.Gravatar elenairina2018-07-06
| | | | | | | Fixes #5246 RELNOTES: None. PiperOrigin-RevId: 203453340
* Fix autodetection of -z linker flagsGravatar hlopko2018-07-06
| | | | | | | | | | Clang reports missing -Wl,-z,relro as "ld: unknwon option: -z"). This cl fixes the autodetection to expect the short variant. Fixes #5468. RELNOTES: NONE. PiperOrigin-RevId: 203449206
* Remove stub toolchains for iosGravatar hlopko2018-07-05
| | | | | | | Should not be needed anymore since we have dynamic configurations for a while. RELNOTES: None. PiperOrigin-RevId: 203435557
* Replace instances of Blaze with Bazel.Gravatar Dan Fabulich2018-07-05
| | | | | | | PiperOrigin-RevId: 203300374 Change-Id: Iaa47f870ab2e0cad40a202aad2c7f9430f73c856 PiperOrigin-RevId: 203407392
* python tools: ensure files are closedGravatar laszlocsomor2018-07-05
| | | | | | | | | | | Use the "with" statement to open files in various Python scripts used by Bazel, to ensure these files are closed eagerly. See https://github.com/bazelbuild/bazel/issues/5512 RELNOTES: none PiperOrigin-RevId: 203346678
* Fix autodetection of linker flagsGravatar hlopko2018-07-05
| | | | | | | | | | | Flags passed through clang to linker get -Wl, stripped in the error message (e.g. -Wl,-no-as-needed will be reported as "ld: unknwon option: -no-as-needed"). This cl fixes the autodetection to expect the stripped variant. Fixes #5468. RELNOTES: None. PiperOrigin-RevId: 203341563
* Remove the java_host_runtime_alias polyfill.Gravatar Benjamin Peterson2018-07-04
| | | | | | | Closes #5424. Change-Id: I16bb70ffec9d541c56ed0579ae616407073d46f2 PiperOrigin-RevId: 203279412
* windows_cc_configure.bzl: Check default VC installation directoriesGravatar pcloudy2018-07-04
| | | | | | | See https://github.com/bazelbuild/bazel/issues/5254#issuecomment-402131986 RELNOTES: None PiperOrigin-RevId: 203273587
* [LcovMerger] Make int fields of SourceFileCoverage be dynamically computed.Gravatar elenairina2018-07-04
| | | | | RELNOTES: None. PiperOrigin-RevId: 203264765
* [LcovMerger] Make gcc-branch related fields String instead of int.Gravatar elenairina2018-07-04
| | | | | | These fields can have very large values that don't fit into int. There's also no added value from storing an int instead of a String. PiperOrigin-RevId: 203260628
* add more support for ArmGravatar Bin Lu2018-07-04
| | | | | | | | Signed-off-by: Bin Lu <bin.lu@arm.com> Closes #5477. PiperOrigin-RevId: 203241216
* Create a whitelist for android_library rules with deps but not srcsGravatar cushon2018-07-03
| | | | PiperOrigin-RevId: 203230801
* Update android_sdk system_image support to include 27 and 28.Gravatar jingwen2018-07-03
| | | | | RELNOTES: None. PiperOrigin-RevId: 203169316
* bump dependency on desugar_jdk_libs to pull in latest changes.Gravatar kmb2018-07-03
| | | | | | RELNOTES: None. PiperOrigin-RevId: 203166771
* Quiet some warningsGravatar cushon2018-07-03
| | | | PiperOrigin-RevId: 203159437
* git_repository: support branch as wellGravatar Klaus Aehlig2018-07-03
| | | | | | | | | Now that git_repository returns the commit actually checked out (and we have means of recording it), support following an active branch of a git repository. Change-Id: I6e152c59b694bbf562b345ee88282a8c9bd58e4c PiperOrigin-RevId: 203110735
* Windows CROSSTOOL: Add action_config for preprocess-assembleGravatar pcloudy2018-07-02
| | | | | | | Fixed https://github.com/bazelbuild/bazel/issues/5495 RELNOTES: None PiperOrigin-RevId: 202929359
* Delete git_repositories.bzl. The file has been a simple redirect to git.bzl ↵Gravatar dannark2018-07-02
| | | | | | | | for well over a year and a half. RELNOTES[INC]: Loading @bazel_tools//tools/build_defs/repo:git_repositories.bzl no longer works. Load @bazel_tools//tools/build_defs/repo:git.bzl instead. PiperOrigin-RevId: 202923049
* Fix typo in docGravatar dannark2018-07-02
| | | | | RELNOTES: None PiperOrigin-RevId: 202914788
* Support RAII in wrapped_clangGravatar Googler2018-06-29
| | | | | | | | | If a program `abort`s, `exit`s, or `exec`s a different program, destructors won't run. To allow RAII in wrapped_clang, remove all its `abort` and `exec` calls. `main` is now the single exit point for the program, and destructors will always run after `main` returns. PiperOrigin-RevId: 202658759
* Add aliases for current_cc_host_toolchain, current_libc_top and filegroupGravatar dbabkin2018-06-28
| | | | | | | crosstool to agregate all its together. RELNOTES:none PiperOrigin-RevId: 202470052
* runfiles libraries: fix tests and commentsGravatar Laszlo Csomor2018-06-27
| | | | | | | | | | | | | | | | | | | | | | | | | | - Update all runfiles libraries to have the same header comment format, including the build rule to depend on the namespace / header / module to import - Fix runfiles_test.cc to include the right files (recent refactoring commit has split src/main/cpp/util/path.cc from file_[platform].cc) - Change exported variable _rlocation_isabs_pattern in runfiles.bash to be upper-case, so it is visibly a variable and not a function. See https://github.com/bazelbuild/bazel/issues/4460 Change-Id: I17e18308506ab9f5c9f410ef6bc6b9df912d42a9 Closes #5481. Change-Id: I17e18308506ab9f5c9f410ef6bc6b9df912d42a9 PiperOrigin-RevId: 202291629
* Use the current processes' environment, as xcrunwrapper requires some of ↵Gravatar kaipi2018-06-26
| | | | | | these values when being invoked. PiperOrigin-RevId: 202173180
* Remove support for header preprocessingGravatar hlopko2018-06-26
| | | | | | | This was never used. We thought it will be useful, but it's not. RELNOTES: None. PiperOrigin-RevId: 202143524
* Replace //tools/defaults:jdk to //tools/jdk:*Gravatar dbabkin2018-06-26
| | | | | | | As //tools/defaults will be deprecated soon. All usages of //tools/defaults:jdk and //tools/defaults:java_toolchain should be replaced by corresponding targets in //tools/jdk/BUILD package RELNOTES:none PiperOrigin-RevId: 202114489
* http_archive: remove noisy debug printsGravatar Jeremy Nimmer2018-06-25
| | | | | | | | | | | | Commit bd16ab9454e624a26c53a0f3fb892e20fb1c36e6 documents that these statements are no longer required to achieve prefetching (as of commit cdc99afc1a03ff8fbbbae088d358b7c029e0d232). Given that many `http_archive` calls will need at least a `build_file`, these debugging prints generate an incredible amount of spam in projects with many external archives. I looked over the rest of the `build_defs/repo` files and none of them have any tracing debug prints, except for `git.bzl` which guards it with an `attr.verbose`. I could rework this to add a verbosity flag if you wish, but it doesn't seem merited for http fetching (unlike git, which is relatively more expensive and can be flaky). Relates to #2700. Closes #5446. PiperOrigin-RevId: 201947174
* Make @bazel_tools//tools/build_defs/cc/action_names.bzl work for bazel osx testsGravatar hlopko2018-06-25
| | | | | RELNOTES: None. PiperOrigin-RevId: 201941079
* Fix typo in http.bzlGravatar Loo Rong Jie2018-06-25
| | | | | | | | #5407 Closes #5450. PiperOrigin-RevId: 201933209
* Add bazel rules for referencing android.test APIs when using android-28.Gravatar Googler2018-06-21
| | | | | | The android.test classes have been moved from the android.jar in android-28. This CL attempts to add a rule for accessing them. PiperOrigin-RevId: 201607890
* Automated rollback of commit 5728af65e8b89b9dd3a5ac2b717c93ec5333ca18.Gravatar hlopko2018-06-21
| | | | | | RELNOTES: None. *** Reason for rollback *** PiperOrigin-RevId: 201573394
* Migrate //devtools/clif/python/legacy_match_clif_rule.bzl to the new C++ ↵Gravatar hlopko2018-06-21
| | | | | | | | | | | | | | toolchain API This is a part of the [] This is an encore of unknown commit which includes fixes for: * //miles ([] * clif tests ([] * exoblaze ([] RELNOTES: None. PiperOrigin-RevId: 201541210
* shell tests, windows: enable more testsGravatar Laszlo Csomor2018-06-21
| | | | | | | | | | | | | | | | | | Enable on Windows: //src/test/shell/bazel:bazel_experimental_ui_test //src/test/shell/bazel:bazel_random_characters_test Also document the (surprising) semantics of http_file() on Windows. See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: Id636b9cf03cc8d12449eed2be493dcfc176146c7 Closes #5409. Change-Id: I15677548f2f3fd6b4822e8e6af4b78d8517f953a PiperOrigin-RevId: 201512812
* Add Arm64 supportGravatar Arielle Albon2018-06-20
| | | | | | | | Based on work of Sun Zhiyi <zhiyisun@gmail.com>. Closes #5360. PiperOrigin-RevId: 201339882
* git_repository: return actual commitGravatar Klaus Aehlig2018-06-15
| | | | | | | | | | | | | | Using that repository rules now may return a non-None value, make git_repository return the arguments that make the rule reproducible; in particular, return the actual commit (instead of a tag) and the date of the commit, so support shallow clones. The added test also demonstrates how the `bazel sync` command together with `--experimental_repository_resolved_file` can be used to replay an earlier state of external dependencies. Change-Id: Ifa1cfdfdb5eb299a15b9d0ec7d285dc84c0bcdc0 PiperOrigin-RevId: 200705705
* Change -lgcov with --coverageGravatar elenairina2018-06-15
| | | | | | | in Bazel osx CROSSTOOL. -lgcov is not supported on macOS. See #5128. RELNOTES: None. PiperOrigin-RevId: 200691758
* Pull in the right deps into the embedded tools.Gravatar Irina Iancu2018-06-14
| | | | | | | | | | | | | | | | | Fixes #5378. $ find $(bazel-bin/src/bazel info install_base) -type f | wc -l 508 $ stat -c %s bazel-bin/src/bazel 115014201 The number of embedded files is now 508 and the binary size is ~115Mb. RELNOTES: None. Change-Id: I75e43a959e1201cc36718a9acd0af96e9506c7d4 PiperOrigin-RevId: 200539940
* Don't rerun the command if it failed.Gravatar thomasvl2018-06-13
| | | | | | | | | | | | | | | | | | | While the original intent was to provide better messaging, the truth is things like ibtool and actool can error because of the state of CoreServices when targeting anything other than macOS. It appears this attempt to validate the sdk argument ends up succeeding in some cases, meaning it doesn't fail quickly, it does a fair mount of work, which we promptly throw away and still return the original error result. Rather then trying to expand this into some even more completely retry logic it seems better to back away from this attempted messaging instead. Looking at at history the better messaging stems from why it was recommended that folks also pass the SDK version along with the Xcode version, but we've gone back to just saying specific the Xcode version, so need for this improved messaging has also been reduced. PiperOrigin-RevId: 200422952
* Skylark repos: for failed patch command, also report stdoutGravatar Klaus Aehlig2018-06-13
| | | | | | | | | | The patch(1) utility usually gives error messages on stdout. So it is not useful to report only stderr in case a patch failed. Report both. Fixes #5379. Change-Id: Ief198849e29ca989dfdefe2fadf495a0b0949972 PiperOrigin-RevId: 200377306
* Skylark repositories: support additional arguments for the patch toolGravatar Klaus Aehlig2018-06-13
| | | | | | | | | | | | Instead of hard-coding "-p0", allow the arguments for that patch tool to be overridden. In particular, this supports the use case of patches generated with `git format-patch` which are to be read as `-p1`. Improves on #5379. Closes #4974 as superseded. Change-Id: I809fde14beab21d8a755ba4f1706b602bae3c1bb PiperOrigin-RevId: 200373909