diff options
| author |  Jeremy Nimmer <jeremy.nimmer@tri.global> | 2018-06-25 07:02:35 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-25 07:04:28 -0700 |
| commit | eed98a66405ff70c69d435a9419c3dc4ae7c184a (patch) | |
| tree | 1f740df5eb9a7a1ead936044accbab05cdff47a0 /tools | |
| parent | 1c393c25e11dade34ad7ba61a1691cd7651353c9 (diff) | |
http_archive: remove noisy debug prints
Commit bd16ab9454e624a26c53a0f3fb892e20fb1c36e6 documents that these statements are no longer required to achieve prefetching (as of commit cdc99afc1a03ff8fbbbae088d358b7c029e0d232). Given that many `http_archive` calls will need at least a `build_file`, these debugging prints generate an incredible amount of spam in projects with many external archives.
I looked over the rest of the `build_defs/repo` files and none of them have any tracing debug prints, except for `git.bzl` which guards it with an `attr.verbose`. I could rework this to add a verbosity flag if you wish, but it doesn't seem merited for http fetching (unlike git, which is relatively more expensive and can be flaky).
Relates to #2700.
Closes #5446.
PiperOrigin-RevId: 201947174
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/build_defs/repo/http.bzl | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/build_defs/repo/http.bzl b/tools/build_defs/repo/http.bzl index 3d2007cd25..2fda0bf76f 100644 --- a/tools/build_defs/repo/http.bzl +++ b/tools/build_defs/repo/http.bzl @@ -39,12 +39,6 @@ def _http_archive_impl(ctx): if ctx.attr.build_file and ctx.attr.build_file_content: ctx.fail("Only one of build_file and build_file_content can be provided.") - if ctx.attr.build_file: - print("ctx.attr.build_file %s, path %s" % - (str(ctx.attr.build_file), ctx.path(ctx.attr.build_file))) - for patchfile in ctx.attr.patches: - print("patch file %s, path %s" % (patchfile, ctx.path(patchfile))) - all_urls = [] if ctx.attr.urls: all_urls = ctx.attr.urls |