aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* test-wrapper: add empty impl + Bazel flagGravatar Laszlo Csomor2018-08-14
| | | | | | | | | | | | | | | | | | | | | | | This commit adds: - the skeleton implementation of the Windows native test wrapper - a depenency on the native test wrapper from test rules, through the new $test_wrapper rule attribute - the --windows_native_test_wrapper Bazel flag, which is currently a no-op See https://github.com/bazelbuild/bazel/issues/5508 Change-Id: I8df95c8ce8bab53c51c257698ec95416065a836e Closes #5854. Change-Id: I2ffc78bceec5dd867af775b5878f105fa87c3dba PiperOrigin-RevId: 208650699
* Add --filter_sources flag to LcovMerger.Gravatar iirina2018-08-14
| | | | | | | | | | | | When the `--filter_sources` flag is used `LcovMerger` excludes from the merged coverage the sources whose names match any of the regex in the flag. The value of `--filter_sources` is a list of regex separated by `,`. This flag comes as a preparation for using `gcov` instead of `lcov` for collecting coverage data for C++. The flag was not needed before because `lcov` has some functionality for excluding some files (e.g. `--no-external` to ignore coverage data for system files). Closes #5834. PiperOrigin-RevId: 208606867
* Don't disable preverificationGravatar cushon2018-08-13
| | | | | | | to ensure output contains valid stack map tables. context: https://github.com/bazelbuild/bazel/issues/5855 PiperOrigin-RevId: 208555048
* Quiet 'Illegal reflective access by com.google.protobuf.UnsafeUtil' warningsGravatar cushon2018-08-13
| | | | | see: https://github.com/google/protobuf/issues/3781 PiperOrigin-RevId: 208535953
* Java, runfiles: fix deprecation target releaseGravatar laszlocsomor2018-08-10
| | | | | | | | | | | | | | Adjust the expected Bazel release version that I expect will drop the deprecated @bazel_tools//tools/runfiles:java-runfiles target. The change which made this target deprecated will first be released in 0.18.0, so we need at least one more release before we can remove the target. RELNOTES[NEW]: Java, runfiles: the Java runfiles library is now in @bazel_tools//tools/java/runfiles. The old target (@bazel_tools//tools/runfiles:java-runfiles) is deprecated and will be removed in Bazel 0.19.0 (not 0.18.0, as stated earlier). PiperOrigin-RevId: 208203724
* Java, runfiles: move runfiles library sourcesGravatar laszlocsomor2018-08-10
| | | | | | | | | | | | Move the Java runfiles library's sources from //src/tools/runfiles/j/c/g/devtools/build/runfiles:* to //tools/java/runfiles. Fixes https://github.com/bazelbuild/bazel/issues/5803 RELNOTES[NEW]: Java, runfiles: the Java runfiles library is now in @bazel_tools//tools/java/runfiles. The old target (@bazel_tools//tools/runfiles:java-runfiles) is deprecated and will be removed in Bazel 0.18.0. PiperOrigin-RevId: 208191521
* Do not hardcode LCOV pathGravatar Vladimir Zaytsev2018-08-10
| | | | | | | | fixes #5644 Closes #5646. PiperOrigin-RevId: 208175002
* Windows: add //tools/... tests to test suiteGravatar Laszlo Csomor2018-08-09
| | | | | | | | | | | | Add all tests under //tools/... to //src:all_windows_tests, to run them on Bazel CI. See https://github.com/bazelbuild/bazel/issues/4292 Closes #5839. Change-Id: Iae647f561683cc50ef62416c4b834576ae918486 PiperOrigin-RevId: 208167743
* external repos: fix typo confusing workspace_file_content and build_file_contentGravatar Klaus Aehlig2018-08-09
| | | | | | | Fixes #5838 Change-Id: Ic5f730f97b43682b1efc537a02c861d49d3606cc PiperOrigin-RevId: 208044984
* Support 2 more valid gcov info lines in GcovParser.Gravatar iirina2018-08-09
| | | | | | Closes #5843. PiperOrigin-RevId: 208041110
* Windows,tests: port output_filter_testGravatar Laszlo Csomor2018-08-09
| | | | | | | | | | | | | | | | | | | | //src/test/shell/integration:output_filter_test now runs on Windows. Also remove the "bazel clean" calls that are meant to trigger recompilations, and instead achieve the same effect by updating the mock source files. This saves about 12 seconds of test's runtime on Windows. See https://github.com/bazelbuild/bazel/issues/4292 Change-Id: Id3a6854fe6715893b43d4a06e07b7e70524059f9 Closes #5754. Change-Id: I9d9d23f4ccb0471fab4ae7cc45f2857c170546a4 PiperOrigin-RevId: 208016336
* Java: add @bazel_tools//tools/java/runfilesGravatar Laszlo Csomor2018-08-09
| | | | | | | | | | | See https://github.com/bazelbuild/bazel/issues/5803 Change-Id: I49a2e744af667d34aedc3384629acd48641b0921 Closes #5804. Change-Id: I75f85f02384fd1d9f6ebac5fff7c96c7278f7cdd PiperOrigin-RevId: 208010815
* Create BUILD.tools for //tools/test package.Gravatar Laszlo Csomor2018-08-09
| | | | | | | | | | | | | | | | | | | Motivation: as part of fixing issue #5508, I'll add a cc_binary to this package. The binary will be embedded in Bazel as a prebuilt binary (to avoid requiring a C++ compiler to use it). Therefore //tools/test/BUILD and @bazel_tools//tools/test/BUILD will contain different rules, mandating the BUILD file split. See https://github.com/bazelbuild/bazel/issues/5508 Change-Id: If21bafbc3d83d59e52de498cf3efd2b1b79fa7b6 Closes #5787. Change-Id: If21bafbc3d83d59e52de498cf3efd2b1b79fa7b6 PiperOrigin-RevId: 208005382
* Remove a println left over from debuggingGravatar cushon2018-08-08
| | | | PiperOrigin-RevId: 207954809
* Don't use @local_jdk for jni headersGravatar cushon2018-08-08
| | | | | | | | | instead, read the heads from the configured java runtime, so the values track with changes to --javabase. See #5594 PiperOrigin-RevId: 207894086
* 'DumpPlatformClasspath' now dumps the current JDK's default platform classpathGravatar cushon2018-08-08
| | | | | | | | | | | instead of indirecting through javac's bootclasspath handling and attempting to pin to a particular source version. This is a stop-gap until we can just use javac's --release flag. Using the output of DumpPlatformClasspath as the bootclasspath for the default java_toolchain side-steps issues with @local_jdk (see #5744, #5594). PiperOrigin-RevId: 207890272
* In java_rules_skylark depend on the javabase through ↵Gravatar cushon2018-08-08
| | | | | | | | | | //tools/jdk:current_java_runtime instead of referencing @local_jdk directly. See bazelbuild/bazel#5594 PiperOrigin-RevId: 207889762
* git.bzl: also clone branches with --depth=1Gravatar Klaus Aehlig2018-08-08
| | | | | | | | | Cloning branches as added after the fact to the skylark git rules, once recording the actual commit was implemented. Still support shallow cloning also when following branches. Change-Id: Ib7a84de4ada69152e9e7c27e9d84cff39cfd3582 PiperOrigin-RevId: 207866303
* Temporarily restore the JDK 8 host_javabase-compatible toolchainGravatar cushon2018-08-07
| | | | | | | | Unlike previously, this is not magically selected when running on JDK 8. Use --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 to configure the JDK 8 host_javabase-compatible toolchain. PiperOrigin-RevId: 207738992
* Remove uses of java_toolchain.encodingGravatar cushon2018-08-07
| | | | PiperOrigin-RevId: 207734653
* Add option to specify name for downloaded file to http_file skylark ruleGravatar Nicolas Lopez2018-08-07
| | | | | | | | https://github.com/bazelbuild/bazel/issues/5633 Closes #5647. PiperOrigin-RevId: 207706657
* Replace cd with git -C during in git skylark rulesGravatar Ed Baunton2018-08-07
| | | | | | | | Use `git -C` instead of `cd` in git skylark rules to be more concise. I think it's probably better to use the built-in changedir functionality of git rather than `cd`ing around manually. Happy to be overruled however if it makes readability better. Closes #5668. PiperOrigin-RevId: 207703326
* git_repository could use HTTP_PROXY to clone repositoryGravatar wylazy2018-08-07
| | | | | | | | | | git_repository could use HTTP_PROXY to clone repository Fixes #3893. Closes #5674. PiperOrigin-RevId: 207689348
* Clean up Java toolchain configurationGravatar cushon2018-08-07
| | | | | | now that JDK 8 host_javabases are no longer supported. PiperOrigin-RevId: 207687089
* Fix the ordering of month and day.Gravatar Ed Schouten2018-08-07
| | | | | | | | | | | | | I got an INFO message from Bazel containing the following date string: "shallow_since": "2018-31-07" The code seems to reveal that the date is intended to be YYYY-MM-DD, so change the requested format passed to Git. Closes #5734. PiperOrigin-RevId: 207683709
* Add objc-fully-link to the list of actions that require the apple_env ↵Gravatar kaipi2018-08-06
| | | | | | feature. This fixes apple_static_library functionality. PiperOrigin-RevId: 207625792
* Disable the correct warningGravatar Loo Rong Jie2018-08-03
| | | | | | | | | | | | | | | I realized that I wrote the wrong warning code when I use Bazel from master branch and build something with MSVC. For the curious: - C4117: https://msdn.microsoft.com/en-us/library/9d2szxf8.aspx - C4177: https://msdn.microsoft.com/en-us/library/s4becxs9.aspx /cc @meteorcloudy Closes #5631. PiperOrigin-RevId: 207235606
* Use a parameterized dict and simplify an iteration in xcode-locator.Gravatar jmmv2018-08-01
| | | | | | | | | | | This raises the minimum version with which xcode-locator must be built to Xcode 7. Changes suggested by davg@ during the review of another change to the xcode-locator. RELNOTES: None. PiperOrigin-RevId: 206949696
* Add a parser for gcov intermediate file format.Gravatar Irina Iancu2018-08-01
| | | | | | | | | | | This change comes as a preparation for using gcov for Bazel C++ coverage instead of lcov. See documentation of gcov intermediate format at https://gcc.gnu.org/onlinedocs/gcc/Invoking-Gcov.html#Invoking-Gcov under --intermediate-format. Change-Id: I6cd2df8b3a6611b187a2b0c161b14388413bc670 PiperOrigin-RevId: 206940660
* Add the action_names_test_files target to the OSS version of ↵Gravatar kaipi2018-08-01
| | | | | | tools/buils_defs/cc/BUILD. PiperOrigin-RevId: 206939687
* Add extra logging to xcode-locator when scanning Xcode bundles.Gravatar jmmv2018-08-01
| | | | | RELNOTES: None. PiperOrigin-RevId: 206933729
* Break out xcode-locator's main function into smaller chunks.Gravatar jmmv2018-07-31
| | | | | | | | | This is intended to be a refactoring without functional changes for my own sanity in understanding what this code does. Except I couldn't avoid applying some visual improvements to the usage message. RELNOTES: None. PiperOrigin-RevId: 206771539
* Automatic code cleanup.Gravatar Googler2018-07-30
| | | | PiperOrigin-RevId: 206567309
* Adding option to change the root directory name in build_tar.py and archive.py.Gravatar Googler2018-07-27
| | | | | | | This is required to support Windows Docker image creation. RELNOTES: None PiperOrigin-RevId: 206326316
* shell tests: use Bazel-embedded Bash runfiles libGravatar laszlocsomor2018-07-27
| | | | | | | | Use the Bash runfiles library under @bazel_tools, do not depend on it from source. RELNOTES: none PiperOrigin-RevId: 206312278
* Add a flag to split test.xml generation into a separate SpawnGravatar ulfjack2018-07-27
| | | | | | | | | | At this time, this is only implemented for the StandaloneTestStrategy. This solves a race condition on Posix-like systems, where we cannot guarantee that the pipes are actually fully flushed to disk when the test process exits, and this can cause the test.xml to be empty, which makes it hard to debug issues. (The test.log files do not show up in normal CI systems, only the test.xml files.) Progress on #4608. PiperOrigin-RevId: 206292179
* Send xcode-locator error messages to stderr, not stdout.Gravatar jmmv2018-07-26
| | | | | RELNOTES: None. PiperOrigin-RevId: 206224046
* Cut long lines in xcode-locator.m.Gravatar jmmv2018-07-26
| | | | | | | This is just a style fix so it should have no functional changes. RELNOTES: None. PiperOrigin-RevId: 206220348
* Add new debug_prefix_map_pwd_is_dot CROSSTOOL featureGravatar Googler2018-07-25
| | | | | | | | | | | | This feature sets `-fdebug_prefix_map=$PWD=.` as an argument to Clang in order to standardize the paths to debug symbols (by making them relative to the exec root). Note that this needs to be implemented inside wrapped_clang instead of as an argument to the action itself for caching purposes, as PWD can change based on the action's executor. PiperOrigin-RevId: 206019016
* Remove obsolete stuff related to JDK7 supportGravatar Philipp Wollermann2018-07-25
| | | | | | Closes #5626. PiperOrigin-RevId: 205991094
* update to embedded jdk to jdk10Gravatar buchgr2018-07-24
| | | | | RELNOTES: The JDK shipped with Bazel was updated to JDK10. PiperOrigin-RevId: 205865966
* Quiet more proto/unsafe warningsGravatar cushon2018-07-24
| | | | | | Fixes #5599 PiperOrigin-RevId: 205794997
* runfiles.bash: move a line of commentGravatar laszlocsomor2018-07-23
| | | | | RELNOTES: none PiperOrigin-RevId: 205651683
* jdk: use parallel old gc and disable compact stringsGravatar buchgr2018-07-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When switching to JDK9 we regressed on java build performance by about ~30%. We found that when using parallel gc instead of G1 and disabling compact strings for JavaBuilder, the java build performance is "only" 10% slower. We additionally found JDK9 to have a significantly higher startup time. This impacts the performance of tools like javac and tubine and we believe that this accounts for most of the remaining overhead that can't be explained by disabling G1 and compact strings. java8 -version: 80ms java9 -version: 140ms java10 -version: 110ms Additionally, we found that the number of modules shipped with the JDK have a direct effect on the startup time. When building Java 10 with only the 9 modules required by Bazel we find that the startup time reduces to 80ms (from 110ms) which is on par with Java 8. We thus expect the regression to be fixed by a future migration to Java 10, which should be done in one of the next Bazel releases. == Some benchmark results == https://github.com/google/protobuf $ bazel build :protobuf_java Bazel 0.15.2: 4.2s Bazel 0.16.0-rc2: 5.2s This Change: 4.2s https://github.com/jin/android-projects/tree/master/java_only $ bazel build :module0 Bazel 0.15.2: 8.2s Bazel 0.16.0-rc2: 11.5s This Change: 9.1s RELNOTES: None PiperOrigin-RevId: 205647957
* Revert "Support RAII in wrapped_clang"Gravatar bbaren2018-07-17
| | | | | | | | | | | This reverts commit 202658759, which does not correctly propagate Clang error codes. PiperOrigin-RevId: 204991287 Notes: The commit message should begin "This reverts commit f24958a11e3a54f563429aadc12bce033be047fa ...".
* git_repository: remove .git directoryGravatar Klaus Aehlig2018-07-17
| | | | | | | | | | | While we do not expect any targets to actually depend on the contents of the .git subdirectory of an external repository, it is still a non-reproducible part of an external git repository, blocking all attempts to demonstrate reproducibility of that the given rule. Change-Id: Id1e08013a8ca33d4b4c4b053b9423f75d771dfc1 PiperOrigin-RevId: 204872242
* Add --incompatible_disable_deprecated_attr_params to disable some deprecated ↵Gravatar cparsons2018-07-16
| | | | | | | parameters of the skylark attr module. RELNOTES: None. PiperOrigin-RevId: 204797954
* http.bzl: Use allow_single_file for labelsGravatar Ed Baunton2018-07-16
| | | | | | | | | | | To match the label declarations in git.bzl, use `allow_single_file` for workspace and build file labels. Per https://docs.bazel.build/versions/master/skylark/lib/attr.html#label this restricts the labels to specify only a single file. Closes #5561. PiperOrigin-RevId: 204773387
* Rewrite swift_binary_test.bzl using new skylark cc toolchain apiGravatar hlopko2018-07-16
| | | | | | | This is a part of the https://github.com/bazelbuild/bazel/issues/4571 effort. RELNOTES: None PiperOrigin-RevId: 204754855
* Remove fallback for SDKROOT as all users of this script are setting the ↵Gravatar kaipi2018-07-16
| | | | | | environment properly. PiperOrigin-RevId: 204738902