| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES: The JDK shipped with Bazel was updated to JDK10.
PiperOrigin-RevId: 205865966
|
|
|
|
|
|
| |
Fixes #5599
PiperOrigin-RevId: 205794997
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 205651683
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When switching to JDK9 we regressed on java build performance by about ~30%.
We found that when using parallel gc instead of G1 and disabling compact
strings for JavaBuilder, the java build performance is "only" 10% slower.
We additionally found JDK9 to have a significantly higher startup time.
This impacts the performance of tools like javac and tubine and we
believe that this accounts for most of the remaining overhead that can't
be explained by disabling G1 and compact strings.
java8 -version: 80ms
java9 -version: 140ms
java10 -version: 110ms
Additionally, we found that the number of modules shipped with the JDK
have a direct effect on the startup time. When building Java 10 with only
the 9 modules required by Bazel we find that the startup time reduces to
80ms (from 110ms) which is on par with Java 8.
We thus expect the regression to be fixed by a future migration to Java 10,
which should be done in one of the next Bazel releases.
== Some benchmark results ==
https://github.com/google/protobuf
$ bazel build :protobuf_java
Bazel 0.15.2: 4.2s
Bazel 0.16.0-rc2: 5.2s
This Change: 4.2s
https://github.com/jin/android-projects/tree/master/java_only
$ bazel build :module0
Bazel 0.15.2: 8.2s
Bazel 0.16.0-rc2: 11.5s
This Change: 9.1s
RELNOTES: None
PiperOrigin-RevId: 205647957
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 202658759, which does
not correctly propagate Clang error codes.
PiperOrigin-RevId: 204991287
Notes:
The commit message should begin "This reverts commit
f24958a11e3a54f563429aadc12bce033be047fa ...".
|
|
|
|
|
|
|
|
|
|
|
| |
While we do not expect any targets to actually depend on the
contents of the .git subdirectory of an external repository,
it is still a non-reproducible part of an external git repository,
blocking all attempts to demonstrate reproducibility of that
the given rule.
Change-Id: Id1e08013a8ca33d4b4c4b053b9423f75d771dfc1
PiperOrigin-RevId: 204872242
|
|
|
|
|
|
|
| |
parameters of the skylark attr module.
RELNOTES: None.
PiperOrigin-RevId: 204797954
|
|
|
|
|
|
|
|
|
|
|
| |
To match the label declarations in git.bzl, use `allow_single_file` for
workspace and build file labels.
Per https://docs.bazel.build/versions/master/skylark/lib/attr.html#label this restricts the labels to specify only a single file.
Closes #5561.
PiperOrigin-RevId: 204773387
|
|
|
|
|
|
|
| |
This is a part of the https://github.com/bazelbuild/bazel/issues/4571 effort.
RELNOTES: None
PiperOrigin-RevId: 204754855
|
|
|
|
|
|
| |
environment properly.
PiperOrigin-RevId: 204738902
|
|
|
|
|
|
|
|
| |
Until we have more complete support for Python runtime/toolchain configurations, it's useful for the hash tool to support `--action_env`, so the user's PATH can optionally be searched by the `py_binary` wrapper.
Closes #5451.
PiperOrigin-RevId: 204108228
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove `/D_SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS`: it disables warnings for deprecated C++ headers (`<stdext/*>`, `<hash_map>` etc.). Only useful for legacy codebase.
- Remove `/J`: `char` is signed according to ISO C++. There is no reason to make `char` unsigned by default.
- Remove default `/Gy`: moved to feature (`smaller_binary`).
- Remove default `/GF`: string pooling, enabled by default with `/O2`.
- Remove `/DDEBUG` in `dbg` mode: conflict with macros defined in some OSS projects such as LLVM. User should use standard `NDEBUG` to detect debug mode.
Implements a few general `feature` to abstract away details about the compiler:
- `treat_warnings_as_errors`: aka `-Werror`.
- `frame_pointer`: aka `-fno-omit-frame-pointer'.
- `determinism`: redact `__TIME__` macros etc.
- `disable_assertions`: allow user to have `assert/DCHECK` back even in `opt` mode.
- `smaller_binary`: common optimization enabled in `opt` mode. Still allow user to disable it in `opt` (such as when using ASAN).
- `ignore_noisy_warnings`: suppress a bunch of warnings most people don't care. If users want to be pedantic, they can still get those warnings back with `--features=-ignore_noisy_warnings`.
Closes #5519.
PiperOrigin-RevId: 203959555
|
|
|
|
|
|
|
|
| |
Currently dSYM information is propagated using a zip file emitted by the linking action which contains a dwarf file and plist. A second action then unzips said file, discards the plist and propagates the dwarf file. This CL is part of a change which makes the link action emit the dwarf file directly.
This change adds logic to the CROSSTOOL and wrapped_clang to temporarily support both the old and new approaches using the presence of DSYM_HINT_DSYM_BUNDLE_ZIP as a signal as to which to use. After this change the new (and temporary) CROSSTOOL feature no_dsym_create_zip will allow suppressing DSYM_HINT_DSYM_BUNDLE_ZIP from being passed. Once the migration is complete we will remove both the signal variable and feature.
PiperOrigin-RevId: 203954795
|
|
|
|
|
|
|
| |
'_cc_toolchain' exists on the ctx being passed to this function. (I broke TAP once because I forgot to add the attribute. Perhaps not that helpful this late in the migration but doesn't hurt.)
RELNOTES: None.
PiperOrigin-RevId: 203947282
|
|
|
|
|
|
|
|
|
| |
Add to the documentation that version_file and release_file cannot be used to generate an output with the N-V-R.A naming scheme.
Fixes #5522.
Closes #5555.
PiperOrigin-RevId: 203946762
|
|
|
|
|
|
|
| |
pkg_tar creates an archive, not a docker image.
Change-Id: I402bd8fdb67c38cd67a3990b983aa3b6d912da37
PiperOrigin-RevId: 203932291
|
|
|
|
|
|
|
|
|
|
| |
This makes console output of `bazel build -s` shorter when debugging `CROSSTOOL`.
/cc @meteorcloudy
Closes #5539.
PiperOrigin-RevId: 203899866
|
|
|
|
| |
PiperOrigin-RevId: 203841642
|
|
|
|
|
|
|
|
|
|
| |
library
1. Do not apply /WHOLEARCHIVE to interface library
2. On Windows, we cannot link dll directly, so remove related flag_groups
RELNOTES: None
PiperOrigin-RevId: 203752406
|
|
|
|
|
|
|
|
|
|
|
| |
The only reason that those python wrapper scripts still exists is for
TensorFlow's Windows GPU build. As we will create a custom GPU CROSSTOOL
in TF repo, we can finally remove wrapper scripts from Bazel.
Closes #5526.
RELNOTES: Python wrapper scripts for MSVC are removed.
PiperOrigin-RevId: 203472223
|
|
|
|
| |
PiperOrigin-RevId: 203454459
|
|
|
|
|
|
|
| |
Fixes #5246
RELNOTES: None.
PiperOrigin-RevId: 203453340
|
|
|
|
|
|
|
|
|
|
| |
Clang reports missing -Wl,-z,relro as "ld: unknwon option:
-z"). This cl fixes the autodetection to expect the short variant.
Fixes #5468.
RELNOTES: NONE.
PiperOrigin-RevId: 203449206
|
|
|
|
|
|
|
| |
Should not be needed anymore since we have dynamic configurations for a while.
RELNOTES: None.
PiperOrigin-RevId: 203435557
|
|
|
|
|
|
|
| |
PiperOrigin-RevId: 203300374
Change-Id: Iaa47f870ab2e0cad40a202aad2c7f9430f73c856
PiperOrigin-RevId: 203407392
|
|
|
|
|
|
|
|
|
|
|
| |
Use the "with" statement to open files in various
Python scripts used by Bazel, to ensure these
files are closed eagerly.
See https://github.com/bazelbuild/bazel/issues/5512
RELNOTES: none
PiperOrigin-RevId: 203346678
|
|
|
|
|
|
|
|
|
|
|
| |
Flags passed through clang to linker get -Wl, stripped in the error message
(e.g. -Wl,-no-as-needed will be reported as "ld: unknwon option:
-no-as-needed"). This cl fixes the autodetection to expect the stripped variant.
Fixes #5468.
RELNOTES: None.
PiperOrigin-RevId: 203341563
|
|
|
|
|
|
|
| |
Closes #5424.
Change-Id: I16bb70ffec9d541c56ed0579ae616407073d46f2
PiperOrigin-RevId: 203279412
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/5254#issuecomment-402131986
RELNOTES: None
PiperOrigin-RevId: 203273587
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 203264765
|
|
|
|
|
|
| |
These fields can have very large values that don't fit into int. There's also no added value from storing an int instead of a String.
PiperOrigin-RevId: 203260628
|
|
|
|
|
|
|
|
| |
Signed-off-by: Bin Lu <bin.lu@arm.com>
Closes #5477.
PiperOrigin-RevId: 203241216
|
|
|
|
| |
PiperOrigin-RevId: 203230801
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 203169316
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 203166771
|
|
|
|
| |
PiperOrigin-RevId: 203159437
|
|
|
|
|
|
|
|
|
| |
Now that git_repository returns the commit actually checked out
(and we have means of recording it), support following an active
branch of a git repository.
Change-Id: I6e152c59b694bbf562b345ee88282a8c9bd58e4c
PiperOrigin-RevId: 203110735
|
|
|
|
|
|
|
| |
Fixed https://github.com/bazelbuild/bazel/issues/5495
RELNOTES: None
PiperOrigin-RevId: 202929359
|
|
|
|
|
|
|
|
| |
for well over a year and a half.
RELNOTES[INC]: Loading @bazel_tools//tools/build_defs/repo:git_repositories.bzl no longer works. Load @bazel_tools//tools/build_defs/repo:git.bzl instead.
PiperOrigin-RevId: 202923049
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 202914788
|
|
|
|
|
|
|
|
|
| |
If a program `abort`s, `exit`s, or `exec`s a different program,
destructors won't run. To allow RAII in wrapped_clang, remove all its
`abort` and `exec` calls. `main` is now the single exit point for the
program, and destructors will always run after `main` returns.
PiperOrigin-RevId: 202658759
|
|
|
|
|
|
|
| |
crosstool to agregate all its together.
RELNOTES:none
PiperOrigin-RevId: 202470052
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update all runfiles libraries to have the same
header comment format, including the build rule
to depend on the namespace / header / module to
import
- Fix runfiles_test.cc to include the right files
(recent refactoring commit has split
src/main/cpp/util/path.cc from
file_[platform].cc)
- Change exported variable
_rlocation_isabs_pattern in runfiles.bash to be
upper-case, so it is visibly a variable and not
a function.
See https://github.com/bazelbuild/bazel/issues/4460
Change-Id: I17e18308506ab9f5c9f410ef6bc6b9df912d42a9
Closes #5481.
Change-Id: I17e18308506ab9f5c9f410ef6bc6b9df912d42a9
PiperOrigin-RevId: 202291629
|
|
|
|
|
|
| |
these values when being invoked.
PiperOrigin-RevId: 202173180
|
|
|
|
|
|
|
| |
This was never used. We thought it will be useful, but it's not.
RELNOTES: None.
PiperOrigin-RevId: 202143524
|
|
|
|
|
|
|
| |
As //tools/defaults will be deprecated soon. All usages of //tools/defaults:jdk and //tools/defaults:java_toolchain should be replaced by corresponding targets in //tools/jdk/BUILD package
RELNOTES:none
PiperOrigin-RevId: 202114489
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit bd16ab9454e624a26c53a0f3fb892e20fb1c36e6 documents that these statements are no longer required to achieve prefetching (as of commit cdc99afc1a03ff8fbbbae088d358b7c029e0d232). Given that many `http_archive` calls will need at least a `build_file`, these debugging prints generate an incredible amount of spam in projects with many external archives.
I looked over the rest of the `build_defs/repo` files and none of them have any tracing debug prints, except for `git.bzl` which guards it with an `attr.verbose`. I could rework this to add a verbosity flag if you wish, but it doesn't seem merited for http fetching (unlike git, which is relatively more expensive and can be flaky).
Relates to #2700.
Closes #5446.
PiperOrigin-RevId: 201947174
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 201941079
|
|
|
|
|
|
|
|
| |
#5407
Closes #5450.
PiperOrigin-RevId: 201933209
|
|
|
|
|
|
| |
The android.test classes have been moved from the android.jar in android-28. This CL attempts to add a rule for accessing them.
PiperOrigin-RevId: 201607890
|