diff options
| author |  Carmi Grushko <carmi@google.com> | 2016-02-01 22:27:39 +0000 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2016-02-02 14:57:44 +0000 |
| commit | cb0d65f2095f4998cd8905f1edca714e736a45d3 (patch) | |
| tree | 47c56e81e8f7ff3bcc29b880e383b43e9e723919 /src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java | |
| parent | e01291a1a3d65cd706190c9bf0c8cfc585f38eb7 (diff) | |
Rollback of commit 16444baf21780c4bff00b9736b268e97157e6bc2.
*** Reason for rollback ***
Breaks targets. See []
Manually verified this unbreaks the target mentioned in the bug.
*** Original change description ***
Do not compile source files mentioned in 'hdrs'.
Currently for a library:
cc_library(name='a', hdrs=['a.cc'])
we compile a.cc into a.pic.o and link that into its reverse dependencies.
With this change, a .cc file in hdrs will be treated like a .inc file or
a file in textual_hdrs.
--
MOS_MIGRATED_REVID=113568452
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java index a11b7d7c3e..1dad94f569 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java @@ -668,17 +668,6 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase { } @Test - public void testDoNotCompileSourceFilesInHeaders() throws Exception { - AnalysisMock.get() - .ccSupport() - .setupCrosstool(mockToolsConfig, MockCcSupport.HEADER_PROCESSING_FEATURE_CONFIGURATION); - useConfiguration("--features=parse_headers"); - ConfiguredTarget x = - scratchConfiguredTarget("x", "x", "cc_library(name = 'x', hdrs = ['x.cc'])"); - assertThat(getGeneratingAction(getBinArtifact("_objs/x/x/x.pic.o", x))).isNull(); - } - - @Test public void testIncludePathOrder() throws Exception { scratch.file("foo/BUILD", "cc_library(", |