From cb0d65f2095f4998cd8905f1edca714e736a45d3 Mon Sep 17 00:00:00 2001 From: Carmi Grushko Date: Mon, 1 Feb 2016 22:27:39 +0000 Subject: Rollback of commit 16444baf21780c4bff00b9736b268e97157e6bc2. *** Reason for rollback *** Breaks targets. See [] Manually verified this unbreaks the target mentioned in the bug. *** Original change description *** Do not compile source files mentioned in 'hdrs'. Currently for a library: cc_library(name='a', hdrs=['a.cc']) we compile a.cc into a.pic.o and link that into its reverse dependencies. With this change, a .cc file in hdrs will be treated like a .inc file or a file in textual_hdrs. -- MOS_MIGRATED_REVID=113568452 --- .../build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java') diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java index a11b7d7c3e..1dad94f569 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java @@ -667,17 +667,6 @@ public class CcLibraryConfiguredTargetTest extends BuildViewTestCase { .doesNotContain("src precompiled/missing.a"); } - @Test - public void testDoNotCompileSourceFilesInHeaders() throws Exception { - AnalysisMock.get() - .ccSupport() - .setupCrosstool(mockToolsConfig, MockCcSupport.HEADER_PROCESSING_FEATURE_CONFIGURATION); - useConfiguration("--features=parse_headers"); - ConfiguredTarget x = - scratchConfiguredTarget("x", "x", "cc_library(name = 'x', hdrs = ['x.cc'])"); - assertThat(getGeneratingAction(getBinArtifact("_objs/x/x/x.pic.o", x))).isNull(); - } - @Test public void testIncludePathOrder() throws Exception { scratch.file("foo/BUILD", -- cgit v1.2.3