diff options
| author |  dslomov <dslomov@google.com> | 2017-10-26 14:34:18 +0200 |
|---|---|---|
| committer | Dmitry Lomov <dslomov@google.com> | 2017-10-26 14:37:29 +0200 |
| commit | cf52ebad2f794b0c9c7fb6b77e57937bb76f53da (patch) | |
| tree | 32c8c367448d4001445d652e74625e4ee129bf95 /src/main/java/com | |
| parent | 03d55f3c4af2b37d1177b7faad68e19276f26344 (diff) | |
Automated rollback of commit 0a63dadf4eafbae1730f88644b0c537fb1c16d5c.
*** Reason for rollback ***
This has broken rules_docker: https://ci.bazel.io/blue/organizations/jenkins/Global%2Frules_docker/detail/rules_docker/243/pipeline/
*** Original change description ***
Properly escape GitHub repository download URL for git_repository w/ sha256
Addresses #3661
Closes #3770.
PiperOrigin-RevId: 173525982
Diffstat (limited to 'src/main/java/com')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java index 5c3a0832ba..16aafc7c62 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java @@ -291,8 +291,8 @@ public class GitCloner { String repositoryName = matcher.group(2); String downloadUrl = "https://github.com/" - + UrlEscapers.urlFragmentEscaper() - .escape(user + "/" + repositoryName + "/archive/" + descriptor.ref + ".tar.gz"); + + UrlEscapers.urlPathSegmentEscaper().escape( + user + "/" + repositoryName + "/archive/" + descriptor.ref + ".tar.gz"); try { FileSystemUtils.createDirectoryAndParents(descriptor.directory); Path tgz = downloader.download(ImmutableList.of(new URL(downloadUrl)), uncheckedSha256, |