From cf52ebad2f794b0c9c7fb6b77e57937bb76f53da Mon Sep 17 00:00:00 2001 From: dslomov Date: Thu, 26 Oct 2017 14:34:18 +0200 Subject: Automated rollback of commit 0a63dadf4eafbae1730f88644b0c537fb1c16d5c. *** Reason for rollback *** This has broken rules_docker: https://ci.bazel.io/blue/organizations/jenkins/Global%2Frules_docker/detail/rules_docker/243/pipeline/ *** Original change description *** Properly escape GitHub repository download URL for git_repository w/ sha256 Addresses #3661 Closes #3770. PiperOrigin-RevId: 173525982 --- .../com/google/devtools/build/lib/bazel/repository/GitCloner.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/main/java/com') diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java index 5c3a0832ba..16aafc7c62 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java +++ b/src/main/java/com/google/devtools/build/lib/bazel/repository/GitCloner.java @@ -291,8 +291,8 @@ public class GitCloner { String repositoryName = matcher.group(2); String downloadUrl = "https://github.com/" - + UrlEscapers.urlFragmentEscaper() - .escape(user + "/" + repositoryName + "/archive/" + descriptor.ref + ".tar.gz"); + + UrlEscapers.urlPathSegmentEscaper().escape( + user + "/" + repositoryName + "/archive/" + descriptor.ref + ".tar.gz"); try { FileSystemUtils.createDirectoryAndParents(descriptor.directory); Path tgz = downloader.download(ImmutableList.of(new URL(downloadUrl)), uncheckedSha256, -- cgit v1.2.3