aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib
diff options
context:
space:
mode:
authorGravatar Nathan Harmata <nharmata@google.com>2016-03-18 22:22:40 +0000
committerGravatar Damien Martin-Guillerez <dmarting@google.com>2016-03-21 09:37:10 +0000
commit1a42801a5f2654fb85bdbe446e05b596b3979f38 (patch)
tree0bf783715acafe6b1a3eabc1b220480060779f40 /src/main/java/com/google/devtools/build/lib
parent73ddd4d3bee1e8d2ac6f76bd25c2aa712852c708 (diff)
Remove the WalkableGraphFactory#afterUse hook, which was only called in SkyQueryEnvironment. QueryEnvironmentFactory, recently introduced by unknown commit, is a much more general purpose mechanism.
-- MOS_MIGRATED_REVID=117590252
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib')
-rw-r--r--src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java6
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java5
2 files changed, 2 insertions, 9 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
index 3e96693be4..a984edf3fe 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
@@ -105,7 +105,7 @@ public class SkyQueryEnvironment extends AbstractBlazeQueryEnvironment<Target> {
// TODO(janakr): Unify with RecursivePackageProviderBackedTargetPatternResolver's constant.
private static final int BATCH_CALLBACK_SIZE = 10000;
- private WalkableGraph graph;
+ protected WalkableGraph graph;
private ImmutableList<TargetPatternKey> universeTargetPatternKeys;
@@ -220,9 +220,7 @@ public class SkyQueryEnvironment extends AbstractBlazeQueryEnvironment<Target> {
// errors here.
eventHandler.resetErrors();
init();
- QueryEvalResult result = super.evaluateQuery(expr, callback);
- graphFactory.afterUse(graph);
- return result;
+ return super.evaluateQuery(expr, callback);
}
private Map<Target, Collection<Target>> makeTargetsMap(Map<SkyKey, Iterable<SkyKey>> input) {
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
index d37c582440..7bcb2e3ac0 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
@@ -135,7 +135,6 @@ import com.google.devtools.build.skyframe.SkyFunction;
import com.google.devtools.build.skyframe.SkyFunctionName;
import com.google.devtools.build.skyframe.SkyKey;
import com.google.devtools.build.skyframe.SkyValue;
-import com.google.devtools.build.skyframe.WalkableGraph;
import com.google.devtools.build.skyframe.WalkableGraph.WalkableGraphFactory;
import com.google.devtools.common.options.OptionsClassProvider;
@@ -1451,10 +1450,6 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
return evaluationResult;
}
- @Override
- public void afterUse(WalkableGraph walkableGraph) {
- }
-
/**
* Get metadata related to the prepareAndGet() lookup. Resulting data is specific to the
* underlying evaluation implementation.