From 1a42801a5f2654fb85bdbe446e05b596b3979f38 Mon Sep 17 00:00:00 2001
From: Nathan Harmata <nharmata@google.com>
Date: Fri, 18 Mar 2016 22:22:40 +0000
Subject: Remove the WalkableGraphFactory#afterUse hook, which was only called
 in SkyQueryEnvironment. QueryEnvironmentFactory, recently introduced by
 unknown commit, is a much more general purpose mechanism.

--
MOS_MIGRATED_REVID=117590252
---
 .../com/google/devtools/build/lib/query2/SkyQueryEnvironment.java   | 6 ++----
 .../com/google/devtools/build/lib/skyframe/SkyframeExecutor.java    | 5 -----
 2 files changed, 2 insertions(+), 9 deletions(-)

(limited to 'src/main/java/com/google/devtools/build/lib')

diff --git a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
index 3e96693be4..a984edf3fe 100644
--- a/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
+++ b/src/main/java/com/google/devtools/build/lib/query2/SkyQueryEnvironment.java
@@ -105,7 +105,7 @@ public class SkyQueryEnvironment extends AbstractBlazeQueryEnvironment<Target> {
   // TODO(janakr): Unify with RecursivePackageProviderBackedTargetPatternResolver's constant.
   private static final int BATCH_CALLBACK_SIZE = 10000;
 
-  private WalkableGraph graph;
+  protected WalkableGraph graph;
 
   private ImmutableList<TargetPatternKey> universeTargetPatternKeys;
 
@@ -220,9 +220,7 @@ public class SkyQueryEnvironment extends AbstractBlazeQueryEnvironment<Target> {
     // errors here.
     eventHandler.resetErrors();
     init();
-    QueryEvalResult result = super.evaluateQuery(expr, callback);
-    graphFactory.afterUse(graph);
-    return result;
+    return super.evaluateQuery(expr, callback);
   }
 
   private Map<Target, Collection<Target>> makeTargetsMap(Map<SkyKey, Iterable<SkyKey>> input) {
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
index d37c582440..7bcb2e3ac0 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java
@@ -135,7 +135,6 @@ import com.google.devtools.build.skyframe.SkyFunction;
 import com.google.devtools.build.skyframe.SkyFunctionName;
 import com.google.devtools.build.skyframe.SkyKey;
 import com.google.devtools.build.skyframe.SkyValue;
-import com.google.devtools.build.skyframe.WalkableGraph;
 import com.google.devtools.build.skyframe.WalkableGraph.WalkableGraphFactory;
 import com.google.devtools.common.options.OptionsClassProvider;
 
@@ -1451,10 +1450,6 @@ public abstract class SkyframeExecutor implements WalkableGraphFactory {
     return evaluationResult;
   }
 
-  @Override
-  public void afterUse(WalkableGraph walkableGraph) {
-  }
-
   /**
    * Get metadata related to the prepareAndGet() lookup. Resulting data is specific to the
    * underlying evaluation implementation.
-- 
cgit v1.2.3