diff options
| author |  cparsons <cparsons@google.com> | 2017-09-18 23:52:04 +0200 |
|---|---|---|
| committer |  László Csomor <laszlocsomor@google.com> | 2017-09-19 09:32:37 +0200 |
| commit | 9055ff26ebccd457ae5d2492e4fa8d4ab2f67664 (patch) | |
| tree | 8f9ffc9c5b652a7eb683262232414c463de78dfc /src/main/java/com/google/devtools/build/lib/syntax | |
| parent | 7744b86e9c7950da62e87bfff3967c67477a1620 (diff) | |
use toList.contains for depset containsKey instead of toSet
This should be a slight performance improvement on the previous implementation, as NestedSet.toSet() calls toList() and then throws the contents into a set
RELNOTES: None.
PiperOrigin-RevId: 169150743
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/syntax')
| -rw-r--r-- | src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java index dc143c31be..2fe608824b 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java @@ -334,6 +334,6 @@ public final class SkylarkNestedSet implements SkylarkValue, SkylarkQueryable { @Override public final boolean containsKey(Object key, Location loc) throws EvalException { - return (set.toSet().contains(key)); + return (set.toList().contains(key)); } } |