From 9055ff26ebccd457ae5d2492e4fa8d4ab2f67664 Mon Sep 17 00:00:00 2001 From: cparsons Date: Mon, 18 Sep 2017 23:52:04 +0200 Subject: use toList.contains for depset containsKey instead of toSet This should be a slight performance improvement on the previous implementation, as NestedSet.toSet() calls toList() and then throws the contents into a set RELNOTES: None. PiperOrigin-RevId: 169150743 --- .../java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/syntax') diff --git a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java index dc143c31be..2fe608824b 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/SkylarkNestedSet.java @@ -334,6 +334,6 @@ public final class SkylarkNestedSet implements SkylarkValue, SkylarkQueryable { @Override public final boolean containsKey(Object key, Location loc) throws EvalException { - return (set.toSet().contains(key)); + return (set.toList().contains(key)); } } -- cgit v1.2.3