Use static creation method for SkyKey. This allows interning SkyKeys as they are created, as opposed to when they are requested from the ParallelEvaluator. That delay can lead to large memory spikes and churn.

--
MOS_MIGRATED_REVID=116224565

1 files changed, 9 insertions, 2 deletions

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
index f319e77fb2..0e43191dbc 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
@@ -125,8 +125,15 @@ public final class TargetPatternPhaseValue implements SkyValue {
   public static SkyKey key(ImmutableList<String> targetPatterns, String offset,
       boolean compileOneDependency, boolean buildTestsOnly, boolean determineTests,
       @Nullable TestFilter testFilter) {
-    return new SkyKey(SkyFunctions.TARGET_PATTERN_PHASE, new TargetPatternList(
-        targetPatterns, offset, compileOneDependency, buildTestsOnly, determineTests, testFilter));
+    return SkyKey.create(
+        SkyFunctions.TARGET_PATTERN_PHASE,
+        new TargetPatternList(
+            targetPatterns,
+            offset,
+            compileOneDependency,
+            buildTestsOnly,
+            determineTests,
+            testFilter));
   }
 
   /**