From f745e99db7632cfb2145b6926f961e85f9084bc5 Mon Sep 17 00:00:00 2001 From: Janak Ramakrishnan Date: Thu, 3 Mar 2016 08:08:50 +0000 Subject: Use static creation method for SkyKey. This allows interning SkyKeys as they are created, as opposed to when they are requested from the ParallelEvaluator. That delay can lead to large memory spikes and churn. -- MOS_MIGRATED_REVID=116224565 --- .../devtools/build/lib/skyframe/TargetPatternPhaseValue.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java') diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java index f319e77fb2..0e43191dbc 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java @@ -125,8 +125,15 @@ public final class TargetPatternPhaseValue implements SkyValue { public static SkyKey key(ImmutableList targetPatterns, String offset, boolean compileOneDependency, boolean buildTestsOnly, boolean determineTests, @Nullable TestFilter testFilter) { - return new SkyKey(SkyFunctions.TARGET_PATTERN_PHASE, new TargetPatternList( - targetPatterns, offset, compileOneDependency, buildTestsOnly, determineTests, testFilter)); + return SkyKey.create( + SkyFunctions.TARGET_PATTERN_PHASE, + new TargetPatternList( + targetPatterns, + offset, + compileOneDependency, + buildTestsOnly, + determineTests, + testFilter)); } /** -- cgit v1.2.3