aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
diff options
context:
space:
mode:
authorGravatar Ulf Adams <ulfjack@google.com>2016-02-10 12:07:44 +0000
committerGravatar Dmitry Lomov <dslomov@google.com>2016-02-10 16:34:41 +0000
commitde3e9d5c1feec29149bac6ac0e1d9f3c65e00332 (patch)
tree692989a6ee5afee839194cf556984f1d49296854 /src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
parent4224fc020c94fb363cad0c0b5dfcc225cd8e2c1a (diff)
Fix SkyframeLoadingPhaseRunner posting of EventBus events.
The TargetParsingCompleteEvent was posting the post-expansion targets, and the LoadingPhaseCompleteEvent was missing the test-suite targets. -- MOS_MIGRATED_REVID=114312273
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java18
1 files changed, 17 insertions, 1 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
index becc737239..4c864db3d8 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java
@@ -52,15 +52,23 @@ public final class TargetPatternPhaseValue implements SkyValue {
private final ImmutableSet<Target> filteredTargets;
private final ImmutableSet<Target> testFilteredTargets;
+ // These two fields are only for the purposes of generating the TargetParsingCompleteEvent.
+ // TODO(ulfjack): Support EventBus event posting in Skyframe, and remove this code again.
+ private final ImmutableSet<Target> originalTargets;
+ private final ImmutableSet<Target> testSuiteTargets;
+
TargetPatternPhaseValue(ImmutableSet<Target> targets, @Nullable ImmutableSet<Target> testsToRun,
boolean hasError, boolean hasPostExpansionError, ImmutableSet<Target> filteredTargets,
- ImmutableSet<Target> testFilteredTargets) {
+ ImmutableSet<Target> testFilteredTargets, ImmutableSet<Target> originalTargets,
+ ImmutableSet<Target> testSuiteTargets) {
this.targets = Preconditions.checkNotNull(targets);
this.testsToRun = testsToRun;
this.hasError = hasError;
this.hasPostExpansionError = hasPostExpansionError;
this.filteredTargets = Preconditions.checkNotNull(filteredTargets);
this.testFilteredTargets = Preconditions.checkNotNull(testFilteredTargets);
+ this.originalTargets = Preconditions.checkNotNull(originalTargets);
+ this.testSuiteTargets = Preconditions.checkNotNull(testSuiteTargets);
}
public ImmutableSet<Target> getTargets() {
@@ -88,6 +96,14 @@ public final class TargetPatternPhaseValue implements SkyValue {
return testFilteredTargets;
}
+ public ImmutableSet<Target> getOriginalTargets() {
+ return originalTargets;
+ }
+
+ public ImmutableSet<Target> getTestSuiteTargets() {
+ return testSuiteTargets;
+ }
+
public LoadingResult toLoadingResult() {
return new LoadingResult(hasError(), hasPostExpansionError(), getTargets(), getTestsToRun(),
ImmutableMap.<PackageIdentifier, Path>of());