From de3e9d5c1feec29149bac6ac0e1d9f3c65e00332 Mon Sep 17 00:00:00 2001 From: Ulf Adams Date: Wed, 10 Feb 2016 12:07:44 +0000 Subject: Fix SkyframeLoadingPhaseRunner posting of EventBus events. The TargetParsingCompleteEvent was posting the post-expansion targets, and the LoadingPhaseCompleteEvent was missing the test-suite targets. -- MOS_MIGRATED_REVID=114312273 --- .../build/lib/skyframe/TargetPatternPhaseValue.java | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java') diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java index becc737239..4c864db3d8 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/TargetPatternPhaseValue.java @@ -52,15 +52,23 @@ public final class TargetPatternPhaseValue implements SkyValue { private final ImmutableSet filteredTargets; private final ImmutableSet testFilteredTargets; + // These two fields are only for the purposes of generating the TargetParsingCompleteEvent. + // TODO(ulfjack): Support EventBus event posting in Skyframe, and remove this code again. + private final ImmutableSet originalTargets; + private final ImmutableSet testSuiteTargets; + TargetPatternPhaseValue(ImmutableSet targets, @Nullable ImmutableSet testsToRun, boolean hasError, boolean hasPostExpansionError, ImmutableSet filteredTargets, - ImmutableSet testFilteredTargets) { + ImmutableSet testFilteredTargets, ImmutableSet originalTargets, + ImmutableSet testSuiteTargets) { this.targets = Preconditions.checkNotNull(targets); this.testsToRun = testsToRun; this.hasError = hasError; this.hasPostExpansionError = hasPostExpansionError; this.filteredTargets = Preconditions.checkNotNull(filteredTargets); this.testFilteredTargets = Preconditions.checkNotNull(testFilteredTargets); + this.originalTargets = Preconditions.checkNotNull(originalTargets); + this.testSuiteTargets = Preconditions.checkNotNull(testSuiteTargets); } public ImmutableSet getTargets() { @@ -88,6 +96,14 @@ public final class TargetPatternPhaseValue implements SkyValue { return testFilteredTargets; } + public ImmutableSet getOriginalTargets() { + return originalTargets; + } + + public ImmutableSet getTestSuiteTargets() { + return testSuiteTargets; + } + public LoadingResult toLoadingResult() { return new LoadingResult(hasError(), hasPostExpansionError(), getTargets(), getTestsToRun(), ImmutableMap.of()); -- cgit v1.2.3