aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
diff options
context:
space:
mode:
authorGravatar Michael Staib <mstaib@google.com>2016-09-16 21:06:40 +0000
committerGravatar Laszlo Csomor <laszlocsomor@google.com>2016-09-19 07:35:12 +0000
commit2707a886681e14fc22edca4c6c4bccca12018083 (patch)
tree9cd4e2e596c26e685f474c7fb6a4fcf9291a91e6 /src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
parent8618b9d67d20a737908113fa89357ac321a9669b (diff)
Enable aspect invocations to be matched by output filters.
Currently aspects have no tag, i.e., they don't get checked against output filters at all. This changes aspects to have a tag of the same form as the rule they are attached to (i.e., the label of the target). Since the default output filters match on ^//package[:/], this should cover most uses of the output filter, while still allowing for finer control for those who crave it. -- MOS_MIGRATED_REVID=133425215
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
index 4035242c4e..ba84c5b7fb 100644
--- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
+++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java
@@ -376,10 +376,10 @@ public final class AspectFunction implements SkyFunction {
transitivePackages.build());
}
- @Nullable
@Override
public String extractTag(SkyKey skyKey) {
- return null;
+ AspectKey aspectKey = (AspectKey) skyKey.argument();
+ return Label.print(aspectKey.getLabel());
}
/**