From 2707a886681e14fc22edca4c6c4bccca12018083 Mon Sep 17 00:00:00 2001 From: Michael Staib Date: Fri, 16 Sep 2016 21:06:40 +0000 Subject: Enable aspect invocations to be matched by output filters. Currently aspects have no tag, i.e., they don't get checked against output filters at all. This changes aspects to have a tag of the same form as the rule they are attached to (i.e., the label of the target). Since the default output filters match on ^//package[:/], this should cover most uses of the output filter, while still allowing for finer control for those who crave it. -- MOS_MIGRATED_REVID=133425215 --- .../java/com/google/devtools/build/lib/skyframe/AspectFunction.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java') diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java index 4035242c4e..ba84c5b7fb 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java +++ b/src/main/java/com/google/devtools/build/lib/skyframe/AspectFunction.java @@ -376,10 +376,10 @@ public final class AspectFunction implements SkyFunction { transitivePackages.build()); } - @Nullable @Override public String extractTag(SkyKey skyKey) { - return null; + AspectKey aspectKey = (AspectKey) skyKey.argument(); + return Label.print(aspectKey.getLabel()); } /** -- cgit v1.2.3