aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java
diff options
context:
space:
mode:
authorGravatar ajmichael <ajmichael@google.com>2017-11-15 14:10:00 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2017-11-15 14:11:59 -0800
commitdc7399af31d53d9b94b844baaee3e7c918cf10d4 (patch)
treee9a244ba4cdb442d2cf0d5c2fa1e9461649eec89 /src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java
parentee8c41999ca2b5549dfaec9afcd83b06ff198d1c (diff)
Stop adding data deps to AndroidDeployInfo proto.
This is not used by ASwB, and it also doesn't make sense to live in AndroidBinary since android_binary does nothing with it's data deps and they should be removed (b/69371443). RELNOTES: None PiperOrigin-RevId: 175877850
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java')
-rw-r--r--src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java19
1 files changed, 5 insertions, 14 deletions
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java
index 91d6fcb21c..8fb0b4cc2c 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java
@@ -42,14 +42,12 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction {
private static Iterable<Artifact> makeInputs(
Artifact mergedManifest,
Iterable<Artifact> additionalMergedManifests,
- Iterable<Artifact> apksToDeploy,
- Iterable<Artifact> dataDeps) {
+ Iterable<Artifact> apksToDeploy) {
return ImmutableList.<Artifact>builder()
.add(mergedManifest)
.addAll(additionalMergedManifests)
.addAll(apksToDeploy)
- .addAll(dataDeps)
.build();
}
@@ -58,21 +56,18 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction {
private final Artifact mergedManifest;
private final ImmutableList<Artifact> additionalMergedManifests;
private final ImmutableList<Artifact> apksToDeploy;
- private final ImmutableList<Artifact> dataDeps;
AndroidDeployInfoAction(
ActionOwner owner,
Artifact outputFile,
Artifact mergedManifest,
ImmutableList<Artifact> additionalMergedManifests,
- ImmutableList<Artifact> apksToDeploy,
- ImmutableList<Artifact> dataDeps) {
- super(owner, makeInputs(mergedManifest, additionalMergedManifests, apksToDeploy, dataDeps),
+ ImmutableList<Artifact> apksToDeploy) {
+ super(owner, makeInputs(mergedManifest, additionalMergedManifests, apksToDeploy),
outputFile, false);
this.mergedManifest = mergedManifest;
this.additionalMergedManifests = additionalMergedManifests;
this.apksToDeploy = apksToDeploy;
- this.dataDeps = dataDeps;
}
private ByteString getByteString() {
@@ -85,9 +80,6 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction {
for (Artifact apk : apksToDeploy) {
builder.addApksToDeploy(makeArtifactProto(apk));
}
- for (Artifact dataDep : dataDeps) {
- builder.addDataToDeploy(makeArtifactProto(dataDep));
- }
return builder.build().toByteString();
}
@@ -96,10 +88,9 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction {
Artifact deployInfo,
Artifact mergedManifest,
ImmutableList<Artifact> additionalMergedManifests,
- ImmutableList<Artifact> apksToDeploy,
- ImmutableList<Artifact> dataDeps) {
+ ImmutableList<Artifact> apksToDeploy) {
Action action = new AndroidDeployInfoAction(ruleContext.getActionOwner(),
- deployInfo, mergedManifest, additionalMergedManifests, apksToDeploy, dataDeps);
+ deployInfo, mergedManifest, additionalMergedManifests, apksToDeploy);
ruleContext.registerAction(action);
}