From dc7399af31d53d9b94b844baaee3e7c918cf10d4 Mon Sep 17 00:00:00 2001 From: ajmichael Date: Wed, 15 Nov 2017 14:10:00 -0800 Subject: Stop adding data deps to AndroidDeployInfo proto. This is not used by ASwB, and it also doesn't make sense to live in AndroidBinary since android_binary does nothing with it's data deps and they should be removed (b/69371443). RELNOTES: None PiperOrigin-RevId: 175877850 --- .../lib/rules/android/AndroidDeployInfoAction.java | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) (limited to 'src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java') diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java index 91d6fcb21c..8fb0b4cc2c 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java +++ b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidDeployInfoAction.java @@ -42,14 +42,12 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction { private static Iterable makeInputs( Artifact mergedManifest, Iterable additionalMergedManifests, - Iterable apksToDeploy, - Iterable dataDeps) { + Iterable apksToDeploy) { return ImmutableList.builder() .add(mergedManifest) .addAll(additionalMergedManifests) .addAll(apksToDeploy) - .addAll(dataDeps) .build(); } @@ -58,21 +56,18 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction { private final Artifact mergedManifest; private final ImmutableList additionalMergedManifests; private final ImmutableList apksToDeploy; - private final ImmutableList dataDeps; AndroidDeployInfoAction( ActionOwner owner, Artifact outputFile, Artifact mergedManifest, ImmutableList additionalMergedManifests, - ImmutableList apksToDeploy, - ImmutableList dataDeps) { - super(owner, makeInputs(mergedManifest, additionalMergedManifests, apksToDeploy, dataDeps), + ImmutableList apksToDeploy) { + super(owner, makeInputs(mergedManifest, additionalMergedManifests, apksToDeploy), outputFile, false); this.mergedManifest = mergedManifest; this.additionalMergedManifests = additionalMergedManifests; this.apksToDeploy = apksToDeploy; - this.dataDeps = dataDeps; } private ByteString getByteString() { @@ -85,9 +80,6 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction { for (Artifact apk : apksToDeploy) { builder.addApksToDeploy(makeArtifactProto(apk)); } - for (Artifact dataDep : dataDeps) { - builder.addDataToDeploy(makeArtifactProto(dataDep)); - } return builder.build().toByteString(); } @@ -96,10 +88,9 @@ public final class AndroidDeployInfoAction extends AbstractFileWriteAction { Artifact deployInfo, Artifact mergedManifest, ImmutableList additionalMergedManifests, - ImmutableList apksToDeploy, - ImmutableList dataDeps) { + ImmutableList apksToDeploy) { Action action = new AndroidDeployInfoAction(ruleContext.getActionOwner(), - deployInfo, mergedManifest, additionalMergedManifests, apksToDeploy, dataDeps); + deployInfo, mergedManifest, additionalMergedManifests, apksToDeploy); ruleContext.registerAction(action); } -- cgit v1.2.3