diff options
author | 2018-07-30 10:48:31 -0700 | |
---|---|---|
committer | 2018-07-30 10:49:57 -0700 | |
commit | 7dbc5e03f1ced0e3a67e42e0f182579865d26af7 (patch) | |
tree | c181d7456e951a103cccf57b301f49ee7de489ff /src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java | |
parent | f59022b9b19c0086adc9795fd8659f8bc988f747 (diff) |
[Skylark] Use POJOs instead of dynamic proxies.
Java uses dynamically generated proxy classes to access annotation properties
and their methods are ~7X slower than plain getters. According to async-profiler
50%+ of `convertArgumentList` method time is spent in dynamic proxy methods, so
optimizing their performance makes sense.
This also makes the model less anemic, since POJOs can actually provide business
methods.
Closes #5666.
PiperOrigin-RevId: 206608812
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java')
0 files changed, 0 insertions, 0 deletions