diff options
| author |  nharmata <nharmata@google.com> | 2018-07-30 10:37:48 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-07-30 10:39:24 -0700 |
| commit | f59022b9b19c0086adc9795fd8659f8bc988f747 (patch) | |
| tree | 1ce204ed531957134361a829d592c08a749c1f36 /src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java | |
| parent | 825b6105b146046045860dca91660cd45cc854ab (diff) | |
Some code cleanups and improvements around the various DTC visitor implementations in SkyQuery:
(1) Get rid of the 'errorReporter' param used in the two unbounded 'deps' implementations. In practice, this callback is always used right alongside the normal query callback. So we can re-implement it as a single, composite callback.
(2) Revert the recent change to processResultsAndReturnTargets (and restore the old method name). It general, it's a bad idea to return Targets outside that method, because it means we aren't respecting the MultisetSemaphore<PackageIdentifier>. Along with (1), this fixes a real issue where DepsUnboundedVisitor#processPartialResults was using Targets (and thus keeping their Packages live in memory) outside of the package semaphore.
RELNOTES: None
PiperOrigin-RevId: 206606747
Diffstat (limited to 'src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java')
0 files changed, 0 insertions, 0 deletions