diff options
| author |  Taras Tsugrii <ttsugrii@fb.com> | 2018-02-13 09:12:12 -0800 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-02-13 09:14:16 -0800 |
| commit | a3339c8ca2e824757afe698f591770f4232af530 (patch) | |
| tree | 89c3494b7b8ec2156c8be4144adfd70cbf1333c5 /scripts | |
| parent | 391d73d15f19ed22bf2cb343aaca9dd4fe3b7285 (diff) | |
[Skylint] Do not crash ControlFlowChecker on nested functions.
ControlFlowChecker has a precondition check that assumes nested functions do not occur. While this assumption is reasonable for a valid Skylark syntax, linter can actually be invoked on malformed files and users would get a stack trace instead of a human-readable linter error.
Alternative and possibly a better strategy would to not run CFChecker in case parse errors are detected.
fixes #4511
Closes #4512.
PiperOrigin-RevId: 185538897
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/ij.bazelproject | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/ij.bazelproject b/scripts/ij.bazelproject index 4cdd223ef1..7b6a97946b 100644 --- a/scripts/ij.bazelproject +++ b/scripts/ij.bazelproject @@ -19,3 +19,4 @@ targets: //src/java_tools/singlejar:SingleJar //src/test/... //src/tools/remote/... + //src/tools/skylark/... |