From a3339c8ca2e824757afe698f591770f4232af530 Mon Sep 17 00:00:00 2001 From: Taras Tsugrii Date: Tue, 13 Feb 2018 09:12:12 -0800 Subject: [Skylint] Do not crash ControlFlowChecker on nested functions. ControlFlowChecker has a precondition check that assumes nested functions do not occur. While this assumption is reasonable for a valid Skylark syntax, linter can actually be invoked on malformed files and users would get a stack trace instead of a human-readable linter error. Alternative and possibly a better strategy would to not run CFChecker in case parse errors are detected. fixes #4511 Closes #4512. PiperOrigin-RevId: 185538897 --- scripts/ij.bazelproject | 1 + 1 file changed, 1 insertion(+) (limited to 'scripts') diff --git a/scripts/ij.bazelproject b/scripts/ij.bazelproject index 4cdd223ef1..7b6a97946b 100644 --- a/scripts/ij.bazelproject +++ b/scripts/ij.bazelproject @@ -19,3 +19,4 @@ targets: //src/java_tools/singlejar:SingleJar //src/test/... //src/tools/remote/... + //src/tools/skylark/... -- cgit v1.2.3