aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc
diff options
context:
space:
mode:
authorGravatar Mark Heffernan <meheff@google.com>2017-06-13 13:22:11 -0700
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2017-06-13 13:26:26 -0700
commit8eb015561b3a2f2e27f01617fd14d5a4f4b215bd (patch)
tree544e5d3e25ad131823b51b4a4b72a1e702f654bf /tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc
parentaf0683d3bddaf82363c2e0e75966863bd4bc2bac (diff)
[XLA] Sort vector of HloBuffer::Id values before uniqifying.
Fix a latent bug in HLO dataflow analysis in the method Phi. When uniquifying a vector of HloBuffer:Id values, first std::sort it before calling std::erase and std::unique. PiperOrigin-RevId: 158888326
Diffstat (limited to 'tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc')
-rw-r--r--tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc b/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc
index 61abc322f5..d1b8725644 100644
--- a/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc
+++ b/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc
@@ -409,6 +409,7 @@ InstructionValueSet HloDataflowAnalysis::Phi(
input_value_ids.push_back(value_id);
}
}
+ std::sort(input_value_ids.begin(), input_value_ids.end());
input_value_ids.erase(
std::unique(input_value_ids.begin(), input_value_ids.end()),
input_value_ids.end());