diff options
author | Mark Heffernan <meheff@google.com> | 2017-06-13 13:22:11 -0700 |
---|---|---|
committer | TensorFlower Gardener <gardener@tensorflow.org> | 2017-06-13 13:26:26 -0700 |
commit | 8eb015561b3a2f2e27f01617fd14d5a4f4b215bd (patch) | |
tree | 544e5d3e25ad131823b51b4a4b72a1e702f654bf | |
parent | af0683d3bddaf82363c2e0e75966863bd4bc2bac (diff) |
[XLA] Sort vector of HloBuffer::Id values before uniqifying.
Fix a latent bug in HLO dataflow analysis in the method Phi. When uniquifying
a vector of HloBuffer:Id values, first std::sort it before calling std::erase
and std::unique.
PiperOrigin-RevId: 158888326
-rw-r--r-- | tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc b/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc index 61abc322f5..d1b8725644 100644 --- a/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc +++ b/tensorflow/compiler/xla/service/hlo_dataflow_analysis.cc @@ -409,6 +409,7 @@ InstructionValueSet HloDataflowAnalysis::Phi( input_value_ids.push_back(value_id); } } + std::sort(input_value_ids.begin(), input_value_ids.end()); input_value_ids.erase( std::unique(input_value_ids.begin(), input_value_ids.end()), input_value_ids.end()); |