diff options
| author |  Mark Heffernan <meheff@google.com> | 2018-09-12 13:19:18 -0700 |
|---|---|---|
| committer |  TensorFlower Gardener <gardener@tensorflow.org> | 2018-09-12 13:23:12 -0700 |
| commit | 5d1de24583aabeb2cb883ab197ae2b8d5446c565 (patch) | |
| tree | 8e1227ad724f3da4413ce51ef4d39925b7ff226a /tensorflow/compiler/xla/service/hlo_computation.cc | |
| parent | 3fb474713b27552eba1943bb4172e54ad2dd13bc (diff) | |
Preserve unique ids when serializing/deserializing HLO protos.
Re-assigning unique IDs broke serialization of HloSchedule, and keeping IDs stable improves the fidelity of the proto serialization. This change requires that instructions in HLO module protos have valid, module-scope-unique ids so change the XLA builder to hand out module-scope-unique ids. Previously, instruction ids were only unique in the computation scope.
PiperOrigin-RevId: 212692339
Diffstat (limited to 'tensorflow/compiler/xla/service/hlo_computation.cc')
| -rw-r--r-- | tensorflow/compiler/xla/service/hlo_computation.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_computation.cc b/tensorflow/compiler/xla/service/hlo_computation.cc index 233d2199d1..8c6903d766 100644 --- a/tensorflow/compiler/xla/service/hlo_computation.cc +++ b/tensorflow/compiler/xla/service/hlo_computation.cc @@ -562,9 +562,11 @@ HloComputation::CreateFromProto( return to_proto_id[a.get()] < to_proto_id[b.get()]; }); - return absl::WrapUnique(new HloComputation(proto.name(), parameter_count, - &instructions, root, - /*fusion_instruction=*/nullptr)); + auto computation = absl::WrapUnique( + new HloComputation(proto.name(), parameter_count, &instructions, root, + /*fusion_instruction=*/nullptr)); + computation->unique_id_ = proto.id(); + return std::move(computation); } void HloComputation::FuseInstructionsInto( |