| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992
Review URL: https://codereview.chromium.org/842323003
|
|
|
|
|
|
|
| |
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/804023005
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/822423004
|
|
|
|
|
|
| |
BUG=skia:3304
Review URL: https://codereview.chromium.org/807143006
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/842323003/)
Reason for revert:
nanobench woes
Original issue's description:
> Switch to a more complete method of filtering hoisted layers
>
> Committed: https://skia.googlesource.com/skia/+/74668a8e818fd891a08c4966cc5973b04c1ad992
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/851773002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/842323003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code requires fewer macros to use it (just one), has less code in macro
definitions, and has simpler synchronization code (just atomic ints, no SkOnce,
no SkMutex, etc.)
A minor downside, we lose indentation and reverse-ordering in the final report:
Leaked SkRefCntBase: 7
Leaked SkFontMgr: 1
Leaked SkWeakRefCnt: 1
Leaked SkTypeface: 1
Leaked SkFlattenable: 3
Leaked SkXfermode: 3
Leaked SkPathRef: 1
Leaked SkPixelRef: 1
Leaked SkMallocPixelRef: 1
becomes
Leaked SkXfermode: 3
Leaked SkMallocPixelRef: 1
Leaked SkPixelRef: 1
Leaked SkPathRef: 1
Leaked SkFlattenable: 3
Leaked SkTypeface: 1
Leaked SkWeakRefCnt: 1
Leaked SkFontMgr: 1
Leaked SkRefCntBase: 7
This is motivated by wanting to land https://codereview.chromium.org/806473006/,
which makes sure all static use of SkOnce are in global scope. The current
implementation of SkInstCnt uses them in function scope, which isn't safe.
BUG=skia:
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/841263004
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.
for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end
BUG=skia:
Review URL: https://codereview.chromium.org/806653007
|
|
|
|
|
|
| |
The PlausiblyAtlasable check was preventing large layers from ever being hoisted in the FindLayersToHoist path.
Review URL: https://codereview.chromium.org/844613002
|
|
|
|
|
|
| |
Committed: https://skia.googlesource.com/skia/+/152f524fd325b7776b01f84afbfe2fa071648a05
Review URL: https://codereview.chromium.org/833943002
|
|
|
|
|
|
| |
BUG=skia:3103
Review URL: https://codereview.chromium.org/834103004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #6 id:100001 of https://codereview.chromium.org/833943002/)
Reason for revert:
Still more Chromium clean up to do
Original issue's description:
> It is dangerous to ignore SkRect::intersect's return value
>
> Committed: https://skia.googlesource.com/skia/+/152f524fd325b7776b01f84afbfe2fa071648a05
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/825983005
|
|
|
|
| |
Review URL: https://codereview.chromium.org/833943002
|
|
|
|
|
|
| |
Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c
Review URL: https://codereview.chromium.org/829983003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#2 id:20001 of https://codereview.chromium.org/829983003/)
Reason for revert:
speculative revert to unblock DEPS roll
Original issue's description:
> Rename SkDrawPictureCallback to SkPicture::AbortCallback
>
> Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c
TBR=reed@google.com,robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/824013004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/829983003
|
|
|
|
|
|
| |
kkinnunen@ has been seeing compiler warnings on GrScratchKey::GenerateResourceType (https://codereview.chromium.org/833913002/ - Cast the scratch resource key in order to fix a warning)(presumably due to the unsigned/signed comparison in kInvalidResourceType == type). This CL limits the returned id to its effective range to, hopefully, clarify the whole int32_t -> uint32_t conversion & wrapping problem.
Review URL: https://codereview.chromium.org/827923006
|
|
|
|
|
|
|
|
|
|
| |
This is achieved but chopping up conics into quads.
With this change conics should be ready to be used on the gpu side of things
BUG=skia:3258
Review URL: https://codereview.chromium.org/825443002
|
|
|
|
|
|
|
| |
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/801493003
|
|
|
|
|
|
| |
BUG=skia:2889
Review URL: https://codereview.chromium.org/815833004
|
|
|
|
|
|
|
|
|
|
| |
The N6 has some driver bug that is required us to give some value to gl_FragColor.
The disabledColorWriteXP should not need to set any value in its shader, but to fix
this crash this cl sets gl_FragColor to 0.
BUG=445377
Review URL: https://codereview.chromium.org/823053003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/827973002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/815553003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/821243003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/818233002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/816103003
|
|
|
|
|
|
|
| |
NOTREECHECKS=True
BUG=skia:
Review URL: https://codereview.chromium.org/817853002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/824753002
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes one of the bugs discovered when rrects/ovals were changed to conics.
Specifcally the case where hairlines were being drawing randomly all of the place.
There is still a bug in a lot of our rrect/oval draws/clipping so the legacy flags
are still needed.
BUG=skia:3258
Review URL: https://codereview.chromium.org/822733003
|
|
|
|
|
|
| |
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/817373002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/814273003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/791823003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/787233003
|
|
|
|
|
|
|
|
| |
Make GrGLGpu::onWrapBackendRenderTarget update "is wrapped" flag.
Otherwise accessing the flag results in uninitialized read, possibly
resulting in wrapped render target ending up in the cache.
Review URL: https://codereview.chromium.org/818023002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/820523002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/820683002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/793013003
|
|
|
|
|
|
|
|
|
|
|
| |
The Invariant output holds information about final post blended color and other
general information like will it blend with dst. Having this new struct allowed
me to also remove some functions that were previously querying subsets of the
invariant output.
BUG=skia:
Review URL: https://codereview.chromium.org/814933002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/811373002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/812063002
|
|
|
|
|
|
|
| |
BUG=skia:3260
R=egdaniel@google.com
Review URL: https://codereview.chromium.org/813653003
|
|
|
|
|
|
|
|
|
| |
Added in check for sized internal format.
Made choice between RED and ALPHA orthogonal to HALF_FLOAT and
HALF_FLOAT_OES.
Enabled rendertarget support on ES 2.0.
Review URL: https://codereview.chromium.org/805033002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes errors like:
../../src/gpu/GrGeometryProcessor.h:172:25: error: 'name' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual const char* name() const = 0;
^
../../include/gpu/GrProcessor.h:66:25: note: overridden virtual function is here
virtual const char* name() const = 0;
BUG=skia:3075
TEST=ninja -C out/Debug skia_lib
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/789343003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/808703006
|
|
|
|
| |
Review URL: https://codereview.chromium.org/816513003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/808813002
|
|
|
|
|
|
|
|
| |
Sized texture formats are accepted by OpenGL desktop and ES 3.0,
except when using BGRA with GL_EXT_texture_format_BGRA8888.
In that case we fall back to using the unsized format.
Review URL: https://codereview.chromium.org/811133002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/805293003
|
|
|
|
|
|
| |
This mimics how layers are set up in SkGpuDevice::onCreateCompatibleDevice
Review URL: https://codereview.chromium.org/809823003
|
|
|
|
|
|
| |
Temporary fix for WritePixels test on Nexus 5/Nexus 7-2013.
Review URL: https://codereview.chromium.org/794273005
|