aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
...
* Blink hasn't rolled yet.Gravatar Mike Klein2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/754133002
* make SkRefCnt::getRefCnt() debug-only, remove it from SkNVRefCnt.Gravatar mtklein2014-11-24
| | | | | | | | | Only (unused) API removed. TBR=reed@google.com BUG=skia:3160 Review URL: https://codereview.chromium.org/752263002
* Add nanobench stats scripts to Skia repo.Gravatar mtklein2014-11-24
| | | | | | | | These are the scripts I've been homegrowing for measuring perf impact. I think we found them useful today as a way of sifting through the noise. BUG=skia: Review URL: https://codereview.chromium.org/703713002
* Revert "Use scratch keys for stencil buffers."Gravatar bsalomon2014-11-24
| | | | | | | | | | | | | | | | This reverts commit 91175f19664a62851da4ca4e0984a7c7c45b258f. Revert "Cleanup res cache bench and split out into a unit test." This reverts commit 4e4303f002c5958c6c958e7ba8e49b24c25f0b22. Revert "rebaselines" This reverts commit 65ba7b57759bfca60b24bc34dc46fc8caaf146f0. TBR=tomhudson@google.com Review URL: https://codereview.chromium.org/752233002
* add some debugging to SkNVRefCntGravatar reed2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/745383003
* Revert of More rebaselines (patchset #1 id:1 of ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/754833003/) Reason for revert: Reverted causative patchset (https://codereview.chromium.org/747043004) Original issue's description: > More rebaselines > > TBR= > NOTRY=true > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/0ef7ba2a43a41e8e1e49a5187073db6dcca345b4 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/756633004
* Revert of more rebaselines (patchset #1 id:1 of ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/755653003/) Reason for revert: Reverted causative patch (https://codereview.chromium.org/747043004) Original issue's description: > more rebaselines > > TBR= > NOTRY=true > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/f2fdc8b746acac9daa94b21d3849f60a87064fd4 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/754103002
* Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | functions (patchset #1 id:1 of https://codereview.chromium.org/750973003/) Reason for revert: Original patchset seems to have been exonerated. Crash was mac-specific, but appears to be triggered by a non-mac-specific change (https://codereview.chromium.org/747043004/); suspecting driver bug? Original issue's description: > Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/) > > Reason for revert: > Suspected in DM crashes, e.g. > > 2033 tasks left 344M peak 843ms tabl-cuteoverload_skp > Signal 11: > _sigtramp (+0x1a) > create_surface(CanvasConfig const&, GrContext*) (+0x1b2) > test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4) > skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21) > skiatest::Test::run() (+0x7c) > DM::GpuTestTask::draw(GrContextFactory*) (+0x8c) > DM::GpuTask::run(GrContextFactory*) (+0xa6) > DM::TaskRunner::wait() (+0x7f) > dm_main() (+0x33f) > main (+0x27) > > > On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}): > > http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug > > > Original issue's description: > > Add gpu support for Apple specific 'Vertex Arrays' functions > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc > > TBR=bsalomon@google.com,paraboul@gmail.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/55fe3d7748b873e362edc4e6a43bd77914ed25fb TBR=bsalomon@google.com,paraboul@gmail.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/734633005
* Suppress additional multipicturedraw GM for AndroidGravatar robertphillips2014-11-24
| | | | | | | | | | One Android bot is failing on the rect test case. TBR=tomhudson@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/750203003
* Sigh - remove whitespace from end of suppressions text lineGravatar robertphillips2014-11-24
| | | | | | | | TBR=tomhudson@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/754783003
* Add suppressions for https://codereview.chromium.org/748853002Gravatar robertphillips2014-11-24
| | | | | | | | TBR=tomhudson@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/753103005
* Revert of Add gpu support for Apple specific 'Vertex Arrays' functions ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/754653002/) Reason for revert: Suspected in DM crashes, e.g. 2033 tasks left 344M peak 843ms tabl-cuteoverload_skp Signal 11: _sigtramp (+0x1a) create_surface(CanvasConfig const&, GrContext*) (+0x1b2) test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4) skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21) skiatest::Test::run() (+0x7c) DM::GpuTestTask::draw(GrContextFactory*) (+0x8c) DM::GpuTask::run(GrContextFactory*) (+0xa6) DM::TaskRunner::wait() (+0x7f) dm_main() (+0x33f) main (+0x27) On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}): http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug Original issue's description: > Add gpu support for Apple specific 'Vertex Arrays' functions > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc TBR=bsalomon@google.com,paraboul@gmail.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/750973003
* Add support for hoisting layers in pictures drawn with a matrixGravatar robertphillips2014-11-24
| | | | | | | | Although Chromium doesn't use the drawPicture matrix parameter for their tiling, our local code does. Without such drawPicture calls break layer hoisting. BUG=skia:2315 Review URL: https://codereview.chromium.org/748853002
* Add Sk prefix to CreateBitmapShader.Gravatar mtklein2014-11-24
| | | | | | | | It's neither static nor namespaced, so we should probably prefix it. BUG=skia: Review URL: https://codereview.chromium.org/754083002
* Remove android-framework-only unused parameter.Gravatar scroggo2014-11-24
| | | | | | Allows -Werror=unused-parameter to build on android framework. Review URL: https://codereview.chromium.org/757633002
* More rebaselinesGravatar bsalomon2014-11-24
| | | | | | | | TBR= NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/754833003
* Cleanup res cache bench and split out into a unit test.Gravatar bsalomon2014-11-24
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/754833002
* Remove Picture deletion listeners.Gravatar mtklein2014-11-24
| | | | | | | | Looks like we can just have ~SkPicture put the message on the bus directly. BUG=skia:3144 Review URL: https://codereview.chromium.org/751663002
* more rebaselinesGravatar bsalomon2014-11-24
| | | | | | | | TBR= NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/755653003
* rebaselinesGravatar bsalomon2014-11-24
| | | | | | | | NOTRY=true NOTREECHECKS=true TBR= Review URL: https://codereview.chromium.org/753133003
* Add gpu support for Apple specific 'Vertex Arrays' functionsGravatar paraboul2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/754653002
* Use scratch keys for stencil buffers.Gravatar bsalomon2014-11-24
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/747043004
* Cleanup of S32_D565_Opaque_SSE2()Gravatar qiankun.miao2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/725693003
* Create GrOptDrawState directly in the cmd buffer in GrIODB.Gravatar bsalomon2014-11-24
| | | | Review URL: https://codereview.chromium.org/746243002
* use int instead of size_t to match skia conventionGravatar reed2014-11-23
| | | | | | | BUG=skia: TBR=mtklein@google.com Review URL: https://codereview.chromium.org/753903002
* Update SKP versionGravatar skia.buildbots2014-11-22
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/747323005
* Update SKP versionGravatar skia.buildbots2014-11-21
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/728943003
* Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of ↵Gravatar mtklein2014-11-21
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/702893003/) Reason for revert: Not clean yet. Original issue's description: > Add -ftrapv to debug builds. > > This adds instrumentation to check that signed integers never under- or > overflow, which is undefined behavior. > > BUG=skia:3096 > > Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3096 Review URL: https://codereview.chromium.org/751713002
* Add pop_back to GrTRecorder.hGravatar bsalomon2014-11-21
| | | | Review URL: https://codereview.chromium.org/750613002
* Add -ftrapv to debug builds.Gravatar mtklein2014-11-21
| | | | | | | | | This adds instrumentation to check that signed integers never under- or overflow, which is undefined behavior. BUG=skia:3096 Review URL: https://codereview.chromium.org/702893003
* Clean up FreeType code for 2.3.8.Gravatar bungeman2014-11-21
| | | | | | | We already require FreeType 2.3.8 in order to compile and run. Make this requirement explicit and take advantage of it. Review URL: https://codereview.chromium.org/748063003
* ack verylargebitmap diffsGravatar mtklein2014-11-21
| | | | | | | | NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/752693002
* SkPicture::SnapshotArray doesn't really stand to benefit from refcounting.Gravatar mtklein2014-11-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/748803005
* Switch SkBitmapProcState's SkFractionalInt to 32.32.Gravatar mtklein2014-11-21
| | | | | | | | | | | 16 bits are not enough to hold the integral part of fx in Clamp_S32_opaque_D32_nofilter_DX_shaderproc. Weirdly, no GM diffs on my desktop. BUG=skia:3096 Review URL: https://codereview.chromium.org/733163003
* Simplfy DEPS: always pull all deps, remove unused barelinux platform.Gravatar mtklein2014-11-21
| | | | | | | | Left some notes about where we might further clean up. BUG=skia: Review URL: https://codereview.chromium.org/753633002
* Watch out for SkFixed overflow in SkMipMap.cpp.Gravatar mtklein2014-11-21
| | | | | | | | | | | Tested with -fsanitize=signed-integer-overflow. This new assert used to trigger in MipMap unit test. Don't appear to be any GM diffs. BUG=skia: Review URL: https://codereview.chromium.org/729373004
* public SkNVRefCnt<SnapshotArray>Gravatar mtklein2014-11-21
| | | | | | | | | | | Should fix broken build. NOTRY=true TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/748143002
* SkData -> SkPicture::SnapshotArrayGravatar mtklein2014-11-21
| | | | | | | | | | Restores type safety with all the same features. (Also note, less code: 29 insertions, 50 deletions.) BUG=skia: Review URL: https://codereview.chromium.org/746553002
* clarify samplecount field in imagegpuGravatar reed2014-11-21
| | | | | | | BUG=skia: TBR=bsalomon Review URL: https://codereview.chromium.org/750023002
* Fix error in Ganesh' tiled bitmap drawingGravatar robertphillips2014-11-21
| | | | | | | | When the paint filter level is high ShouldUseBicubic doesn't always return true. In this case the paint's filter level will differ from the filtering Ganesh will use. This was leading to a mismatch between the tiling computed in SkGpuDevice::drawBitmapCommon and the one in SkGpuDevice::drawTiledBitmap. The end result of this was that the max texture restriction could be violated which is currently being seen on the Xoom & N7 bots. Both of them have a max texture size of 2048 which is invoking the tiled drawbitmap case. Review URL: https://codereview.chromium.org/752623002
* remove GrAllocPoolGravatar joshualitt2014-11-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/742253002
* All the small packing tweaks mentioned in the bug.Gravatar mtklein2014-11-21
| | | | | | BUG=skia:3144 Review URL: https://codereview.chromium.org/748063002
* add SkImage::newSurfaceGravatar reed2014-11-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/741763002
* simplify uniqueID code in pictureGravatar reed2014-11-21
| | | | | | | | patch from issue 750003002 at patchset 1 (http://crrev.com/750003002#ps1) BUG=skia: Review URL: https://codereview.chromium.org/752573002
* Ignore a flaky msaa4 GM and some perma-broken S4 GMsGravatar robertphillips2014-11-21
| | | | | | | | | The Ubuntu12 msaa4 image seems to flake randomly The S4 images are covered by skia:3116 (Galaxy S4 exhibits some saveLayer bugs (both normal and with hoisting)) TBR=humper@google.com Review URL: https://codereview.chromium.org/748773003
* Fix memory leak in nanobenchGravatar robertphillips2014-11-21
| | | | | | This is cleanup for (Add MultiPictureDraw to nanobench - https://codereview.chromium.org/731973005/) Review URL: https://codereview.chromium.org/730343003
* Small changes to get things building and running on Linux/ARM.Gravatar mtklein2014-11-21
| | | | | | | | | | | | ninja -C out/Debug works, and I tested out/Debug/dm --nogpu (no X yet). The only problems encountered were: - Like CrOS, I also needed to use the default float ABI (presumably hard). - The strings in GrBinHashKeyTest weren't necessarily 4-byte aligned. BUG=skia: Review URL: https://codereview.chromium.org/746043002
* Add MultiPictureDraw to nanobenchGravatar robertphillips2014-11-21
| | | | | | | | | | I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium. TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe Review URL: https://codereview.chromium.org/731973005
* Revert of Add MultiPictureDraw to nanobench (patchset #7 id:120001 of ↵Gravatar robertphillips2014-11-21
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/731973005/) Reason for revert: Needs more work Original issue's description: > Add MultiPictureDraw to nanobench > > I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium. > > TBR=bsalomon@google.com > > Committed: https://skia.googlesource.com/skia/+/0ddad31012dabfc1267effc8071d37f7d606efbe TBR=mtklein@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/750583002
* Add MultiPictureDraw to nanobenchGravatar robertphillips2014-11-21
| | | | | | | | I would like some guard against performance regressions on our side before turning layer hoisting on in Chromium. TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/731973005
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-31 07:38:27 +0000