diff options
| author |  tomhudson <tomhudson@chromium.org> | 2014-11-24 09:59:41 -0800 |
|---|---|---|
| committer |  Commit bot <commit-bot@chromium.org> | 2014-11-24 09:59:41 -0800 |
| commit | 55fe3d7748b873e362edc4e6a43bd77914ed25fb (patch) | |
| tree | 0cdeac2aaa3105997304f246bc37eccc5ff2b6ed | |
| parent | 30d7841f906116c3945ec8125a816a5c5462fed0 (diff) | |
Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/)
Reason for revert:
Suspected in DM crashes, e.g.
2033 tasks left 344M peak 843ms tabl-cuteoverload_skp
Signal 11:
_sigtramp (+0x1a)
create_surface(CanvasConfig const&, GrContext*) (+0x1b2)
test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4)
skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21)
skiatest::Test::run() (+0x7c)
DM::GpuTestTask::draw(GrContextFactory*) (+0x8c)
DM::GpuTask::run(GrContextFactory*) (+0xa6)
DM::TaskRunner::wait() (+0x7f)
dm_main() (+0x33f)
main (+0x27)
On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}):
http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug
Original issue's description:
> Add gpu support for Apple specific 'Vertex Arrays' functions
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc
TBR=bsalomon@google.com,paraboul@gmail.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/750973003
| -rw-r--r-- | AUTHORS | 1 | ||||
| -rw-r--r-- | src/gpu/gl/GrGLAssembleInterface.cpp | 4 | ||||
| -rw-r--r-- | src/gpu/gl/GrGLCaps.cpp | 3 |
3 files changed, 1 insertions, 7 deletions
@@ -32,4 +32,3 @@ The Chromium Authors <*@chromium.org> Thiago Fransosi Farina <thiago.farina@gmail.com> Pavel Krajcevski <pavel@cs.unc.edu> Ion Rosca <rosca@adobe.com> -Anthony Catel <paraboul@gmail.com> diff --git a/src/gpu/gl/GrGLAssembleInterface.cpp b/src/gpu/gl/GrGLAssembleInterface.cpp index 25f9e161f4..425ed647c5 100644 --- a/src/gpu/gl/GrGLAssembleInterface.cpp +++ b/src/gpu/gl/GrGLAssembleInterface.cpp @@ -196,10 +196,6 @@ const GrGLInterface* GrGLAssembleGLInterface(void* ctx, GrGLGetProc get) { GET_PROC(BindVertexArray); GET_PROC(GenVertexArrays); GET_PROC(DeleteVertexArrays); - } else if (extensions.has("GL_APPLE_vertex_array_object")) { - GET_PROC_SUFFIX(BindVertexArray, APPLE); - GET_PROC_SUFFIX(GenVertexArrays, APPLE); - GET_PROC_SUFFIX(DeleteVertexArrays, APPLE); } if (glVer >= GR_GL_VER(3,0) || extensions.has("GL_ARB_map_buffer_range")) { diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp index 414f06d6ae..6272aba127 100644 --- a/src/gpu/gl/GrGLCaps.cpp +++ b/src/gpu/gl/GrGLCaps.cpp @@ -235,8 +235,7 @@ bool GrGLCaps::init(const GrGLContextInfo& ctxInfo, const GrGLInterface* gli) { if (kGL_GrGLStandard == standard) { fVertexArrayObjectSupport = version >= GR_GL_VER(3, 0) || - ctxInfo.hasExtension("GL_ARB_vertex_array_object") || - ctxInfo.hasExtension("GL_APPLE_vertex_array_object"); + ctxInfo.hasExtension("GL_ARB_vertex_array_object"); } else { fVertexArrayObjectSupport = version >= GR_GL_VER(3, 0) || ctxInfo.hasExtension("GL_OES_vertex_array_object"); |