aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Cleanup: Remove bug_chomper entry from .gitignore.Gravatar tfarina2014-11-24
| | | | | | | | | | This is not necessary anymore, now that bug_chomper was moved into skia.googlesource.com/buildbot.git BUG=None TBR=borenet@google.com Review URL: https://codereview.chromium.org/748363002
* SkRecord: outline methods that are not called O(N) times.Gravatar mtklein2014-11-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Looks like a noop-to-minor-win: tabl_sahadan.skp 94.9us -> 98.6us 1x desk_jsfiddlebigcar.skp 38.9us -> 39.7us 1x desk_silkfinance.skp 78us -> 78.9us 1x desk_jsfiddlehumperclip.skp 43.8us -> 44.3us 1x desk_sfgate.skp 547us -> 548us 1x tabl_gmail.skp 19.9us -> 19.8us 1x tabl_worldjournal.skp 230us -> 229us 1x desk_css3gradients.skp 248us -> 247us 1x tabl_cnn.skp 205us -> 203us 0.99x desk_linkedin.skp 342us -> 340us 0.99x desk_wowwiki.skp 1.63ms -> 1.62ms 0.99x tabl_cnet.skp 142us -> 141us 0.99x desk_pokemonwiki.skp 9.76ms -> 9.67ms 0.99x desk_espn.skp 267us -> 264us 0.99x desk_youtube.skp 576us -> 570us 0.99x tabl_pravda.skp 238us -> 235us 0.99x tabl_ukwsj.skp 566us -> 560us 0.99x tabl_engadget.skp 630us -> 622us 0.99x desk_googlespreadsheetdashed.skp 1.66ms -> 1.64ms 0.99x desk_mobilenews.skp 486us -> 480us 0.99x tabl_googlecalendar.skp 211us -> 208us 0.99x desk_samoasvg.skp 740us -> 730us 0.99x desk_gws.skp 187us -> 184us 0.99x desk_ebay.skp 234us -> 230us 0.99x desk_mapsvg.skp 1.6ms -> 1.58ms 0.98x tabl_nytimes.skp 130us -> 128us 0.98x tabl_googleblog.skp 305us -> 300us 0.98x desk_fontwipe.skp 40.3us -> 39.6us 0.98x desk_tigersvg.skp 189us -> 186us 0.98x tabl_androidpolice.skp 662us -> 650us 0.98x desk_wordpress.skp 824us -> 809us 0.98x tabl_mlb.skp 338us -> 331us 0.98x tabl_culturalsolutions.skp 390us -> 382us 0.98x desk_baidu.skp 213us -> 208us 0.98x tabl_gspro.skp 72.9us -> 71.1us 0.97x tabl_nofolo.skp 74us -> 71.9us 0.97x desk_yahooanswers.skp 173us -> 168us 0.97x tabl_frantzen.skp 57.3us -> 55.6us 0.97x desk_chalkboard.skp 891us -> 865us 0.97x desk_pinterest.skp 154us -> 149us 0.97x desk_blogger.skp 537us -> 519us 0.97x tabl_hsfi.skp 10.1us -> 9.69us 0.96x desk_gmailthread.skp 333us -> 318us 0.96x tabl_digg.skp 926us -> 883us 0.95x desk_googlespreadsheet.skp 586us -> 558us 0.95x desk_forecastio.skp 101us -> 95.7us 0.95x desk_booking.skp 1.1ms -> 1.04ms 0.95x tabl_deviantart.skp 144us -> 136us 0.95x desk_facebook.skp 584us -> 553us 0.95x desk_weather.skp 289us -> 272us 0.94x desk_googlehome.skp 61.1us -> 57.5us 0.94x desk_googleplus.skp 914us -> 849us 0.93x desk_twitter.skp 499us -> 463us 0.93x BUG=skia: Review URL: https://codereview.chromium.org/756783002
* Don't count a leading 1 as a signficant digit in the ratio.Gravatar Mike Klein2014-11-24
| | | | | | | | | | | | | | | | | | | | | | | | | What used to look like this: desk_pokemonwiki.skp 9.38ms -> 9.76ms 1x tabl_pravda.skp 237us -> 241us 1x desk_css3gradients.skp 249us -> 254us 1x .... desk_fontwipe.skp 39.6us -> 38.7us 0.98x tabl_digg.skp 922us -> 893us 0.97x tabl_gmail.skp 20.7us -> 20us 0.96x Now will print more like this: desk_pokemonwiki.skp 9.38ms -> 9.76ms 1.04x tabl_pravda.skp 237us -> 241us 1.02x desk_css3gradients.skp 249us -> 254us 1.02x .... desk_fontwipe.skp 39.6us -> 38.7us 0.98x tabl_digg.skp 922us -> 893us 0.97x tabl_gmail.skp 20.7us -> 20us 0.96x BUG=skia: Review URL: https://codereview.chromium.org/756643004
* option to return drawable from recordingGravatar reed2014-11-24
| | | | | | | | patch from issue 747033005 at patchset 80001 (http://crrev.com/747033005#ps80001) BUG=skia: Review URL: https://codereview.chromium.org/732653004
* Blink hasn't rolled yet, better.Gravatar Mike Klein2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/758693002
* Revert of Blink hasn't rolled yet. (patchset #1 id:1 of ↵Gravatar mtklein2014-11-24
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/754133002/) Reason for revert: Not thorough enough. Original issue's description: > Blink hasn't rolled yet. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fa14113d0563686af9f7e2d8e041dd7bf538cfa2 TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/752303002
* restore old convention of asserting refcnt==1 in destructorGravatar reed2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/757563003
* Blink hasn't rolled yet.Gravatar Mike Klein2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/754133002
* make SkRefCnt::getRefCnt() debug-only, remove it from SkNVRefCnt.Gravatar mtklein2014-11-24
| | | | | | | | | Only (unused) API removed. TBR=reed@google.com BUG=skia:3160 Review URL: https://codereview.chromium.org/752263002
* Add nanobench stats scripts to Skia repo.Gravatar mtklein2014-11-24
| | | | | | | | These are the scripts I've been homegrowing for measuring perf impact. I think we found them useful today as a way of sifting through the noise. BUG=skia: Review URL: https://codereview.chromium.org/703713002
* Revert "Use scratch keys for stencil buffers."Gravatar bsalomon2014-11-24
| | | | | | | | | | | | | | | | This reverts commit 91175f19664a62851da4ca4e0984a7c7c45b258f. Revert "Cleanup res cache bench and split out into a unit test." This reverts commit 4e4303f002c5958c6c958e7ba8e49b24c25f0b22. Revert "rebaselines" This reverts commit 65ba7b57759bfca60b24bc34dc46fc8caaf146f0. TBR=tomhudson@google.com Review URL: https://codereview.chromium.org/752233002
* add some debugging to SkNVRefCntGravatar reed2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/745383003
* Revert of More rebaselines (patchset #1 id:1 of ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/754833003/) Reason for revert: Reverted causative patchset (https://codereview.chromium.org/747043004) Original issue's description: > More rebaselines > > TBR= > NOTRY=true > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/0ef7ba2a43a41e8e1e49a5187073db6dcca345b4 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/756633004
* Revert of more rebaselines (patchset #1 id:1 of ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/755653003/) Reason for revert: Reverted causative patch (https://codereview.chromium.org/747043004) Original issue's description: > more rebaselines > > TBR= > NOTRY=true > NOTREECHECKS=true > > Committed: https://skia.googlesource.com/skia/+/f2fdc8b746acac9daa94b21d3849f60a87064fd4 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/754103002
* Revert of Revert of Add gpu support for Apple specific 'Vertex Arrays' ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | functions (patchset #1 id:1 of https://codereview.chromium.org/750973003/) Reason for revert: Original patchset seems to have been exonerated. Crash was mac-specific, but appears to be triggered by a non-mac-specific change (https://codereview.chromium.org/747043004/); suspecting driver bug? Original issue's description: > Revert of Add gpu support for Apple specific 'Vertex Arrays' functions (patchset #2 id:20001 of https://codereview.chromium.org/754653002/) > > Reason for revert: > Suspected in DM crashes, e.g. > > 2033 tasks left 344M peak 843ms tabl-cuteoverload_skp > Signal 11: > _sigtramp (+0x1a) > create_surface(CanvasConfig const&, GrContext*) (+0x1b2) > test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4) > skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21) > skiatest::Test::run() (+0x7c) > DM::GpuTestTask::draw(GrContextFactory*) (+0x8c) > DM::GpuTask::run(GrContextFactory*) (+0xa6) > DM::TaskRunner::wait() (+0x7f) > dm_main() (+0x33f) > main (+0x27) > > > On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}): > > http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug > > > Original issue's description: > > Add gpu support for Apple specific 'Vertex Arrays' functions > > > > BUG=skia: > > > > Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc > > TBR=bsalomon@google.com,paraboul@gmail.com > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/55fe3d7748b873e362edc4e6a43bd77914ed25fb TBR=bsalomon@google.com,paraboul@gmail.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/734633005
* Suppress additional multipicturedraw GM for AndroidGravatar robertphillips2014-11-24
| | | | | | | | | | One Android bot is failing on the rect test case. TBR=tomhudson@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/750203003
* Sigh - remove whitespace from end of suppressions text lineGravatar robertphillips2014-11-24
| | | | | | | | TBR=tomhudson@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/754783003
* Add suppressions for https://codereview.chromium.org/748853002Gravatar robertphillips2014-11-24
| | | | | | | | TBR=tomhudson@google.com NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/753103005
* Revert of Add gpu support for Apple specific 'Vertex Arrays' functions ↵Gravatar tomhudson2014-11-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/754653002/) Reason for revert: Suspected in DM crashes, e.g. 2033 tasks left 344M peak 843ms tabl-cuteoverload_skp Signal 11: _sigtramp (+0x1a) create_surface(CanvasConfig const&, GrContext*) (+0x1b2) test_WritePixels(skiatest::Reporter*, GrContextFactory*) (+0x8d4) skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (+0x21) skiatest::Test::run() (+0x7c) DM::GpuTestTask::draw(GrContextFactory*) (+0x8c) DM::GpuTask::run(GrContextFactory*) (+0xa6) DM::TaskRunner::wait() (+0x7f) dm_main() (+0x33f) main (+0x27) On all MacMini platforms (the following URL with -Mac{10.6,10.7,10.8}- and -{Debug,Release}): http://build.chromium.org/p/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug Original issue's description: > Add gpu support for Apple specific 'Vertex Arrays' functions > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/af000f469e1b0153ce445c96ca3d20e6d12224cc TBR=bsalomon@google.com,paraboul@gmail.com NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/750973003
* Add support for hoisting layers in pictures drawn with a matrixGravatar robertphillips2014-11-24
| | | | | | | | Although Chromium doesn't use the drawPicture matrix parameter for their tiling, our local code does. Without such drawPicture calls break layer hoisting. BUG=skia:2315 Review URL: https://codereview.chromium.org/748853002
* Add Sk prefix to CreateBitmapShader.Gravatar mtklein2014-11-24
| | | | | | | | It's neither static nor namespaced, so we should probably prefix it. BUG=skia: Review URL: https://codereview.chromium.org/754083002
* Remove android-framework-only unused parameter.Gravatar scroggo2014-11-24
| | | | | | Allows -Werror=unused-parameter to build on android framework. Review URL: https://codereview.chromium.org/757633002
* More rebaselinesGravatar bsalomon2014-11-24
| | | | | | | | TBR= NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/754833003
* Cleanup res cache bench and split out into a unit test.Gravatar bsalomon2014-11-24
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/754833002
* Remove Picture deletion listeners.Gravatar mtklein2014-11-24
| | | | | | | | Looks like we can just have ~SkPicture put the message on the bus directly. BUG=skia:3144 Review URL: https://codereview.chromium.org/751663002
* more rebaselinesGravatar bsalomon2014-11-24
| | | | | | | | TBR= NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/755653003
* rebaselinesGravatar bsalomon2014-11-24
| | | | | | | | NOTRY=true NOTREECHECKS=true TBR= Review URL: https://codereview.chromium.org/753133003
* Add gpu support for Apple specific 'Vertex Arrays' functionsGravatar paraboul2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/754653002
* Use scratch keys for stencil buffers.Gravatar bsalomon2014-11-24
| | | | | | BUG=skia:2889 Review URL: https://codereview.chromium.org/747043004
* Cleanup of S32_D565_Opaque_SSE2()Gravatar qiankun.miao2014-11-24
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/725693003
* Create GrOptDrawState directly in the cmd buffer in GrIODB.Gravatar bsalomon2014-11-24
| | | | Review URL: https://codereview.chromium.org/746243002
* use int instead of size_t to match skia conventionGravatar reed2014-11-23
| | | | | | | BUG=skia: TBR=mtklein@google.com Review URL: https://codereview.chromium.org/753903002
* Update SKP versionGravatar skia.buildbots2014-11-22
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/747323005
* Update SKP versionGravatar skia.buildbots2014-11-21
| | | | | | | | Automatic commit by the RecreateSKPs bot. TBR= Review URL: https://codereview.chromium.org/728943003
* Revert of Add -ftrapv to debug builds. (patchset #1 id:1 of ↵Gravatar mtklein2014-11-21
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/702893003/) Reason for revert: Not clean yet. Original issue's description: > Add -ftrapv to debug builds. > > This adds instrumentation to check that signed integers never under- or > overflow, which is undefined behavior. > > BUG=skia:3096 > > Committed: https://skia.googlesource.com/skia/+/ebacb6127a952910f43a59460af43427d93df46c TBR=bungeman@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia:3096 Review URL: https://codereview.chromium.org/751713002
* Add pop_back to GrTRecorder.hGravatar bsalomon2014-11-21
| | | | Review URL: https://codereview.chromium.org/750613002
* Add -ftrapv to debug builds.Gravatar mtklein2014-11-21
| | | | | | | | | This adds instrumentation to check that signed integers never under- or overflow, which is undefined behavior. BUG=skia:3096 Review URL: https://codereview.chromium.org/702893003
* Clean up FreeType code for 2.3.8.Gravatar bungeman2014-11-21
| | | | | | | We already require FreeType 2.3.8 in order to compile and run. Make this requirement explicit and take advantage of it. Review URL: https://codereview.chromium.org/748063003
* ack verylargebitmap diffsGravatar mtklein2014-11-21
| | | | | | | | NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/752693002
* SkPicture::SnapshotArray doesn't really stand to benefit from refcounting.Gravatar mtklein2014-11-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/748803005
* Switch SkBitmapProcState's SkFractionalInt to 32.32.Gravatar mtklein2014-11-21
| | | | | | | | | | | 16 bits are not enough to hold the integral part of fx in Clamp_S32_opaque_D32_nofilter_DX_shaderproc. Weirdly, no GM diffs on my desktop. BUG=skia:3096 Review URL: https://codereview.chromium.org/733163003
* Simplfy DEPS: always pull all deps, remove unused barelinux platform.Gravatar mtklein2014-11-21
| | | | | | | | Left some notes about where we might further clean up. BUG=skia: Review URL: https://codereview.chromium.org/753633002
* Watch out for SkFixed overflow in SkMipMap.cpp.Gravatar mtklein2014-11-21
| | | | | | | | | | | Tested with -fsanitize=signed-integer-overflow. This new assert used to trigger in MipMap unit test. Don't appear to be any GM diffs. BUG=skia: Review URL: https://codereview.chromium.org/729373004
* public SkNVRefCnt<SnapshotArray>Gravatar mtklein2014-11-21
| | | | | | | | | | | Should fix broken build. NOTRY=true TBR=reed@google.com BUG=skia: Review URL: https://codereview.chromium.org/748143002
* SkData -> SkPicture::SnapshotArrayGravatar mtklein2014-11-21
| | | | | | | | | | Restores type safety with all the same features. (Also note, less code: 29 insertions, 50 deletions.) BUG=skia: Review URL: https://codereview.chromium.org/746553002
* clarify samplecount field in imagegpuGravatar reed2014-11-21
| | | | | | | BUG=skia: TBR=bsalomon Review URL: https://codereview.chromium.org/750023002
* Fix error in Ganesh' tiled bitmap drawingGravatar robertphillips2014-11-21
| | | | | | | | When the paint filter level is high ShouldUseBicubic doesn't always return true. In this case the paint's filter level will differ from the filtering Ganesh will use. This was leading to a mismatch between the tiling computed in SkGpuDevice::drawBitmapCommon and the one in SkGpuDevice::drawTiledBitmap. The end result of this was that the max texture restriction could be violated which is currently being seen on the Xoom & N7 bots. Both of them have a max texture size of 2048 which is invoking the tiled drawbitmap case. Review URL: https://codereview.chromium.org/752623002
* remove GrAllocPoolGravatar joshualitt2014-11-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/742253002
* All the small packing tweaks mentioned in the bug.Gravatar mtklein2014-11-21
| | | | | | BUG=skia:3144 Review URL: https://codereview.chromium.org/748063002
* add SkImage::newSurfaceGravatar reed2014-11-21
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/741763002